Spec URL: http://mo.morsi.org/files/jruby/yecht.spec SRPM URL: http://mo.morsi.org/files/jruby/yecht-0.0.2-1.fc12.src.rpm Description: Yecht is a Syck port, a YAML 1.0 processor for Ruby. Required by JRuby. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1959853 $ rpmlint rpmbuild/RPMS/i386/yecht-0.0.2-1.fc12.i386.rpm yecht.i386: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Ignoring error as no documentation is provided in the source. $ rpmlint rpmbuild/SRPMS/yecht-0.0.2-1.fc12.src.rpm yecht.src:81: W: libdir-macro-in-noarch-package (main package) %attr(-,root,root) %{_libdir}/gcj/%{name} 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Ignoring this last warning as when package is noarch (eg if using java-openjdk) the libdir file will not be included, and when the package is architecture specific (eg when using gcj) it will be. See spec file for conditionals.
I'm taking this one. Please drop gcj_support. It is really giving no benefits but drags gcj in. There should be a javadoc subpackage.
Updated, gcj removed, no javadocs provided by upstream so no subpackage is necessary New spec / srpm: Spec URL: http://mo.morsi.org/files/jruby/yecht.spec SRPM URL: http://mo.morsi.org/files/jruby/yecht-0.0.2-2.fc11.src.rpm
I would really like to see a javadoc subpackage. Build.xml patch will follow shortly.
Created attachment 411528 [details] Patch for adding javadoc
Attached patch adds javadocs target. Please make sure that you send such patches upstream.
I believe you uploaded the yydebug/javadocs patch here as well by mistake.
Created attachment 411711 [details] The correct patch
Oops sorry. The right one is attached now.
New Spec/SRPM w/ javadocs Spec URL: http://mo.morsi.org/files/jruby/yecht.spec SRPM URL: http://mo.morsi.org/files/jruby/yecht-0.0.2-3.fc11.src.rpm New koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2165802
Review: OK: rpmlint must be run on every package. OUTPUT: yecht.noarch: W: no-documentation yecht-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Javanese Not a problem. I really haven't found anything suitable for documentation and javadocs is a common word for developers. OK: The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. NOTOK: The sources used to build the package must match the upstream source, as provided in the spec URL. SOURCES are different. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK: Packages must NOT bundle copies of system libraries. OK: A package must own all directories that it creates. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. OK: Large documentation files must go in a -doc subpackage. Javadocs subpackage. OK: If a package includes something as %doc, it must not affect the runtime of the application. OK: Packages must not own files or directories already owned by other packages. OK: All filenames in rpm packages must be valid UTF-8. Please fix the sources
Sync'd srpm source w/ upstream (md5sums now match). New spec/srpm: Spec URL: http://mo.morsi.org/files/jruby/yecht.spec SRPM URL: http://mo.morsi.org/files/jruby/yecht-0.0.2-4.fc11.src.rpm
(In reply to comment #11) > Sync'd srpm source w/ upstream (md5sums now match). New spec/srpm: > > Spec URL: http://mo.morsi.org/files/jruby/yecht.spec > SRPM URL: http://mo.morsi.org/files/jruby/yecht-0.0.2-4.fc11.src.rpm Thanks, This package is APPROVED.
New Package CVS Request ======================= Package Name: yecht Short Description: A YAML processor based on Syck Owners: mmorsi Branches: F-12 F-13 InitialCC:
CVS done (by process-cvs-requests.py).
yecht-0.0.2-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/yecht-0.0.2-4.fc13
yecht-0.0.2-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/yecht-0.0.2-4.fc12
yecht-0.0.2-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
yecht-0.0.2-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.