Spec URL: http://linville.fedorapeople.org/ar9170-firmware.spec SRPM URL: http://linville.fedorapeople.org/ar9170-firmware-2009.05.28-1.fc11.src.rpm Description: This package contains the firmware required by the ar9170 driver for Linux to support the ar9170 hardware. Usage of the firmware is subject to the terms and conditions contained inside the provided LICENSE file. Please read it carefully.
I'll review this.
REVIEW: + rpmlint is silent [petro@Sulaco SPECS]$ rpmlint ../RPMS/noarch/ar9170-firmware-2009.05.28-1.fc12.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [petro@Sulaco SPECS]$ + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. - The package DOES NOT meet the Packaging Guidelines - one missing "Requires: udev" (owner of /lib/firmware). Other things looks sane. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license. + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. [petro@Sulaco SOURCES]$ sha256sum ar9170.fw* 1b379c5a8d6ab3a43911f7949d6306fe2dae3afb1368be5452a8fc7d9c54e0a0 ar9170.fw 1b379c5a8d6ab3a43911f7949d6306fe2dae3afb1368be5452a8fc7d9c54e0a0 ar9170.fw.1 [petro@Sulaco SOURCES]$ + The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files. + The package does NOT bundle copies of system libraries. + The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. So, please, add the only missing Requires, and I'll continue.
BTW are there any particular reasons not to package ver. 2010-02-03 ? ( )http://www.kernel.org/pub/linux/kernel/people/mcgrof/firmware/ar9170/2010-02-03/
Spec URL: http://linville.fedorapeople.org/ar9170-firmware.spec SRPM URL: http://linville.fedorapeople.org/ar9170-firmware-2009.05.28-2.fc11.src.rpm Doh! Missed the Requires for udev -- that's what I get for copying an old spec file from another firmware package rather than taking the current version of that spec from CVS. :-) The 2010-02-03 firmware version was published for comments and is really more of a "beta" release at this point. I imagine it will be picked-up as an update, but just in case there is a problem I figured I'd get the package started with the stable version.
Ok, understood. I don't see any other issues, and this package is APPROVED.
New Package CVS Request ======================= Package Name: ar9170-firmware Short Description: Firmware for Atheros AR9170 wireless network adapters Owners: linville Branches: F-11 F-12 InitialCC: linville
CVS done (by process-cvs-requests.py).
ar9170-firmware-2009.05.28-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/ar9170-firmware-2009.05.28-2.fc11
ar9170-firmware-2009.05.28-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/ar9170-firmware-2009.05.28-2.fc12
ar9170-firmware-2009.05.28-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
ar9170-firmware-2009.05.28-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.