Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-collabnet-merge.spec SRPM URL: http://mbooth.fedorapeople.org/reviews/eclipse-collabnet-merge-1.10.0-1.fc12.src.rpm Description: The CollabNet Merge Client has been built on top of Eclipse and Subclipse. This combination allowed us to support multiple client operating systems and also allowed us to focus on the actual merge client and merge process while leveraging the excellent Subversion capabilities that already exist in Subclipse. This gives you a powerful client that allows you to perform all Subversion operations from a single tool. Commit, History, Blame, Switch, Tagging. Everything you need is available. You do not have to be an Eclipse shop or even an Eclipse developer to use the client. Eclipse and Subclipse make it easy to checkout and access any project in your repository. You can just use the client as a general Subversion UI, or even just to perform merges. Adopting the client does not require that you adopt Eclipse as your only development tool.
I'll take this one.
Mat, I'll wait for 2.0 before reviewing (http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1043&dsMessageId=2444916)
Hi Alex, 2.0.0 requires Subclipse 1.6.6, which is not available in F12, which is why I submitted version 1.10.0. I was going to update the package to 2.0.0 for Rawhide only after importing, but I can include a 2.0.0 package in this review as well, if you don't mind reviewing two versions. I am out of the country until Wednesday, so I will upload a 2.0.0 package on Thursday. Thanks, Mat
OK, I'll reveiw this one.
Review: OK: rpmlint must be run on every package. No warnings/errors. OK: The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. Shell script for generating the tarball is provided. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK: All build dependencies must be listed in BuildRequires OK: Packages must NOT bundle copies of system libraries. OK: A package must own all directories that it creates. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. OK: If a package includes something as %doc, it must not affect the runtime of the application. OK: Packages must not own files or directories already owned by other packages. OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK: All filenames in rpm packages must be valid UTF-8. Mat, FYI in packages like this where there is only one feature there is no need to specify the feature to build. %{eclipse_base}/buildscripts/pdebuild -d "subclipse svnkit" is just enough to build Package is APPROVED.
(In reply to comment #5) > Mat, FYI in packages like this where there is only one feature there is no need > to specify the feature to build. > %{eclipse_base}/buildscripts/pdebuild -d "subclipse svnkit" is just enough to > build > Thanks for the tip, I didn't realise. > Package is APPROVED. Thanks Alex. New Package CVS Request ======================= Package Name: eclipse-collabnet-merge Short Description: CollabNet Merge Client for Subclipse Owners: mbooth Branches: F-12
CVS done (by process-cvs-requests.py).
For interest, the differences between the 1.10.0 package and the 2.0.0 package are extremely minor: --- F-12/eclipse-collabnet-merge.spec 2010-02-11 11:28:48.277846958 +0000 +++ devel/eclipse-collabnet-merge.spec 2010-02-11 11:44:58.976480111 +0000 @@ -2,7 +2,7 @@ %global eclipse_dropin %{_datadir}/eclipse/dropins Name: eclipse-collabnet-merge -Version: 1.10.0 +Version: 2.0.0 Release: 1%{?dist} Summary: CollabNet Merge Client for Subclipse Group: Development/Tools @@ -22,11 +22,11 @@ BuildRequires: java-devel BuildRequires: jpackage-utils BuildRequires: eclipse-pde >= 1:3.5.0 -BuildRequires: eclipse-subclipse >= 1.6.5 +BuildRequires: eclipse-subclipse >= 1.6.6 Requires: java Requires: jpackage-utils Requires: eclipse-platform >= 1:3.5.0 -Requires: eclipse-subclipse >= 1.6.5 +Requires: eclipse-subclipse >= 1.6.6 %description The CollabNet Merge Client has been built on top of Eclipse and Subclipse. @@ -76,5 +76,8 @@ %doc com.collabnet.subversion.merge.feature/license.html %changelog +* Sun Feb 11 2010 Mat Booth <fedora.uk> 2.0.0-1 +- Update to version 2.0.0 for Subclipse 1.6.6. + * Sun Nov 15 2009 Mat Booth <fedora.uk> 1.10.0-1 - Initial revision of CollabNet Merge Client package
Built successfully for all requested branches. Closing.