Description of problem: Update bnx2 fw to match the latest upstream firmware. Version-Release number of selected component (if applicable): 2.0.2 Due to the conversion to use request_firmware() in the latest upstream driver, the latest firmware in the new ihex format did not get backported to the old bnx2x_fw.h format used in RHEL5.5. The latest firmware has the following changes: commit 078b0735881c7969aaf21469f3577831cddd9f8c Author: Michael Chan <mchan> Date: Sat Aug 29 00:02:46 2009 -0700 bnx2: Update firmware to 5.0.0.j3. - Better small packet receive performance. - Better handling of Flow control on 5709. - Fixed iSCSI TMP ABORT TASK problem. - Added iSCSI TCP timestamp option.
Created attachment 388673 [details] patch to backport 5.0.0.j3 firmware.
Michael - can you assist Gideon in bug 560556? We haven't heard from that side for bnx2x firmware.
I applied the patch, built it in our build system, and sanity tested it our test system. The rpm can be found at: http://people.redhat.com/jfeeney/.bz561578 Testing feedback would be appreciated.
Our automated lab found some problems on iSCSI because I forgot the patch below. We'll provide the backported patch once we finish some more testing. Thanks. commit d0549382da9997834ce65e489d9dbdc4b4693a2b Author: Michael Chan <mchan> Date: Wed Oct 28 03:41:59 2009 -0700 cnic: Fix L2CTX_STATUSB_NUM offset in context memory. The BNX2_L2CTX_STATUSB_NUM definition needs to be changed to match the recent firmware update: commit 078b0735881c7969aaf21469f3577831cddd9f8c bnx2: Update firmware to 5.0.0.j3. Without the fix, bnx2 can crash intermittently in bnx2_rx_int() when iSCSI is enabled.
Created attachment 390305 [details] additional patch to match cnic to the new firmware This patch depends on bug 517378. With this patch, it has passed our iSCSI automated tests.
I applied the patches and provided a rpm on my people page. See http://people.redhat.com/jfeeney/.rhel5-bnx2/ Please let me know if there is anything else needed. Testing feedback would be appreciated. Thanks.
Broadcom - do you have any test results on this ASAP?
Since cnic is being updated by patch provided in comment #9, I added Mike Christie to cc list. Just to avoid a total blindside.
Yeah, I'm thinking this one cnic patch needs to be in a separate bugzilla. What do yall think?
There is a bug report on netdev that we suspect may be caused by firmware: http://marc.info/?t=126601244400001&r=1&w=2 We are still debugging this, but it's likely that we'll need newer firmware. Because we cannot yet reproduce the problem, we need the user to help us confirm the issue and verify it. I suspect this will take a few days to resolve.
Michael, Red Hat is ON HOLD with submitting this firmware this until your bug report is resolved.
Michael, any news/updates on the dubugging issues with Comment #15?
Created attachment 395862 [details] New firmware patch I'm attaching the newer upstream firmware (backported to RHEL5.5) that Brian Haley@HP and Broadcom are testing. This firmware fixes a theoretical context corruption problem that closely matches what Brian reported. I think this problem is very rare and we've never encountered it in our lab. It is also difficult for Brian to reproduce the failure. I recommend that we go with the newer firmware, even if we are unable to confirm the fix. Thanks.
Michael, is this going to go upstream anytime soon.
I see that most of the firmware changes in this patch come from: commit bec92044b73085ba92aabf973cb5aafc251f3a34 Author: Michael Chan <mchan> Date: Tue Feb 16 15:19:42 2010 -0800 bnx2: Update firmwares and update version to 2.0.8. - Increase FTQ depth to 256 to ehnabce performance. - Fix RV2P context corruption on 5709 when flow control is enabled. and commit 57579f7629a3d46c307405fbd2ea6bdb650d692f Author: Michael Chan <mchan> Date: Sat Apr 4 16:51:14 2009 -0700 bnx2: Use request_firmware() for a few bits like 'rv2p_fw_fixup' to handle the firmware properly.
I'm going to submit the patch in comment #18 for RHEL5.5. Please confirm no additional bits are needed for bnx2 for RHEL5.5.
That's right. It already went upstream. This is the backported version to RHEL5.5 which is not using request_firmware().
(In reply to comment #21) > I'm going to submit the patch in comment #18 for RHEL5.5. Please confirm no > additional bits are needed for bnx2 for RHEL5.5. This should be the final firmware change for RHEL5.5. We are still testing the other bnx2 patch for the bonding/vlan/cnic issue. Looks like that one has been deferred to RHEL5.6.
OK, so I'm finally catching up and am submitting the patch in comment #18 and the patch in comment #9.
Created attachment 396382 [details] rhel5-bnx2-firmware-upgrade-post.patch This is the exact patch I am posting for inclusion in RHEL5.5.
Sorry for the confusion, Michael, but I wanted to make sure it was appropriate to include the backported version of this patch from comment #9: commit d0549382da9997834ce65e489d9dbdc4b4693a2b Author: Michael Chan <mchan> Date: Wed Oct 28 03:41:59 2009 -0700 cnic: Fix L2CTX_STATUSB_NUM offset in context memory.
Yes, we need the patch in comment #9. Thanks.
in kernel-2.6.18-191.el5 You can download this test kernel from http://people.redhat.com/jwilson/el5 Please update the appropriate value in the Verified field (cf_verified) to indicate this fix has been successfully verified. Include a comment with verification details.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2010-0178.html