Bug 562374 - Review Request: perl-MooseX-Role-WithOverloading - Roles which support overloading
Summary: Review Request: perl-MooseX-Role-WithOverloading - Roles which support overlo...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Iain Arnell
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/MooseX-Ro...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-06 09:09 UTC by Chris Weyl
Modified: 2010-08-27 19:07 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-20 23:12:03 UTC
Type: ---
Embargoed:
iarnell: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2010-02-06 09:09:21 UTC
Spec URL: http://fedorapeople.org/~cweyl/review/perl-MooseX-Role-WithOverloading.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-MooseX-Role-WithOverloading-0.05-1.fc11.src.rpm

Description:
MooseX::Role::WithOverloading allows you to write a Moose::Role
that defines overloaded operators and allows those operator
overloadings to be composed into the classes/roles/instances it's
compiled to, while plain roles would lose the overloading.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1966187

Additional Comment:

This is a new prereq of the latest Catalyst::Runtime.

*rt-0.10_01

Comment 1 Iain Arnell 2010-02-20 12:14:27 UTC
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2001212

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarball matches upstream
a1084e98f8deaef75cdfc3fecc59a149  MooseX-Role-WithOverloading-0.05.tar.gz

Final provides are sane
perl(MooseX::Role::WithOverloading) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application::Composite) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application::Composite::ToClass) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application::Composite::ToInstance) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application::Composite::ToRole) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application::FixOverloadedRefs) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application::ToClass) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application::ToInstance) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application::ToRole) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Composite) = 0.05
perl-MooseX-Role-WithOverloading = 0.05-1.fc14
perl-MooseX-Role-WithOverloading(x86-64) = 0.05-1.fc14

Final requires are sane
perl(:MODULE_COMPAT_5.10.1)  
libc.so.6()(64bit)  
libc.so.6(GLIBC_2.2.5)(64bit)  
perl(aliased)  
perl(Moose)  
perl(Moose::Exporter)  
perl(Moose::Role)  
perl(Moose::Util::MetaRole)  
perl(MooseX::Types::Moose)  
perl(namespace::autoclean)  
perl(namespace::clean)  
perl(overload)  
perl(XSLoader)  

rpmlint only has pointless complaints
perl-MooseX-Role-WithOverloading.src: W: spelling-error %description -l en_US overloadings -> overloading, overloading s, overloads
perl-MooseX-Role-WithOverloading.x86_64: W: spelling-error %description -l en_US overloadings -> overloading, overloading s, overloads
perl-MooseX-Role-WithOverloading-debuginfo.x86_64: E: description-line-too-long C This package provides debug information for package perl-MooseX-Role-WithOverloading.

You might want to enable the two "release candidate" tests if they pass.

APPROVED.

Comment 2 Chris Weyl 2010-02-20 20:45:20 UTC
New Package CVS Request
=======================
Package Name: perl-MooseX-Role-WithOverloading
Short Description: Roles which support overloading
Owners: cweyl
Branches: F-11 F-12 F-13 devel
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2010-02-20 22:24:23 UTC
CVS done (by process-cvs-requests.py).

Comment 4 Chris Weyl 2010-02-20 23:12:03 UTC
Thanks for the review! :-)

Comment 5 Iain Arnell 2010-08-26 05:44:51 UTC
Package Change Request
======================
Package Name: perl-MooseX-Role-WithOverloading
New Branches: el6
Owners: iarnell tremble
InitialCC: perl-sig

Comment 6 Kevin Fenzi 2010-08-27 19:07:04 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.