Spec URL: http://jkeating.fedorapeople.org/review/GitPython.spec SRPM URL: http://jkeating.fedorapeople.org/review/GitPython-0.1.6-1.fc12.src.rpm Description: GitPython is a python library used to interact with Git repositories. GitPython provides object model access to your git repository. Once you have created a repository object, you can traverse it to find parent commit(s), trees, blobs, etc. GitPython is a port of the grit library in Ruby created by Tom Preston-Werner and Chris Wanstrath.
Please use version macro in source url. A more explicit files section don't hurt.
Review coming up soon.
rpmlint is clean, source tarball has correct check sum, no licenses issues. noarch is correct, own dirs as it should, perms are good. it builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1969293 However, there are some minor things to fix, all of which I have created a patch for: - Add python-setuptools to buildreq - Explicit file list - Use version macro in source url The only issue I see is the name, would python-git be a better package name?
Created attachment 389585 [details] Patch to build in koji
Jesse, what is this programm for? dist-git? (Just want to know, what work needs to be done, to switch to python3 sometime. This does not build for python3 even after 2to3 running on it :( )
(In reply to comment #5) > This does not build for python3 even after 2to3 running on it :( ) Is that a surprise? Tried to port a internal script (~1000 lines), it was a lot of work, and 2to3 did not help that much.
This is for dist-git yes. Hrm, this builds in koji fine, why does it need python-setuptools as a BuildRequirement ? I used GitPython as that is the upstream project name. That seems to fall under the naming guidelines for python http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29 since GitPython has Py in the name. I'll look at the other issues and re-post.
Spec URL: http://jkeating.fedorapeople.org/review/GitPython.spec SRPM URL: http://jkeating.fedorapeople.org/review/GitPython-0.1.6-2.fc12.src.rpm Updated with suggested changes.
setuptools is needed in setup.py and python-devel don't bring that to the table. Name is according to guide lines so we are finished. The package GitPython is APPROVED.
New Package CVS Request ======================= Package Name: GitPython Short Description: GitPython is a python library used to interact with Git repositories. Owners: jkeating Branches: F-12 F-11 EL-5 InitialCC:
CVS done (by process-cvs-requests.py).
Jesse, could you please import and close?
Sorry, I've been busy with the no frozen rawhide stuff. I hope to get to this maybe tonight or tomorrow.