Bug 563563

reassigning to the right component "glibc":
the bug is about file "sysdeps/powerpc/dl-procinfo.c" in the "glibc" package,
not about the "procinfo" package

------- Comment From brutman.com 2010-04-05 11:28 EDT-------
The git commit number in the head for this is:

1642331d3066e43daea5a33a6c12db6edf0e34f7

We expect the patch to apply cleanly ..  please give it a shot and let me know
if there are any problems.

IBM is signed up to test and provide feedback.

This enhancement request was evaluated by the full Red Hat Enterprise Linux 
team for inclusion in a Red Hat Enterprise Linux minor release.   As a 
result of this evaluation, Red Hat has tentatively approved inclusion of 
this feature in the next Red Hat Enterprise Linux Update minor release.   
While it is a goal to include this enhancement in the next minor release 
of Red Hat Enterprise Linux, the enhancement is not yet committed for 
inclusion in the next minor release pending the next phase of actual 
code integration and successful Red Hat and partner testing.

------- Comment From rsa.com 2010-07-30 14:04 EDT-------
In order for the GLIBC patches to perform their function there needs to be an accompanying kernel backport which will export the AT_PLATFORM and AT_BASE_PLATFORM values to the Aux Vector.

Created attachment 440552 [details]
Adds AT_BASE_PLATFORM value to the Aux Vector and power7 support.


------- Comment on attachment From alexkard.com 2010-08-23 23:42 EDT-------


The original patch to the upstream kernel is  1642331d3066e43daea5a33a6c12db6edf0e34f7

The patched kernel prints this:

[root@blade312-5 ~]# LD_SHOW_AUXV=1 /bin/true
AT_DCACHEBSIZE:  0x80
AT_ICACHEBSIZE:  0x80
AT_UCACHEBSIZE:  0x0
AT_SYSINFO_EHDR: 0x100000
AT_HWCAP:        dfp arch_2_05 ic_snoop smt mmu fpu altivec ppc64 ppc32
AT_PAGESZ:       65536
AT_CLKTCK:       100
AT_PHDR:         0x10000034
AT_PHENT:        32
AT_PHNUM:        9
AT_BASE:         0x0
AT_FLAGS:        0x0
AT_ENTRY:        0x10000970
AT_UID:          0
AT_EUID:         0
AT_GID:          0
AT_EGID:         0
AT_SECURE:       0
AT_PLATFORM:     power6
AT_??? (0x18): 0xff96fbec
[root@blade312-5 ~]# uname -a
Linux blade312-5.ozlabs.ibm.com 2.6.18-prep #3 SMP Tue Aug 17 16:07:25 EST 2010 ppc64 ppc64 ppc64 GNU/Linux

~~ Attention Customers and Partners - RHEL 5.6 Public Beta is now available on RHN ~~

A fix for this 'OtherQA' BZ should be present and testable in the release. 

If this Bugzilla is verified as resolved, please update the Verified field above with an appropriate value and include a summary of the testing executed and the results obtained.

If you encounter any issues or have questions while testing, please describe them and set this bug into NEED_INFO. 

If you encounter new defects or have additional patches to request for inclusion, promptly escalate the new issues through your support representative.

Finally, future Beta kernels can be found here:
 http://people.redhat.com/jwilson/el5/

Note: Bugs with the 'OtherQA' keyword require Third-Party testing to confirm the request has been properly addressed. See: https://bugzilla.redhat.com/describekeywords.cgi#OtherQA ).

------- Comment From rsa.com 2010-11-10 15:56 EDT-------
Per the description in redhat bugzill 563599, we're waiting on the kernel patch in this bugzilla to be added such that power7 can be exported as a platform target.

------- Comment From sbest.com 2010-11-10 16:12 EDT-------
so is there a bz open to get the kernel patch in? if so, what is the bz #? if no, please open a bz to get the kernel patch in.

moving over to kernel, this isn't glibc issue

Steve, 

I believe this bugzilla is for the glibc piece of the feature, as mentioned in initial comment. The new glibc contains patch for this bug and glibc errata links to this bug. If something is needed for kernel, I think new bz should be open for that. I'm returning this bz to glibc.

(In reply to comment #14)
> Steve, 
> 
> I believe this bugzilla is for the glibc piece of the feature, as mentioned in
> initial comment. The new glibc contains patch for this bug and glibc errata
> links to this bug. If something is needed for kernel, I think new bz should be
> open for that. I'm returning this bz to glibc.

Petr,

I don't understand how the patch attached is related to glibc. It is a kernel patch snippet of the patch is below

diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputable.c
index 179ea44..cc8e09e 100644
--- a/arch/powerpc/kernel/cputable.c
+++ b/arch/powerpc/kernel/cputable.c
@@ -22,6 +22,8 @@
 
 struct cpu_spec* cur_cpu_spec = NULL;
 EXPORT_SYMBOL(cur_cpu_spec);
+/* The platform string corresponding to the real PVR */
+const char *powerpc_base_platform;

did the glibc team use this bz by mistake and commit another fix under this bz?

(In reply to comment #15)
> (In reply to comment #14)
> > Steve, 
> > 
> > I believe this bugzilla is for the glibc piece of the feature, as mentioned in
> > initial comment. The new glibc contains patch for this bug and glibc errata
> > links to this bug. If something is needed for kernel, I think new bz should be
> > open for that. I'm returning this bz to glibc.
> 
> Petr,
> 
> I don't understand how the patch attached is related to glibc. It is a kernel
> patch snippet of the patch is below
(...)
> did the glibc team use this bz by mistake and commit another fix under this bz?

Seems more like someone mistakenly attached a kernel patch to glibc bugzilla. See the first comments: the initial comment asks for including change to sysdeps/powerpc/dl-procinfo.c (=glibc) and was filed mistakenly to procinfo, which was reassigned to glibc by Dan Novotny in comment 1. It was then dev and qe acked for glibc, not for kernel. Kernel starts to be mentioned in IBM proxy comments 6 and 7, and a patch is attached (this is probably the place where new kernel bz should have been filed). 

New glibc indeed carries a patch for sysdeps/powerpc/dl-procinfo.c, so this bugzilla is perfectly valid for glibc. I believe the kernel patch is the black passenger here.

(In reply to comment #16)
> (In reply to comment #15)
> > (In reply to comment #14)
> > > Steve, 
> > > 
> > > I believe this bugzilla is for the glibc piece of the feature, as mentioned in
> > > initial comment. The new glibc contains patch for this bug and glibc errata
> > > links to this bug. If something is needed for kernel, I think new bz should be
> > > open for that. I'm returning this bz to glibc.
> > 
> > Petr,
> > 
> > I don't understand how the patch attached is related to glibc. It is a kernel
> > patch snippet of the patch is below
> (...)
> > did the glibc team use this bz by mistake and commit another fix under this bz?
> 
> Seems more like someone mistakenly attached a kernel patch to glibc bugzilla.
> See the first comments: the initial comment asks for including change to
> sysdeps/powerpc/dl-procinfo.c (=glibc) and was filed mistakenly to procinfo,
> which was reassigned to glibc by Dan Novotny in comment 1. It was then dev and
> qe acked for glibc, not for kernel. Kernel starts to be mentioned in IBM proxy
> comments 6 and 7, and a patch is attached (this is probably the place where new
> kernel bz should have been filed). 
> 
> New glibc indeed carries a patch for sysdeps/powerpc/dl-procinfo.c, so this
> bugzilla is perfectly valid for glibc. I believe the kernel patch is the black
> passenger here.

the glibc fix I believe went in under 563599. It is still unclear what fix when in under this bz? anyone know?

(In reply to comment #17)

> the glibc fix I believe went in under 563599. It is still unclear what fix when
> in under this bz? anyone know?

5.7 candidate glibc contains this:

glibc-rh563563.patch:
2008-08-01  Steven Munroe  <sjmunroe.com>
            Carlos Eduardo Seo  <cseo.ibm.com>

        [BZ #6817]
        * sysdeps/powerpc/dl-procinfo.c (_dl_powerpc_cap_flags):
        Added the members 'vsx' and 'arch_2_06'.
        (_dl_powerpc_platforms): Add the member 'power7'.
        * sysdeps/powerpc/dl-procinfo.h: Modify _DL_HWCAP_FIRST
        to reflect the changes required by VSX and ISA 2.06.
        Modify _DL_PLATFORMS_COUNT to reflect the addition of
        'power7'.
        Defined PPC_PLATFORM_POWER7.
        (_dl_string_platform): Add support for POWER7.
        * sysdeps/powerpc/sysdep.h: Define bit masks for VSX
        capability and ISA 2.06.


glibc-563599.patch:
2009-03-11  Carlos Eduardo Seo  <cseo.ibm.com>

        * elf/dl-sysdep.c (_dl_show_auxv): Add support for AT_BASE_PLATFORM.

2009-03-14  Ulrich Drepper  <drepper>

        * elf/dl-sysdep.c (auxvars): Compress data structure

a new bz was open to get the kernel patch in. the bz is 652279

This enhancement request was evaluated by the full Red Hat Enterprise Linux 
team for inclusion in a Red Hat Enterprise Linux minor release.   As a 
result of this evaluation, Red Hat has tentatively approved inclusion of 
this feature in the next Red Hat Enterprise Linux Update minor release.   
While it is a goal to include this enhancement in the next minor release 
of Red Hat Enterprise Linux, the enhancement is not yet committed for 
inclusion in the next minor release pending the next phase of actual 
code integration and successful Red Hat and partner testing.

This enhancement request was evaluated by the full Red Hat Enterprise Linux 
team for inclusion in a Red Hat Enterprise Linux minor release.   As a 
result of this evaluation, Red Hat has tentatively approved inclusion of 
this feature in the next Red Hat Enterprise Linux Update minor release.   
While it is a goal to include this enhancement in the next minor release 
of Red Hat Enterprise Linux, the enhancement is not yet committed for 
inclusion in the next minor release pending the next phase of actual 
code integration and successful Red Hat and partner testing.

------- Comment From rsa.com 2010-11-30 10:27 EDT-------
The kernel side of this fix was provided in https://bugzilla.linux.ibm.com/show_bug.cgi?id=68245 (Red Hat Bugzilla  	652279)

[root@ltcgranola4p03 ~]# uname -a
Linux ltcgranola4p03.ltc.austin.ibm.com 2.6.18-233.el5 #1 SMP Mon Nov 22
17:46:54 EST 2010 ppc64 ppc64 ppc64 GNU/Linux
[root@ltcgranola4p03 ~]# LD_SHOW_AUXV=1 /bin/true
AT_DCACHEBSIZE:  0x80
AT_ICACHEBSIZE:  0x80
AT_UCACHEBSIZE:  0x0
AT_SYSINFO_EHDR: 0x100000
AT_HWCAP:        dfp arch_2_05 ic_snoop smt mmu fpu altivec ppc64 ppc32
AT_PAGESZ:       65536
AT_CLKTCK:       100
AT_PHDR:         0x10000034
AT_PHENT:        32
AT_PHNUM:        8
AT_BASE:         0xf7fa0000
AT_FLAGS:        0x0
AT_ENTRY:        0x10000970
AT_UID:          0
AT_EUID:         0
AT_GID:          0
AT_EGID:         0
AT_SECURE:       0
AT_PLATFORM:     power6
AT_BASE_PLATFORM:power7

I installed the test kernel provided in Red Hat Bugzilla 652279 on a RHEL5.6 snap2 system and verified that the fix is present on a Power7 system.

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Support for POWER7 and Power ISA v.2.06 architectures has been added.

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0109.html