Bug 564145 - [Emulex 5.5 bug] Fix scsi eh callouts and add support for new chip to be2iscsi driver
Summary: [Emulex 5.5 bug] Fix scsi eh callouts and add support for new chip to be2iscs...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.5
Hardware: All
OS: Linux
high
high
Target Milestone: rc
: 5.5
Assignee: Mike Christie
QA Contact: Red Hat Kernel QE team
URL:
Whiteboard:
Depends On:
Blocks: 533941 564148 564510
TreeView+ depends on / blocked
 
Reported: 2010-02-11 22:25 UTC by Mike Christie
Modified: 2010-03-30 07:21 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 564148 (view as bug list)
Environment:
Last Closed: 2010-03-30 07:21:42 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
patch for RHEL5.5 Kernel (17.49 KB, patch)
2010-02-18 16:25 UTC, jayamohank
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2010:0178 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.5 kernel security and bug fix update 2010-03-29 12:18:21 UTC

Description Mike Christie 2010-02-11 22:25:30 UTC
Description of problem:

The be2iscsi scsi eh callouts are busted:
- Sleeps with a spin lock in abort path
- Does not invalidate cmds in chip when doing lun and target reset

The ServerEngines guys also want to bring in support for their newer chip.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Mike Christie 2010-02-11 22:29:35 UTC
This is a new driver to 5.5 so it cannot add a regression. Also ServerEngines is doing all the testing/QE, so it will not invalidate any work that has been done already.

Comment 2 RHEL Program Management 2010-02-11 22:59:11 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 7 Andrius Benokraitis 2010-02-17 18:34:30 UTC
Mike, who from ServerEngines are you working with? Can you add them to this bugzilla?

Comment 8 Mike Christie 2010-02-17 20:59:46 UTC
Adding ServerEngines engineer who is sending patches.

Comment 9 Andrius Benokraitis 2010-02-18 15:31:40 UTC
Jay @ SE: When should we expect these patches?

Comment 10 jayamohank 2010-02-18 16:25:13 UTC
Created attachment 394942 [details]
patch for RHEL5.5 Kernel

The be2iscsi patch for RHEL5.5 kernel

Comment 11 Andrius Benokraitis 2010-02-18 16:31:38 UTC
Thanks Jay - I'm assuming this is upstream as well?

Comment 12 Mike Christie 2010-02-18 18:00:18 UTC
Andrius, it was just sent upstream. I reviewed it there. There was a tiny issue with a patch that is not needed for rhel5.5, so I think this is ok. I am going to send this to rh-kernel now.

Comment 17 Jarod Wilson 2010-02-23 20:06:13 UTC
in kernel-2.6.18-190.el5
You can download this test kernel from http://people.redhat.com/jwilson/el5

Please update the appropriate value in the Verified field
(cf_verified) to indicate this fix has been successfully
verified. Include a comment with verification details.

Comment 20 jayamohank 2010-03-08 22:36:47 UTC
The test team at serverengines has run the following tests on this without
seeing any issues

Login with multiple targets/multiple luns

Block IO w data integrity

File IO w data intergrity

Target offline/online


We have various combinations like
Qeue depth of 1,16.128

Size 512b, 1k , 2k, 4k through 2MB in 512 blocks

For 72+ hours.

Comment 22 errata-xmlrpc 2010-03-30 07:21:42 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0178.html


Note You need to log in before you can comment on or make changes to this bug.