Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 564399

Summary: f71805f hwmon driver passes '&sio_data' to platform_device_add_data()
Product: Red Hat Enterprise Linux 5 Reporter: Dean Nelson <dnelson>
Component: kernelAssignee: Dean Nelson <dnelson>
Status: CLOSED ERRATA QA Contact: Red Hat Kernel QE team <kernel-qe>
Severity: medium Docs Contact:
Priority: low    
Version: 5.5CC: peterm, prarit, ykopkova
Target Milestone: rc   
Target Release: 5.6   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-03-30 07:41:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dean Nelson 2010-02-12 16:14:54 UTC 
Description of problem:
The f71805f hwmon kernel driver passes '&sio_data' as the second argument to platform_device_add_data(). This is wrong. It should be passing 'sio_data', without the '&'.

This problem was found by code inspection after determining the cause behind the problem reported by BZ 559950. There are two other BZs that also report problems caused by this very same issue (BZs 557172 and 560944).

The result of this issue is that when one does a modprobe of the driver the system experiences an "Unable to handle kernel paging request at ..." type panic. See the other three BZs for details.

I've not been able to find a system within Red Hat that has the necessary chip to run the f71805f driver on, so as to verify that it indeed panics like the other three drivers do. (This is not to say such a system doesn't exist.)


Version-Release number of selected component (if applicable):
(Assuming this driver is like the other three), kernel-2.6.18-185.el5


How reproducible:
(Assuming this driver is like the other three), always.


Steps to Reproduce:
(Assuming this driver is like the other three), 'modprobe f71805f'


Actual results:
(Assuming this driver is like the other three), system panic

Expected results:
No panic
Comment 1 Dean Nelson 2010-02-12 16:23:46 UTC 
To make the three other related BZs easily accessible from this BZ.

  bug 557172
  bug 559950
  bug 560944
Comment 5 RHEL Program Management 2010-02-18 00:54:27 UTC 
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 8 Jarod Wilson 2010-02-23 20:06:19 UTC 
in kernel-2.6.18-190.el5
You can download this test kernel from http://people.redhat.com/jwilson/el5

Please update the appropriate value in the Verified field
(cf_verified) to indicate this fix has been successfully
verified. Include a comment with verification details.
Comment 13 errata-xmlrpc 2010-03-30 07:41:42 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0178.html