Bug 564557 - Review Request: gfs-goschen-fonts - A 19th century Greek typeface
Summary: Review Request: gfs-goschen-fonts - A 19th century Greek typeface
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-13 10:27 UTC by Nicolas Mailhot
Modified: 2010-02-18 22:40 UTC (History)
4 users (show)

Fixed In Version: gfs-goschen-fonts-20100203-1.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-18 22:40:45 UTC
Type: ---
Embargoed:
bochecha: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)
repo-font-audit output for the package (4.35 KB, application/x-xz)
2010-02-13 10:34 UTC, Nicolas Mailhot
no flags Details

Description Nicolas Mailhot 2010-02-13 10:27:51 UTC

Comment 1 Nicolas Mailhot 2010-02-13 10:30:07 UTC
SRPM URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=1981773
Description:

Georg Joachim Göschen founded in 1782 the publishing house of G.J.
Göschensche Verlagsbuchhandlung in Leipzig and was one of the most active
publishers of the period in Germany. Göschen was very interested in
typography, influenced by the fame and quality of the editions of G. Bodoni
and F. Didot.

In 1797, he collaborated with the leading scholar of the period, Johann Jakob
Griesbach, to edit and publish the New Testament in Greek for which he formed
a committee of scholars to decide the new Greek type which were eventually
cut by Johann Prillwitz. The book appeared in 1803 and the types show many
influences from the Greek types of Bodoni. Their characteristic was the
neoclassical form of marked contrast between thick and thin strokes, the
cursive style and the large size of the font.

The design was too cumbersome to allow general use and can be considered
successful only for its indirect influence on the later cut Greek Leipzig
type. It is, however, part of the greater heritage of Greek type design and
therefore the type has been digitized by George D. Matthiopoulos in 2009 and
is part of GFS' type library under the name GFS Göschen cursive, in
commemoration of the great German publisher.

http://fedoraproject.org/wiki/GFS_G%C3%B6schen_fonts

Comment 2 Nicolas Mailhot 2010-02-13 10:34:38 UTC
Created attachment 390627 [details]
repo-font-audit output for the package

Comment 3 Nicolas Mailhot 2010-02-13 10:45:58 UTC
Since koji garbage-collects after a while:

http://nim.fedorapeople.org/gfs-goschen-fonts-20100203-1.fc13.src.rpm

Comment 4 Mathieu Bridon 2010-02-13 11:19:31 UTC
+:ok, =:needs attention, -:needs fixing

MUST Items:
[+] MUST: rpmlint must be run on every package.
$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/gfs-goschen-fonts-20100203-1.fc13.*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint SPECS/gfs-goschen-fonts.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
  => OFL

[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
$ sha1sum SOURCES/GFS_GOSCHEN.zip 
4a9f048bd0016d8b0df49c63848c14686f48fc6a  SOURCES/GFS_GOSCHEN.zip

[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[+] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.
  => not applicable

[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissible content. This is
described in detail in the code vs. content section of Packaging Guidelines.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
  => not applicable

[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
  => package was built in Koji and is noarch anyway



Package is APPROVED

Comment 5 Mathieu Bridon 2010-02-13 11:21:08 UTC
Oops... Forgot the review-flag

Comment 6 Nicolas Mailhot 2010-02-13 16:27:37 UTC
Thanks for the review!

New Package CVS Request
=======================
Package Name: gfs-goschen-fonts
Short Description: A 19th century Greek typeface
Owners: nim
Branches: devel
InitialCC: fonts-sig

Comment 7 Kevin Fenzi 2010-02-16 03:54:19 UTC
CVS done (by process-cvs-requests.py).

(Remember to assign the review to the reviewer)

Comment 8 Fedora Update System 2010-02-17 06:58:14 UTC
gfs-goschen-fonts-20100203-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/gfs-goschen-fonts-20100203-1.fc13

Comment 9 Fedora Update System 2010-02-18 22:40:40 UTC
gfs-goschen-fonts-20100203-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.