Bug 564588 - Review Request: callgit - A tool for Ham Radio Operators to look up callsigns on the web
Summary: Review Request: callgit - A tool for Ham Radio Operators to look up callsign...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-13 15:09 UTC by Jens Maucher
Modified: 2010-03-03 15:43 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-03 15:43:02 UTC
Type: ---
Embargoed:
mtasaka: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Jens Maucher 2010-02-13 15:09:41 UTC
Spec URL: http://jensm.fedorapeople.org/callgit.spec
SRPM URL: http://jensm.fedorapeople.org/callgit-2.0-1.fc13.src.rpm
Description: 
This progam allows you to search for another Ham's name and address
without having a web browser up. It is very simple.

rpmlint:
rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/callgit-2.0-1.fc13.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jens Maucher 2010-02-13 15:11:36 UTC
This is my first self-made package.
I need a sponsor.

Comment 2 Mamoru TASAKA 2010-02-19 16:48:24 UTC
Some notes:

* Requires
  - "Requires: qt" is not needed. Dependency for qt is
    automatically detected by rpmbuild as rpmbuild checks
    library related dependency:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Requires

* Desktop
  - As this seems to be a GUI application, you have to install
    proper desktop file.
    https://fedoraproject.org/wiki/Packaging/Guidelines

! Miscs
------------------------------------------------------------
callgit.i686: W: spelling-error %description -l en_US progam -> program, progeny, progress
------------------------------------------------------------
  - I guess here "program" is correct.

Comment 3 Jens Maucher 2010-02-19 18:50:58 UTC
Fixed.

Spec-URL: see above 
SRPM-URL: http://jensm.fedorapeople.org/callgit-2.0-2.fc12.src.rpm

koji-build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2000015

Comment 4 Mamoru TASAKA 2010-02-20 15:44:45 UTC
One issue
- "Application;" category in callgit.desktop is redundant and
  should be removed.

Comment 5 Jens Maucher 2010-02-20 16:17:52 UTC
Why redundant?

You mean this were correct?
Categories=Network;

Comment 6 Jens Maucher 2010-02-20 16:22:33 UTC
Ok, i modified callgit.desktop, and uploaded the new callgit srpm.

Link is the same as in comment 7.

Comment 7 Mamoru TASAKA 2010-02-20 16:27:24 UTC
Please change the release, even if only small changes are added,
to avoid confusion.

Comment 8 Jens Maucher 2010-02-20 16:48:24 UTC
Oups, i forgot, sorry.
Done.

Spec-URL: see above 
SRPM-URL: http://jensm.fedorapeople.org/callgit-2.0-3.fc12.src.rpm

Comment 9 Mamoru TASAKA 2010-02-20 20:39:39 UTC
Please fix %changelog entry (now release is 3)

----------------------------------------------------------------
    This package (callgit) is APPROVED by mtasaka
----------------------------------------------------------------

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from "Install the Client Tools (Koji)".

Now I am sponsoring you.

If you want to import this package into Fedora 11/12/13, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

Removing NEEDSPONSOR.

Note:
- If you cannot set fedora-cvs flag on this bug to ?, try re-logining
  to this RedHat bugzilla with the email registered on Fedora Account
  System.

Comment 10 Jens Maucher 2010-02-20 21:06:09 UTC
I did, but i can't set the cvs-flag to ?.

Comment 11 Jason Tibbitts 2010-02-20 21:13:29 UTC
It may take an hour or so before your elevated permissions propagate to bugzilla.

Comment 12 Jens Maucher 2010-02-20 22:00:50 UTC
Now it works, and switched to ?.

Comment 13 Jason Tibbitts 2010-02-20 22:25:28 UTC
The fedora-cvs flag is set, but I can find no CVS request to process.

Comment 14 Mamoru TASAKA 2010-02-21 07:18:50 UTC
Jens, please follow
http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure
and write CVS admin request here. Current valid branches are
F-11/12/13 EL-4/5 (I don't know about OLPC well). devel branch
is implicitly added.

After CVS admins set fedora-cvs flag to +, please follow
http://fedoraproject.org/wiki/PackageMaintainers/Join
again as I wrote in comment 9.

Comment 15 Mamoru TASAKA 2010-02-21 07:25:12 UTC
When you write CVS admin request here, please set fedora-cvs flag
to ? again.

Comment 16 Jens Maucher 2010-02-21 10:11:45 UTC
New Package CVS Request
=======================
Package Name: callgit
Short Description: Tool for Ham Radio Operators to look up call-signs on the web
Owners: jensm
Branches: F-13
InitialCC:

Comment 17 Jens Maucher 2010-02-21 15:00:43 UTC
New Package CVS Request
=======================
Package Name: callgit
Short Description: Tool for Ham Radio Operators to look up call-signs on the
web
Owners: jensm
Branches: F-12 F-13
InitialCC: 


//added F-12 to branches

Comment 18 Christoph Wickert 2010-02-21 17:01:56 UTC
(In reply to comment #14)
> Current valid branches are
> F-11/12/13 EL-4/5 (I don't know about OLPC well).

The OLPC branch is no longer in use, we use stock Fedora packages now.

Comment 19 Jason Tibbitts 2010-02-22 21:27:45 UTC
CVS done (by process-cvs-requests.py).

Comment 20 Mamoru TASAKA 2010-03-03 15:43:02 UTC
Please move F-13 callgit to stable (as F-12 callgit was moved to
stable). Closing.


Note You need to log in before you can comment on or make changes to this bug.