Bug 565300 - Review Request: papercut - A command line Rock, Paper, Scissors game
Summary: Review Request: papercut - A command line Rock, Paper, Scissors game
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dominic Hopf
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-14 14:48 UTC by Damien Durand
Modified: 2010-09-14 10:56 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-09-14 10:56:54 UTC
Type: ---
Embargoed:
dmaphy: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Damien Durand 2010-02-14 14:48:51 UTC
Spec URL: http://fedorapeople.org/~splinux/papercut/papercut.spec
SRPM URL: http://fedorapeople.org/~splinux/papercut/papercut-0.1.1-1.fc12.src.rpm

Description: papercut is command line based Rock, Paper, Scissors game for Unix based operating systems like Linux, BSD etc. User can play the game by entering
 users choice that is either, Rock (R or r), Paper (P or p), Scissors (S or s).
papercut also stores user statics. i.e. number of wins, losses and draws.

Comment 1 Dominic Hopf 2010-02-14 19:49:58 UTC
$ rpmlint papercut.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint papercut-0.1.1-1.fc12.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint papercut-0.1.1-1.fc12.x86_64.rpm papercut-debuginfo-0.1.1-1.fc12.x86_64.rpm
papercut-debuginfo.x86_64: E: debuginfo-without-source

The debuginfo-without-source issue can be ignored.


Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines
 [x] Specfile name matches %{name}.spec
 [x] Package seems to meet Packaging Guidelines
 [x] Package successfully compiles and builds into binary RPMs on at least one
     supported architecture.
     Tested on: Fedora 12/x86_64
 [x] Rpmlint output:
     source RPM: empty
     binary RPM: see above
 [x] Package is not relocatable.
 [x] License in specfile matches actual License and meets Licensing Guidelines
     License: GPLv3+
 [x] License file is included in %doc.
 [x] Specfile is legible and written in AE
 [x] Sourcefile in the Package is the same as provided in the mentioned Source
     SHA1SUM of Source: ba5bf3e999e84afdcf841376c25598786937f640
 [x] Package compiles successfully
 [x] All build dependencies are listed in BuildRequires
 [-] Specfile handles locales properly
 [-] ldconfig called in %post and %postun if required
 [-] Package owns directorys it creates
 [-] Package requires other packages for directories it uses.
 [x] Package does not list a file more than once in the %files listing
 [x] %files section includes %defattr and permissions are set properly
 [x] %clean section is there and contains rm -rf $RPM_BUILD_ROOT
 [x] Macros are consistently used
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage
 [x] Program runs properly without files listed in %doc
 [-] Header files are in a -devel package
 [-] Static libraries are in a -static package
 [-] Package requires pkgconfig if .pc files are present
 [-] .so-files are put into a -devel subpackage
 [-] Subpackages include fully versioned dependency for the base package
 [-] Any libtool archives (*.la) are removed
 [-] contains desktop file (%{name}.desktop) if it is a GUI application
 [x] Package does not own files or directories owned by other packages.
 [x] $RPM_BUILD_ROOT is removed at beginning of %install
 [-] Filenames are encoded in UTF-8

=== SUGGESTED ITEMS ===
 [x] Package contains latest upstream version
 [x] Package does not include license text files separate from upstream.
 [-] non-English translations for description and summary
 [x] Package builds in mock
     Tested on: F12/x86_64
 [x] Package should compile and build into binary RPMs on all supported architectures.
     tested build with koji
 [x] Program runs
 [-] Scriptlets must be sane, if used.
 [-] pkgconfig (*.pc) files are placed in a -devel package
 [-] require package providing a file instead of the file itself
     no files outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin are required

Small hints:
 - There is a space at the beginning of line 16 which may not be necessary

The package is APPROVED.

Comment 2 Damien Durand 2010-02-14 21:23:37 UTC
New Package CVS Request
=======================
Package Name: papercut
Short Description: A command line Rock, Paper, Scissors game
Owners: splinux
Branches: F-11 F-12
InitialCC: splinux

Comment 3 Kevin Fenzi 2010-02-16 03:54:53 UTC
CVS done (by process-cvs-requests.py).

Comment 4 Damien Durand 2010-02-16 11:34:31 UTC
The release is bumped and the space character is fixed.


Note You need to log in before you can comment on or make changes to this bug.