Created attachment 394360 [details] Contains patches for FIP issues plus fnic driver version update Description of problem: Patches for fixes for three issues are attached for incorporation into RHEL 5.5. The patches provided in the attachment are based on internal QA testing, more testing is in progress. The patches address these issues - 1) To enable FIP support in fnic, we have to register with hardware to receive FIP solication frames on a well-known multicast address. Before FIP support, the firmware interface allowed multicast address registrations only for enic devices. This is a minor change in fnic to allow the firmware interface to now register mcast addresses for fnic too. 2) Incorrect initialization of lport stats in fnic_probe() causes fnic to crash at bootup and a node hang if fip is enabled and all links are brought up after fnic is loaded. 3) Update fnic driver version to 1.4.0.98 Version-Release number of selected component (if applicable): 5.0 How reproducible: N/A Steps to Reproduce: 1. 2. 3. Actual results: N/A Expected results: N/A Additional info: There is a fourth patch that needs to be picked up from the upstream fcoe-fixes tree. The URL of the patch is given below - X-Git-Url: http://www.open-fcoe.org/openfc/gitweb/?p=openfc%2Ffcoe-fixes.git;a=commitdiff_plain;h=df93357a349000435e787e9afdcd33413c9b32bb libfcoe: Send port LKA every FIP_VN_KA_PERIOD secs.
Are the patches here https://bugzilla.redhat.com/attachment.cgi?id=394360 upstream? All the fnic patches seem harmless enough. They are small and contained to fnic. The open-fcoe patch also looks ok for RHEL 5.5 at this point.
yes, they were submitted to open-fcoe mailing alias; Rob should pick them up for fcoe-fixes. Mike, There is a libfc bug fix which is already in upstream 2.6.32 stable, could you pick that up for 5.5? Its a 1-line fix without which a rport can enter into a state where it keeps toggling between DELETED and RESTART states and only way to get the initiator to login back to that rport is to unload/reload the module. thanks -- abhijeet http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.32.y.git;a=commit;h=5543c72e2bbb30e5ba5938b18ec26617b8b3fb04
> > There is a libfc bug fix which is already in upstream 2.6.32 stable, could you > pick that up for 5.5? > No problem. Send that patch too with the update. > Its a 1-line fix without which a rport can enter into a state where it keeps > toggling between DELETED and RESTART states and only way to get the initiator > to login back to that rport is to unload/reload the module. > > http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.32.y.git;a=commit;h=5543c72e2bbb30e5ba5938b18ec26617b8b3fb04
Andrius, Are the fnic/libfc bug fixes attached to this bug going to be available in snapshot 2 next week?
I won't know when patches will make it until they are reviewed internally. Snapshot 2 is already spun, so it won't make that one. We are currently developing to Snapshot 3.
Ok, until then QA here will run with snapshot 1 (2 when available) + fnic/libfc bug fixes already submitted to Redhat.
Created attachment 394825 [details] Fix bugs in fnic and libfc that were found during Cisco testing Here is the patch I am sending. It includes: http://marc.info/?l=linux-scsi&m=126635134802937&w=2 http://marc.info/?l=linux-scsi&m=126635135202946&w=2 http://marc.info/?l=linux-scsi&m=126635135802961&w=2 http://marc.info/?l=linux-scsi&m=126635133602924&w=2 http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.32.y.git;a=commit;h=5543c72e2bbb30e5ba5938b18ec26617b8b3fb04
yes, that's right. Thanks!
Abhijeet, This bug is in RHEL 6 too, right? Did you guys make a bz for it? I did not see one. If not, I will just clone this one and send a patch for RHEL6.
No, we missed it. Please clone and post. Thanks!
Is Cisco expecting more fnic/libfc patches between now and a month from now? I ask because we still have some time before the Beta 2 deadline.
you are talking about RHEL 6.0, correct? No additional patches right now, except bug fixes if any found during QA testing.
Abhijeet, it would be best if the new Bugzilla RHEL 6 bug was reported by a Cisco.com address. Thanks!
in kernel-2.6.18-190.el5 You can download this test kernel from http://people.redhat.com/jwilson/el5 Please update the appropriate value in the Verified field (cf_verified) to indicate this fix has been successfully verified. Include a comment with verification details.
Verified that the patches have made it into the 190 kernel.
Did you guys make a bugzilla for RHEL 6? I did a quick search but did not see one.
Hi Mike, I was having some permission issues with RHEL6.0 bugzilla - the clone bug# is 570693. Please let me know if you need any additional info. Regards, Vijayendra.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2010-0178.html