Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 565594

Summary: [Cisco 5.5 bug] Update fnic to 1.4.0.98 to fix FIP crash/hang issues
Product: Red Hat Enterprise Linux 5 Reporter: Venkata Siva Vijayendra Bhamidipati <vbhamidi>
Component: kernelAssignee: Mike Christie <mchristi>
Status: CLOSED ERRATA QA Contact: Red Hat Kernel QE team <kernel-qe>
Severity: high Docs Contact:
Priority: high    
Version: 5.5CC: abjoglek, andriusb, bzeranski, mchristi, savbu-lnx-drivers, syeghiay, vbhamidi
Target Milestone: rcKeywords: OtherQA
Target Release: 5.5   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-03-30 07:21:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 533941    
Attachments:
Description Flags
Contains patches for FIP issues plus fnic driver version update
none
Fix bugs in fnic and libfc that were found during Cisco testing none

Description Venkata Siva Vijayendra Bhamidipati 2010-02-15 17:49:13 UTC
Created attachment 394360 [details]
Contains patches for FIP issues plus fnic driver version update

Description of problem:

Patches for fixes for three issues are attached for incorporation into RHEL 5.5. The patches provided in the attachment are based on internal QA testing, more
testing is in progress. The patches address these issues -

1) To enable FIP support in fnic, we have to register with hardware to receive FIP solication frames on a well-known multicast address.
Before FIP support, the firmware interface allowed multicast address registrations only for enic devices. This is a minor change in fnic to allow the firmware interface to now register mcast addresses for fnic too.

2) Incorrect initialization of lport stats in fnic_probe() causes fnic to crash at bootup and a node hang if fip is enabled and all links are brought up after fnic is loaded.

3) Update fnic driver version to 1.4.0.98




Version-Release number of selected component (if applicable): 5.0


How reproducible: N/A


Steps to Reproduce:
1.
2.
3.
  
Actual results: N/A


Expected results: N/A


Additional info:


There is a fourth patch that needs to be picked up from the upstream fcoe-fixes
tree. The URL of the patch is given below -

X-Git-Url:

http://www.open-fcoe.org/openfc/gitweb/?p=openfc%2Ffcoe-fixes.git;a=commitdiff_plain;h=df93357a349000435e787e9afdcd33413c9b32bb


libfcoe: Send port LKA every FIP_VN_KA_PERIOD secs.

Comment 2 Mike Christie 2010-02-16 17:30:23 UTC
Are the patches here
https://bugzilla.redhat.com/attachment.cgi?id=394360
upstream?

All the fnic patches seem harmless enough. They are small and contained to fnic.

The open-fcoe patch also looks ok for RHEL 5.5 at this point.

Comment 3 Abhijeet Joglekar 2010-02-17 00:11:45 UTC
yes, they were submitted to open-fcoe mailing alias; Rob should pick them up for fcoe-fixes.

Mike,

There is a libfc bug fix which is already in upstream 2.6.32 stable, could you pick that up for 5.5?

Its a 1-line fix without which a rport can enter into a state where it keeps toggling between DELETED and RESTART states and only way to get the initiator to login back to that rport is to unload/reload the module.

thanks
-- abhijeet

http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.32.y.git;a=commit;h=5543c72e2bbb30e5ba5938b18ec26617b8b3fb04

Comment 4 Mike Christie 2010-02-17 18:23:04 UTC
> 
> There is a libfc bug fix which is already in upstream 2.6.32 stable, could you
> pick that up for 5.5?
> 

No problem. Send that patch too with the update.

> Its a 1-line fix without which a rport can enter into a state where it keeps
> toggling between DELETED and RESTART states and only way to get the initiator
> to login back to that rport is to unload/reload the module.
> 
> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.32.y.git;a=commit;h=5543c72e2bbb30e5ba5938b18ec26617b8b3fb04

Comment 5 Abhijeet Joglekar 2010-02-17 18:30:50 UTC
Andrius,

Are the fnic/libfc bug fixes attached to this bug going to be available in snapshot 2 next week?

Comment 6 Andrius Benokraitis 2010-02-17 19:02:19 UTC
I won't know when patches will make it until they are reviewed internally. Snapshot 2 is already spun, so it won't make that one. We are currently developing to Snapshot 3.

Comment 7 Abhijeet Joglekar 2010-02-17 19:32:42 UTC
Ok, until then QA here will run with snapshot 1 (2 when available) + fnic/libfc bug fixes already submitted to Redhat.

Comment 9 Abhijeet Joglekar 2010-02-18 08:37:07 UTC
yes, that's right. Thanks!

Comment 12 Mike Christie 2010-02-18 23:20:42 UTC
Abhijeet,

This bug is in RHEL 6 too, right? Did you guys make a bz for it? I did not see one. If not, I will just clone this one and send a patch for RHEL6.

Comment 13 Abhijeet Joglekar 2010-02-19 16:28:03 UTC
No, we missed it. Please clone and post. Thanks!

Comment 14 Andrius Benokraitis 2010-02-19 17:13:35 UTC
Is Cisco expecting more fnic/libfc patches between now and a month from now? I ask because we still have some time before the Beta 2 deadline.

Comment 15 Abhijeet Joglekar 2010-02-19 17:26:42 UTC
you are talking about RHEL 6.0, correct?

No additional patches right now, except bug fixes if any found during QA testing.

Comment 16 Andrius Benokraitis 2010-02-19 17:32:56 UTC
Abhijeet, it would be best if the new Bugzilla RHEL 6 bug was reported by a Cisco.com address. Thanks!

Comment 17 Jarod Wilson 2010-02-23 20:06:23 UTC
in kernel-2.6.18-190.el5
You can download this test kernel from http://people.redhat.com/jwilson/el5

Please update the appropriate value in the Verified field
(cf_verified) to indicate this fix has been successfully
verified. Include a comment with verification details.

Comment 19 Venkata Siva Vijayendra Bhamidipati 2010-02-25 21:38:37 UTC

Verified that the patches have made it into the 190 kernel.

Comment 21 Mike Christie 2010-03-05 02:22:02 UTC
Did you guys make a bugzilla for RHEL 6? I did a quick search but did not see one.

Comment 22 Venkata Siva Vijayendra Bhamidipati 2010-03-05 02:58:28 UTC
Hi Mike,

I was having some permission issues with RHEL6.0 bugzilla - the clone bug# is 570693. Please let me know if you need any additional info.

Regards,
Vijayendra.

Comment 24 errata-xmlrpc 2010-03-30 07:21:44 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0178.html