Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 565618

Summary:	condor_submit fsync()s UserLog for each job
Product:	Red Hat Enterprise MRG	Reporter:	Matthew Farrellee <matt>
Component:	condor	Assignee:	Matthew Farrellee <matt>
Status:	CLOSED ERRATA	QA Contact:	Tomas Rusnak <trusnak>
Severity:	high	Docs Contact:
Priority:	high
Version:	1.2	CC:	fnadge, trusnak
Target Milestone:	1.3
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	condor_submit fsync()d the UserLog for each job submitted. With this update, the UserLog is only fsync()d once.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-10-14 16:08:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Matthew Farrellee 2010-02-15 18:53:48 UTC

Description of problem:

$ echo -e 'cmd=/bin/sleep\nargs=1m\nlog=test.log\nqueue 100\n' | strace condor_submit 2>&1 | grep ^fsync | wc -l
100
$ echo -e 'cmd=/bin/sleep\nargs=1m\nlog=test.log\nqueue 1000\n' | strace condor_submit 2>&1 | grep ^fsync | wc -l
1000


Version-Release number of selected component (if applicable):

All through at least condor 7.4.3-0.1


How reproducible:

100%


Steps to Reproduce:
1. (see description)


Expected results:

Considerably fewer fsyncs, just 1 would be best

Comment 1 Matthew Farrellee 2010-02-15 18:58:16 UTC

commit 579dffc9e99b6b50cce342f5468b3b3b8c3a95fb
Author: Dan Bradley <dan@>
Date:   Thu Feb 11 16:35:55 2010 -0600

    Only fsync user log once when writing multiple submit events.
    Previously, 'queue 100' caused 100 calls to fsync.

Comment 2 Matthew Farrellee 2010-02-15 19:24:10 UTC

With the patch from #c1 applied:

$ echo -e 'cmd=/bin/sleep\nargs=1m\nlog=test.log\nqueue 100\n' | strace ./release_dir/bin/condor_submit 2>&1 | grep ^fsync | wc -l
1

Comment 3 Matthew Farrellee 2010-02-15 19:32:42 UTC

slated for condor 7.4.3-0.2

Comment 4 Tomas Rusnak 2010-03-18 17:21:44 UTC

Problem reproduced on:

$ condor -v
$CondorVersion: 7.4.1 Dec 11 2009 BuildID: RH-7.4.1-0.7.1.el5 PRE-RELEASE $
$CondorPlatform: X86_64-LINUX_RHEL5 $

$ echo -e 'cmd=/bin/sleep\nargs=1m\nlog=test.log\nqueue 100\n' | strace condor_submit 2>&1 | grep ^fsync | wc -l
100

$ echo -e 'cmd=/bin/sleep\nargs=1m\nlog=test.log\nqueue 1000\n' | strace condor_submit 2>&1 | grep ^fsync | wc -l
1000

Comment 5 Tomas Rusnak 2010-03-19 10:04:21 UTC

$CondorVersion: 7.4.3 Mar 16 2010 BuildID: RH-7.4.3-0.5.el4 PRE-RELEASE $
$CondorPlatform: X86_64-LINUX_RHEL4 $

$ echo -e 'cmd=/bin/sleep\nargs=1m\nlog=test.log\nqueue 100\n' | strace condor_submit 2>&1 | grep ^fsync | wc -l
1

$CondorVersion: 7.4.3 Mar 16 2010 BuildID: RH-7.4.3-0.5.el4 PRE-RELEASE $
$CondorPlatform: I386-LINUX_RHEL4 $

$ echo -e 'cmd=/bin/sleep\nargs=1m\nlog=test.log\nqueue 100\n' | strace condor_submit 2>&1 | grep ^fsync | wc -l
1

$CondorVersion: 7.4.3 Mar 16 2010 BuildID: RH-7.4.3-0.5.el5 PRE-RELEASE $
$CondorPlatform: X86_64-LINUX_RHEL5 $

$ echo -e 'cmd=/bin/sleep\nargs=1m\nlog=test.log\nqueue 100\n' | strace condor_submit 2>&1 | grep ^fsync | wc -l
1

$CondorVersion: 7.4.3 Mar 16 2010 BuildID: RH-7.4.3-0.5.el5 PRE-RELEASE $
$CondorPlatform: I386-LINUX_RHEL5 $

$ echo -e 'cmd=/bin/sleep\nargs=1m\nlog=test.log\nqueue 100\n' | strace condor_submit 2>&1 | grep ^fsync | wc -l
1

Problem resolved in version 7.4.3-0.5

>>> VERIFIED

Comment 6 Martin Prpič 2010-10-10 10:12:27 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Logging 'condor_submit' fsync()s resulted in the creation of a log for each executed job. With this update, all outputs are logged in a single file.

Comment 7 Matthew Farrellee 2010-10-10 11:04:41 UTC

    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1 +1 @@
-Logging 'condor_submit' fsync()s resulted in the creation of a log for each executed job. With this update, all outputs are logged in a single file.+condor_submit fsync()d the UserLog for each job submitted. With this update, the UserLog is only fsync()d once.

Comment 9 errata-xmlrpc 2010-10-14 16:08:51 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0773.html