Bug 565916 - Review Request: php-ezc-Graph - A component for creating pie charts, line graphs and other kinds of diagrams
Summary: Review Request: php-ezc-Graph - A component for creating pie charts, line gra...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Steve Traylen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-16 17:36 UTC by Remi Collet
Modified: 2010-08-29 18:56 UTC (History)
4 users (show)

Fixed In Version: php-ezc-Graph-1.5-1.fc13
Clone Of:
Environment:
Last Closed: 2010-03-09 03:14:34 UTC
Type: ---
Embargoed:
steve.traylen: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Remi Collet 2010-02-16 17:36:30 UTC
Spec URL: http://remi.fedorapeople.org/php-ezc-Graph.spec
SRPM URL: http://remi.fedorapeople.org/php-ezc-Graph-1.5-1.remi.src.rpm
Description:
The Graph component enables you to create line, pie and bar charts. 
The output driver mechanism allows you to create different image types
from each chart, and the available renderers make the chart output 
customizable from simple two-dimensional charts to beautiful 
three-dimensional data projections.

rpmlint is silent:
php-ezc-Graph.src: I: checking
php-ezc-Graph.noarch: I: checking
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

koji scratch build (F-13)
http://koji.fedoraproject.org/koji/taskinfo?taskID=1991307

Comment 1 Steve Traylen 2010-02-20 11:16:47 UTC
Bonjour Remi,

I note the build is a little noisy:

Warning: date(): It is not safe to rely on the system's timezone settings. You are *required* to use the date.ti:
mezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are st:
ill getting this warning, you most likely misspelled the timezone identifier. We selected 'Europe/Berlin' for 'C:
ET/1.0/no DST' instead in PEAR/Registry.php on line 1012
:
PHP Warning:  date(): It is not safe to rely on the system's timezone settings. You are *required* to use the da:
te.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you a:
re still getting this warning, you most likely misspelled the timezone identifier. We selected 'Europe/Berlin' f:
or 'CET/1.0/no DST' instead in /usr/share/pear/PEAR/Registry.php on line 1012

maybe this irrelevant till run time?


Anyway on to the review:

yes: rpmlint.
$ rpmlint php-ezc-Graph.spec \
  ../RPMS/noarch/php-ezc-Graph-1.5-1.fc12.noarch.rpm \
  ../SRPMS/php-ezc-Graph-1.5-1.fc12.src.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

yes: Named like the other php-ezc-* packages.
yes: Spec file name matches pkg name.
yes: Meets pkg guidelines.
yes: Spec file states BSD.
yes: Software licensed as New BSD (no advertising, 3 clause) 
yes: LICENSE file present.
/usr/share/doc/php-ezc-Graph-1.5/docs/LICENSE
yes: American eng
yes: legible .spec.
yes: souce matches URL.
$ md5sum Graph-1.5.tgz SOURCES/Graph-1.5.tgz 
c8b5e0f3b28aad667154d65408453feb  Graph-1.5.tgz
c8b5e0f3b28aad667154d65408453feb  SOURCES/Graph-1.5.tgz
yes: package builds fine.
yes: build requirements sane.
yes: no locales.
yes: No share libs.
yes: No system libs.
yes: Not relocatable.
yes: Directories should be owned or pulled in.

/usr/share/pear/.pkgxml   owned by php-pear
/usr/share/pear/data       owned by php-pear
/usr/share/pear/ezc        owned by php-ezc-Base

all are pulled in.

yes: no file duplicates.
yes: consistant macros.
yes: %clean actually cleans.
yes: There are quite a lot of doc files but only 1.9 Meg so fine.
yes: %doc not needed.
yes: No header files.
yes: No gui.
yes: no .la files.
yes: Does not own directories belonging to other packages.
yes: %install cleans first.

All good package APPROVED.

  Steve.
(I've a couple of packages up for review at the moment if you have time)

Comment 2 Remi Collet 2010-02-21 06:38:42 UTC
Thanks for the review.

Yes "date()" are only warning. Perhaps we should investigate on hos to avoid this... (define the TZ in the builder ?)

Comment 3 Remi Collet 2010-02-21 06:40:25 UTC
New Package CVS Request
=======================
Package Name: php-ezc-Graph
Short Description: A component for creating charts, graphs and diagrams
Owners: remi
Branches: F-11 F-12 F-13
InitialCC:

Comment 4 Jason Tibbitts 2010-02-22 21:28:03 UTC
CVS done (by process-cvs-requests.py).

Comment 5 Fedora Update System 2010-02-23 05:51:18 UTC
php-ezc-Graph-1.5-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/php-ezc-Graph-1.5-1.fc13

Comment 6 Fedora Update System 2010-02-23 05:51:36 UTC
php-ezc-Graph-1.5-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/php-ezc-Graph-1.5-1.fc12

Comment 7 Fedora Update System 2010-02-23 05:52:09 UTC
php-ezc-Graph-1.5-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/php-ezc-Graph-1.5-1.fc11

Comment 8 Fedora Update System 2010-02-23 16:09:03 UTC
php-ezc-Graph-1.5-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-ezc-Graph'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F13/FEDORA-2010-2684

Comment 9 Fedora Update System 2010-02-24 06:07:53 UTC
php-ezc-Graph-1.5-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-ezc-Graph'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-2734

Comment 10 Fedora Update System 2010-02-24 06:13:34 UTC
php-ezc-Graph-1.5-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-ezc-Graph'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-2758

Comment 11 Fedora Update System 2010-03-09 03:14:29 UTC
php-ezc-Graph-1.5-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2010-03-09 03:22:47 UTC
php-ezc-Graph-1.5-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2010-03-09 03:28:10 UTC
php-ezc-Graph-1.5-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Remi Collet 2010-08-29 09:09:49 UTC
Package Change Request
======================
Package Name: php-ezc-Graph
New Branches: EL-6
Owners: remi  llaumgui

Comment 15 Kevin Fenzi 2010-08-29 18:56:24 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.