Bug 566085 - rc.sysinit produces errors when selinux is disabled
Summary: rc.sysinit produces errors when selinux is disabled
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: initscripts
Version: 12
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Bill Nottingham
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-17 06:45 UTC by Christian Lupien
Modified: 2014-03-17 03:22 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-12-03 22:42:22 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Christian Lupien 2010-02-17 06:45:45 UTC
Description of problem:
With selinux disabled, the /etc/rc.sysinit script produces an error. This was discovered after fixing bug 564272

Version-Release number of selected component (if applicable):
initscripts-9.02.1-1.x86_64


How reproducible:
All the time.

Steps to Reproduce:
1. Disable selinux with the GUI (or put into /etc/selinux/config)
SELINUX=disabled. Do not disable it by booting with the selinux=0 kernel parameter.
2. Reboot: (For this to work properly, the fix for dracut in bug 564272 needs to be installed)
3. Look at boot log file.
  
Actual results:
The /var/log/boot file begins with
cat: /proc/self/attr/current: Invalid argument

Expected results:
The error should not be present.

Additional info:

The error is due to line 36 of /etc/rc.d/rc.sysinit
if [ -e "/selinux/enforce" ] && [ "$(cat /proc/self/attr/current)" != "kernel"
]
The problem is that when selinux is disabled as above then 
/proc/self/attr/current is not there, but /selinux/enforce is still present. In fact the /selinux filesystem seems to be
mounted but it is not present in /proc/mounts or /proc/filesystems: 
#ls /selinux
booleans  commit_pending_bools  enforce  load  mls  policyvers

A fix that works for me is to replace the line with:
if [ -e "/selinux/disable" ] && [ -e "/selinux/enforce" ] && [ "$(cat
/proc/self/attr/current)" != "kernel" ]; then

Comment 1 Bill Nottingham 2010-02-17 15:41:51 UTC
Why is the filesystem mounted in this case? That seems to be the real bug here.

Comment 2 Christian Lupien 2010-02-23 20:25:50 UTC
I just understood that the selinux filesystem is not mounted. What I see are actual files present in the /selinux directory.

I see this on another system where selinux is enabled. On that system, when I unmount /selinux, that directory also contains files and directories:
ls -l /selinux
total 16
drwxr-xr-x. 2 root root 4096 2009-06-04 15:48 booleans
-rwxr-xr-x. 1 root root    0 2009-06-04 15:48 commit_pending_bools
-rwxr-xr-x. 1 root root    1 2009-06-04 15:53 enforce
crw-r--r--. 1 root root 1, 3 2009-06-04 15:48 load
-rwxr-xr-x. 1 root root    1 2009-06-04 15:48 mls
-rwxr-xr-x. 1 root root    3 2009-06-04 15:48 policyvers


The file times seem to correspond to my fresh install of Fedora 11.
For Fedora 12 I did an upgrade instead of a full install.

So somebody should check that those files don't exist in a fresh install of Fedora 12 (by: umount /selinux, ls /selinux, which should be empty).

If that is the case then the problems is due do the upgrade from Fedora 11.

Comment 3 Eelko Berkenpies 2010-03-08 12:34:03 UTC
Got the same problem here; Fedora 12, initscripts-9.02.1-1.i686 and SELinux disabled (both by having a kernel argument and changing /etc/selinux/config).

Although I somewhat understand what the problem is, it's beyond my knowledge to track this down / resolve it myself. I'd be happy to do some testing or giving additional info when required though. :)

Comment 4 Bill Nottingham 2010-03-08 17:33:42 UTC
Eelko - was this a fresh install or an upgrade?

Comment 5 Eelko Berkenpies 2010-03-08 18:36:51 UTC
My memory is failing me but I think it has been preupgraded from F11 to F12 (it's my office machine, I'll check that tomorrow and will let you know when it's different).

I recently preupgraded a few office machines from F10 to F12. I'll also check if they got the same problem, tomorrow.

Comment 6 Eelko Berkenpies 2010-03-10 14:19:58 UTC
Bill - my machine was preupgraded from F11 to F12 as far as I can tell (it's definitely not a clean install).

I checked 3 other machines at the office which were preupgraded from F10 to F12 and they don't seem to be having the problem, can we say it's F11 -> F12 only (or has that conclusion already been made)?

Comment 7 Bug Zapper 2010-11-03 21:55:04 UTC
This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 8 Bug Zapper 2010-12-03 22:42:22 UTC
Fedora 12 changed to end-of-life (EOL) status on 2010-12-02. Fedora 12 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.