Spec URL: http://tmp.fgsp.org/fedora/rpm/cover-thumbnailer.spec SRPM URL: http://tmp.fgsp.org/fedora/rpm/cover-thumbnailer-0.7-1.fc11.src.rpm Description: Cover thumbnailer is a small Python script which displays music album covers in nautilus, preview of pictures which are in a folder and more. The script fits in nautilus like any other thumbnailer of the GNOME thumbnail factory; so you don't have to run it manually to generate thumbnails.
rmplint output : cover-thumbnailer.noarch: W: non-conffile-in-etc /etc/gconf/schemas/cover-thumbnailer.schemas 1 packages and 0 specfiles checked; 0 errors, 1 warnings. build successfully with mock
Hello FLOZz: This is not an official review, but some preliminary observations: 1. At first glance I can see that you need to prefix configuration files with %config (as indicated by the output of rpmlint) as follows: %config %{_sysconfdir}/gconf/schemas/cover-thumbnailer.schemas 2. BuildRoot is no more needed, so you can remove the line: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) 3. Also don't need to remove and create buildroot in install section, so you can remove the lines: rm -rf $RPM_BUILD_ROOT mkdir -p $RPM_BUILD_ROOT Hope this helps you. Cheers, Germán.
> 1. At first glance I can see that you need to prefix configuration files with > %config (as indicated by the output of rpmlint) as follows: > > %config %{_sysconfdir}/gconf/schemas/cover-thumbnailer.schemas No, GConf files are not concerned by this tag, these files are not intended to be modified in theory, so they cannot be considered to be conf. files. rpmlint warnings about these files are false-positives and should be ignored. Some "case laws" ^^: https://bugzilla.redhat.com/show_bug.cgi?id=564567#c2 https://bugzilla.redhat.com/show_bug.cgi?id=494726#c0
OK thanks for clarifying! If you take a look at the spec file of totem, in my case totem-2.28.5-1.fc12.i686, you can see that GConf files are prefixed with %config. I was following this example.
I have updated the SPEC and the package (the version is now the 0.7.2) :) SPEC : http://tmp.fgsp.org/fedora/rpm/cover-thumbnailer.spec SRPM : http://tmp.fgsp.org/fedora/rpm/cover-thumbnailer-0.7.2-1.fc11.src.rpm @Germán Racca : I have removed "rm -rf $RPM_BUILD_ROOT" in the %install section, but I can't remove "mkdir -p $RPM_BUILD_ROOT", because I can't build the package without :/
Get ride of "rm -rf $RPM_BUILD_ROOT" in the %install section and then take a look at the output of rpmlint command: [german@skytux i686]$ rpmlint -i cover-thumbnailer-0.7.2-1.fc12.i686.rpm cover-thumbnailer.i686: E: no-binary The package should be of the noarch architecture because it doesn't contain any binaries. cover-thumbnailer.i686: W: non-conffile-in-etc /etc/gconf/schemas/cover-thumbnailer.schemas A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. So you are missing "BuildArch: noarch" in your spec file. Hope this helps you!
I have added "BuildArch: noarch". Thanks ! :) SPEC : http://tmp.fgsp.org/fedora/rpm/cover-thumbnailer.spec SRPM : http://tmp.fgsp.org/fedora/rpm/cover-thumbnailer-0.7.2-1.fc11.src.rpm
Who can review this?
The latest release is 0.8.1.
FLOZz, did you still wish to submit this package? I don't use gnome so I can't be of much assistance here, but I can suggest that you read http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group and start doing some of the things indicated there. I notice a correspondence between your email domain and the upstream site; if you are the upstream author or involved in upstream development, you should communicate that to us. It would also be good to provide a real name to bugzilla (since you'll need to do that anyway when you obtain a Fedora account).
I have no more time to do this package... Someone else want to do it, so I close this bug :)