Spec URL: http://mmaslano.fedorapeople.org/review/perl-MooseX-Types-DateTimeX.spec
SRPM URL: http://mmaslano.fedorapeople.org/review/perl-MooseX-Types-DateTimeX-0.06-1.fc13.src.rpm
Description: This module builds on MooseX::Types::DateTime to add additional custom types and coercions. Since it builds on an existing type, all coercions and
constraints are inherited.
Is missing a whole bunch of BuildRequires. From Makefile.PL, at least these are necessary.
requires 'Moose' => '0.41';
requires 'MooseX::Types' => '0.04';
requires 'namespace::clean' => '0.08';
requires 'Time::Duration::Parse' => '0.06';
requires 'MooseX::Types::DateTime::ButMaintained' => '0.04';
requires 'DateTimeX::Easy' => '0.085';
test_requires 'Test::use::ok' => '0.02';
test_requires 'Test::Exception' => '0.27';
cpanspec missed them. Also I added conflicts because of:
pm -i rpmbuild/RPMS/noarch/perl-MooseX-Types-DateTimeX-0.06-1.fc12.noarch.rpm
file /usr/lib/perl5/vendor_perl/5.10.0/MooseX/Types/DateTimeX.pm from install of perl-MooseX-Types-DateTimeX-0.06-1.fc12.noarch conflicts with file from package perl-MooseX-Types-DateTime-0.03-5.fc12.noarch
I fix it also in MooseX-Types-DateTime.
This one also needs the PERL5_CPANPLUS_IS_RUNNING=1 tweak to build in mock (locally, f14, with perl-Olson-Abbreviations and perl-MooseX-Types-DateTime-ButMaintained installed).
Source tarball matches upstream:
Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.
Final provides are sane:
perl(MooseX::Types::DateTimeX) = 0.06
perl-MooseX-Types-DateTimeX = 0.06-2.fc14
Final requires are sane:
Final conflicts are appropriate and necessary:
perl(MooseX::Types::DateTime) < 0.05
rpmlint is silent.
I think you should add an explicit 'Requires: perl(Moose) >= 0.41' since it's not automatically picked up (even though it gets pulled in by other deps, I think it's better to mention it here too). And you need the PERL5_CPANPLUS_IS_RUNNING hack to build in mock.
With those two conditions, APPROVED.
New Package CVS Request
Package Name: perl-MooseX-Types-DateTimeX
Short Description: Extensions to MooseX::Types::DateTime::ButMaintained
CVS done (by process-cvs-requests.py).
perl-MooseX-Types-DateTimeX-0.06-3.fc13 has been submitted as an update for Fedora 13.
perl-MooseX-Types-DateTimeX-0.06-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.