Bug 566905 - resize2fs is causing bad inodes count
Summary: resize2fs is causing bad inodes count
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: e2fsprogs
Version: 12
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Eric Sandeen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-20 10:45 UTC by James Heather
Modified: 2010-02-21 14:52 UTC (History)
5 users (show)

Fixed In Version: e2fsprogs-1.41.9-7.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-21 14:52:53 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
screwed up resized image (78 bytes, text/plain)
2010-02-20 10:57 UTC, James Heather
no flags Details
image that gets screwed by resize2fs -M (73 bytes, text/plain)
2010-02-20 13:59 UTC, James Heather
no flags Details

Description James Heather 2010-02-20 10:45:10 UTC
I don't think this is related to #566329, but it might be. The reason I don't think it's related is that this occurred running on the 174.2.3 kernel, which seemingly isn't falling foul of #566329.

This is on a fully up to date F12, building an F11 live CD:

resize2fs 1.41.9 (22-Aug-2009)
Resizing the filesystem on /var/tmp/imgcreate-47Szwr/tmp-s_adO_/ext3fs.img to 1667225 (4k) blocks.
The filesystem on /var/tmp/imgcreate-47Szwr/tmp-s_adO_/ext3fs.img is now 1667225 blocks long.

e2fsck 1.41.9 (22-Aug-2009)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Pass 5: Checking group summary information
Free inodes count wrong for group #32 (8192, counted=23).
Fix? yes

Free inodes count wrong (191598, counted=183429).
Fix? yes


JAH-live-F11-x86: ***** FILE SYSTEM WAS MODIFIED *****
JAH-live-F11-x86: 234363/417792 files (0.2% non-contiguous), 1656071/1667225 blocks
/usr/lib/python2.6/site-packages/imgcreate/errors.py:45: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6
  return unicode(self.message)
Error creating Live CD : fsck after resize returned an error!  image to debug at /tmp/resize-image-pTYaoX

I'll attach the debug image.

James

Comment 1 James Heather 2010-02-20 10:57:00 UTC
Created attachment 395241 [details]
screwed up resized image

Comment 2 James Heather 2010-02-20 11:48:30 UTC
Ah--I hadn't realised that a new build of e2fsprogs, and a new kernel, hit my machine overnight. So I was running e2fsprogs-1.41.9-6.fc12.x86_64, but without realising this. The bug report for #566329 would have been 1.41.9-5. I don't know if that's relevant. I hadn't rebooted, so I was still on the 174.2.3 kernel.

I have rebooted the machine, still in the 174.2.3 kernel, just in case the old e2fs libs were already in memory. Running the build again, with the new e2fsprogs, but the old kernel.

After that, I'll try the new e2fsprogs and the new kernel, and report back.

Comment 3 James Heather 2010-02-20 12:46:53 UTC
Failed on both attempts, I'm afraid.

This is still happening with the new kernel and new e2fsprogs, so it is a genuine live bug, and different from #566329.

Let me know if I can help in any way.

James

Comment 4 James Heather 2010-02-20 13:50:06 UTC
OK, I think I have something more useful than the previous debug image. I'll attach another image, which gets screwed up if you try to resize it (using e2fsprogs-1.41.9-6.fc12.x86_64).

The image as it stands checks fine. But if you then

  resize2fs -M bad-resize.img

and then e2fsck again, you get errors.

James

Comment 5 James Heather 2010-02-20 13:59:00 UTC
Created attachment 395259 [details]
image that gets screwed by resize2fs -M

Comment 6 Eric Sandeen 2010-02-20 15:19:50 UTC
thanks, I guess ;)  I'll look into this one.

livecd really challenges resize2fs...

-Eric

Comment 7 Scott Dowdle 2010-02-20 22:41:21 UTC
This problem affects me too... when trying to build a remix.  I also added comments to #566329.  Thanks.

Comment 8 Eric Sandeen 2010-02-20 22:43:25 UTC
if you narrow it down to either e2fsprogs, or kernel, please let me know; otherwise will try to get to this soon (but I'm actually trying to make my weekend a weekend ...)

Comment 9 James Heather 2010-02-20 23:36:53 UTC
It happens when invoking resize2fs, so surely that means it's e2fsprogs? It wasn't a great shock that #566329 was a kernel issue because it was a question of corruption on a mounted filesystem, i.e., it was the kernel filesystem driver's job to do the disk access and work out where to put things. But here, we're explicitly invoking resize2fs on an unmounted filesystem--so I would think the kernel wouldn't be involved.

But I am a little out of my depth.

Anyway, I'll reboot into 174.2.3 (which didn't manifest the error with the old e2fsprogs) and see if it now does (with the new e2fsprogs).

(PS Weekends... I remember them...)

Comment 10 Eric Sandeen 2010-02-21 01:03:26 UTC
Can you try 1.41.9-7 from testing?  I think 1.41.9-6 had a bug and I superceded it with -7:

%changelog
* Sun Feb 07 2010 Eric Sandeen <sandeen> 1.41.9-7
- Upstream version of resize2fs array fix, original was wrong

I pushed -6 to stable instead of -7, arg...

Comment 11 Eric Sandeen 2010-02-21 01:04:25 UTC
I actually just pushed -7 to stable, but it'll take a little while to get out.

Grr not ext4's best week!

Comment 12 Scott Dowdle 2010-02-21 05:19:40 UTC
Just finishing up the i686 remix build and it got past the problem part... so the -7 release of e2fsprogs seems to have taken care of the problem for me.  I'll also try it on the x86_64 remix shortly.  Thanks.

Comment 13 Scott Dowdle 2010-02-21 06:45:44 UTC
x86_64 worked great.  Thanks.

Comment 14 James Heather 2010-02-21 11:08:33 UTC
> I actually just pushed -7 to stable, but it'll take a little while to get out.

Perfick! Now building with no errors. Thank you. Will you also build for F11?

> Grr not ext4's best week!    

It has finished the week the stronger for it.

Good work (and sorry about using up your weekend).

James

Comment 15 Eric Sandeen 2010-02-21 14:52:53 UTC
Ok, I'll mark fixed in e2fsprogs-1.41.9-7

I don't think this ever made it to F11 so probably no fixing there.


Note You need to log in before you can comment on or make changes to this bug.