Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 567462

Summary: [Broadcom 5.6 feat] Update tg3 to version 3.108+ and add 5718 B0, 5719 support
Product: Red Hat Enterprise Linux 5 Reporter: Matt Carlson <mcarlson>
Component: kernelAssignee: John Feeney <jfeeney>
Status: CLOSED ERRATA QA Contact: Network QE <network-qe>
Severity: high Docs Contact:
Priority: high    
Version: 5.6CC: andriusb, benlu, bugproxy, bzeranski, cward, ericlrl, gloriach, hjia, jeff.burrell, jfeeney, jjarvis, jleu, junichi.nomura, karen.skweres, kzhang, ltroan, mchan, nobody+PNT0273897, sandy.garza, sbest, tatsu-ab1, uchida-mxb
Target Milestone: rcKeywords: FutureFeature, OtherQA
Target Release: 5.6   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-01-13 21:08:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 528587, 531800, 539334, 557597, 568826, 570892    

Description Matt Carlson 2010-02-23 01:12:32 UTC
Description of problem:

Please update the tg3 driver to version 3.108+ and add 5717 B0 (copper and serdes) support.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Andrius Benokraitis 2010-03-01 20:06:09 UTC
*** Bug 569513 has been marked as a duplicate of this bug. ***

Comment 2 Andrius Benokraitis 2010-03-01 20:08:32 UTC
*** Bug 563340 has been marked as a duplicate of this bug. ***

Comment 3 Andrius Benokraitis 2010-03-11 06:04:51 UTC
*** Bug 570899 has been marked as a duplicate of this bug. ***

Comment 4 Andrius Benokraitis 2010-03-11 06:43:30 UTC
*** Bug 568594 has been marked as a duplicate of this bug. ***

Comment 6 IBM Bug Proxy 2010-06-09 15:16:21 UTC
------- Comment From stanselk.com 2010-06-09 11:07 EDT-------
5719 netdev submission -->

http://marc.info/?l=linux-netdev&m=127579472806415&w=3

PCIID -->

+#define  TG3PCI_DEVICE_TIGON3_5719	 0x1657

Comment 7 IBM Bug Proxy 2010-06-09 15:32:41 UTC
------- Comment From stanselk.com 2010-06-09 11:23 EDT-------
With the 5719 update, the version of tg3 was bumped to 3.111.

Comment 8 Matt Carlson 2010-06-09 16:54:33 UTC
Please don't apply commit 2601d8a0049c8b5d29cd5adb844a305a804e505f.  The before version was correct.

Comment 9 John Feeney 2010-08-13 19:46:34 UTC
Please find rpms on my people page that fulfill the requirements of this bz. See http://people.redhat.com/jfeeney/.bz567462. Testing feedback would be greatly appreciated. Note: I have sanity tested these and found no issues but more testing is certainly needed.

The following upstream patches have been applied to these rpms.
1. tg3: Enable PLL PD when CLKREQ disabled for 5717A0
2. tg3: Abort phy init for 5717
3. tg3: Supply a nicaddr for 57765
4. tg3: Bypass power source switching for 57765
5. tg3: Reset phy during bringup
6. tg3: Fix AC131 loopback test errors
7. tg3: Update to 3.107
8. tg3: Enforce DMA Mapping
9. tg3: Make 57791 and 57785 10/100 only
10. tg3: Add support for 2 new selfboot formats
11. tg3: Add more partno entries
12. tg3: Rename TG3_FLG3_RGMII_STD_IBND_DISABLE
13. tg3: Reduce indent level
14. tg3: Reformat SSID to phy ID table
15. tg3: Rename tg3_phy ID preprocessor definitions
16. tg3: Update to 3.108

Plus the following to make it equivalent to RHEL6:
17. tg3: Disable CLKREQ in L2
18. tg3: Set card 57765 card reader MRRS to 1024B
19. tg3: Reduce 57765 core clock when link at 10Mbps
20. tg3: Relocate APE mutex regs for 5717+
21. tg3: Avoid tx lockups on 5755+
22. tg3: Use devfn to determine function number
23. tg3: Add 5719 ASIC rev
24. tg3: Add 5719 PCI device and phy IDs
25. tg3: Fix ipv6 TSO code in tg3_start_xmit_dma_bug()

Comment 10 John Feeney 2010-08-23 19:07:14 UTC
I was wondering if there was any initial feedback on testing.

Comment 11 Larry Troan 2010-08-30 22:28:30 UTC
Per comment #10, has any of our partners have tested John Feeney's test kernel at http://people.redhat.com/jfeeney/.bz567462.
See comment #9 for details....

Comment 12 Matt Carlson 2010-09-02 17:19:06 UTC
Can you add commit ecc796486f0a7f4958f8dc7550267570dcacb608, "tg3: Detect APE firmware types" to the patchlist?  The rest of the bugs I'm seeing can be dealt with in separate BZs.  (Patches aren't available upstream yet to fix them.  I'm working on that now.)

Comment 13 Larry Troan 2010-09-02 21:01:33 UTC
Have a devel ACK and they requested the exception. Asking for QA ACK and PM ACK.

Comment 14 John Feeney 2010-09-03 00:28:41 UTC
Posted with list of upstream patches as provided in comment #9.

Comment 17 Jarod Wilson 2010-09-15 14:00:25 UTC
in kernel-2.6.18-221.el5
You can download this test kernel from http://people.redhat.com/jwilson/el5

Detailed testing feedback is always welcomed.

Comment 19 Chris Ward 2010-11-09 13:32:13 UTC
~~ Attention Customers and Partners - RHEL 5.6 Public Beta is now available on RHN ~~

A fix for this 'OtherQA' BZ should be present and testable in the release. 

If this Bugzilla is verified as resolved, please update the Verified field above with an appropriate value and include a summary of the testing executed and the results obtained.

If you encounter any issues or have questions while testing, please describe them and set this bug into NEED_INFO. 

If you encounter new defects or have additional patches to request for inclusion, promptly escalate the new issues through your support representative.

Finally, future Beta kernels can be found here:
 http://people.redhat.com/jwilson/el5/

Note: Bugs with the 'OtherQA' keyword require Third-Party testing to confirm the request has been properly addressed. See: https://bugzilla.redhat.com/describekeywords.cgi#OtherQA ).

Comment 20 John Jarvis 2010-11-18 21:06:02 UTC
This enhancement request was evaluated by the full Red Hat Enterprise Linux 
team for inclusion in a Red Hat Enterprise Linux minor release.   As a 
result of this evaluation, Red Hat has tentatively approved inclusion of 
this feature in the next Red Hat Enterprise Linux Update minor release.   
While it is a goal to include this enhancement in the next minor release 
of Red Hat Enterprise Linux, the enhancement is not yet committed for 
inclusion in the next minor release pending the next phase of actual 
code integration and successful Red Hat and partner testing.

Comment 21 Hushan Jia 2010-11-19 10:09:30 UTC
@Broadcom,

Could you test the feature on 5.6 kernels at  http://people.redhat.com/jwilson/el5/? Please add a comment to indicate your test status or results.

Thanks.

Comment 22 IBM Bug Proxy 2010-11-20 12:47:05 UTC
------- Comment From jmtt.com 2010-11-19 21:05 EDT-------
rmach noticed that the India test team had already pounder-tested this driver on an x3200 (elm3a138) with the partner beta drop.

Comment 24 errata-xmlrpc 2011-01-13 21:08:01 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0017.html