Bug 567627 - broken upgrade paths
Summary: broken upgrade paths
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: alsa-lib
Version: 13
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Jaroslav Kysela
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-23 13:39 UTC by Michal Schmidt
Modified: 2010-04-28 01:17 UTC (History)
3 users (show)

Fixed In Version: alsa-lib-1.0.23-1.fc11
Clone Of:
Environment:
Last Closed: 2010-04-25 13:47:34 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Michal Schmidt 2010-02-23 13:39:50 UTC
Description of problem:

alsa-lib has decreasing E-V-R when going from F-11 to F-12 and from F-12 to F-13 at the moment. It seems that the older releases have more fixes.

Either these fixes are needed on the newer branches too in which case they should be added there, or (if they are specific to the older branch) the versioning should have been done according to https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Minor_release_bumps_for_old_branches

In any case the package version in F<n> + F<n>-updates should not be newer than in F<n+1> + F<n+1>-updates.

$ for tag in dist-f11-updates dist-f12-updates dist-f13-updates-testing dist-f14; do koji --quiet latest-pkg $tag alsa-lib; done
alsa-lib-1.0.22-3.fc11                    dist-f11-updates      perex
alsa-lib-1.0.22-2.fc12                    dist-f12-updates      perex
alsa-lib-1.0.22-1.fc13                    dist-f13              perex

Comment 1 Michal Schmidt 2010-03-17 13:43:00 UTC
In other words: Why is alsa-lib-1.0.22-hwparams.patch only in F-12 but not in F-13 and Rawhide? Are people upgrading to F-13 going to see a regression?

Also notice that yesterday FESCo approved a policy for updates which contains the requirement "Packages must not break upgrade path":
http://meetbot.fedoraproject.org/fedora-meeting/2010-03-16/fesco.2010-03-16-19.00.html
https://fedoraproject.org/wiki/UpdatePolicy%28draft%29#notting.27s_Proposal

Comment 2 Gene Snider 2010-04-15 22:05:15 UTC
I've been waiting for this to be resolved for quite a while, now.  Think it should be a blocker?

Gene

Comment 3 Michal Schmidt 2010-04-16 09:40:24 UTC
(In reply to comment #1)
> In other words: Why is alsa-lib-1.0.22-hwparams.patch only in F-12 but not in
> F-13 and Rawhide? Are people upgrading to F-13 going to see a regression?

I took a look at the patch to find out what it's for.
This is my understanding:
 - Fedora 12 was released with alsa-lib-1.0.21.
 - Fedora 12 later received alsa-lib-1.0.22 as an update. The update fixed bugs,
   but it also introduced a regression (bug 553497).
 - The regression was caused by a behaviour change listed in the upstream
   release notes as "PCM - Change the hw_params determination order".
   Upstream suspected the change might cause trouble for some apps,
   so they also introduced the possibility to select the old behaviour
   using the environment variable LIBASOUND_COMPAT.
 - (Just guessing:) Jaroslav decided that bringing this change within a stable
   Fedora release was not a good idea.
 - So he added alsa-lib-1.0.22-hwparams.patch to the F-12 branch.
   It brings back the old behaviour by default and only allows the new behaviour
   to be used if the user explicitly asks for it.
 - (Guessing further:) Jaroslav did not add this patch to F-13 intentionally,
   because the new behaviour is good in general and apps should be just fixed
   to work with it.

So the guideline https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Minor_release_bumps_for_old_branches should have been followed in the F-12 branch.

alsa-lib-1.0.22-hwparams.patch should NOT be forward ported to F-13. Instead, alsa-lib should be rebuilt in F-13 with a release tag increased (to at least "3") and no other changes. This will fix the upgrade path.

Jaroslav,
I can do minor fixes like this if you approve my ("michich") commit access in Fedora pkgdb:
https://admin.fedoraproject.org/pkgdb/acls/name/alsa-lib

Comment 4 Fedora Update System 2010-04-16 11:51:33 UTC
alsa-lib-1.0.23-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/alsa-lib-1.0.23-1.fc12

Comment 5 Fedora Update System 2010-04-16 11:51:38 UTC
alsa-lib-1.0.23-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/alsa-lib-1.0.23-1.fc11

Comment 6 Fedora Update System 2010-04-16 11:51:43 UTC
alsa-lib-1.0.23-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/alsa-lib-1.0.23-1.fc13

Comment 7 Jaroslav Kysela 2010-04-16 11:59:23 UTC
I'm sorry that it took too long to solve this issue, but I though that alsa-lib 1.0.23 release will be available more quickly :-) This problem was minor in my eyes, because the alsa-lib configuration is similar for F11-F13 (except the hwparams patch which affects applications in very specific cases).

Michal, you have ACL rights for alsa-lib now for future. Thanks.

Comment 8 Fedora Update System 2010-04-20 13:14:04 UTC
alsa-lib-1.0.23-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update alsa-lib'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/alsa-lib-1.0.23-1.fc12

Comment 9 Fedora Update System 2010-04-20 13:22:21 UTC
alsa-lib-1.0.23-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update alsa-lib'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/alsa-lib-1.0.23-1.fc13

Comment 10 Fedora Update System 2010-04-20 13:35:26 UTC
alsa-lib-1.0.23-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update alsa-lib'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/alsa-lib-1.0.23-1.fc11

Comment 11 Fedora Update System 2010-04-25 13:47:25 UTC
alsa-lib-1.0.23-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2010-04-28 01:16:31 UTC
alsa-lib-1.0.23-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2010-04-28 01:17:18 UTC
alsa-lib-1.0.23-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.