Spec URL: http://people.redhat.com/huzaifas/gtk-v4l/gtk-v4l.spec
SRPM URL: http://people.redhat.com/huzaifas/gtk-v4l/gtk-v4l-0.1-1.fc12.src.rpm
Description: gtk-v4l is a Video4Linux Web camera control app
Rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2010832
F13 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2010839
rpmlint is silent
I've done a full review and I've found several MUST FIX issues:
-Typo in Summary: Prefernces should be Preferences
-Drop these 2 explicit library dependencies:
Requires: gtk2 >= 2.18
Requires: libv4l >= 0.6
-Since your desktop file does not include a MimeType key there is no reason
to call update-desktop-database
All changed made,
I also replaced:
as per the packaging standard.
New SPEC and srpm in:
(In reply to comment #2)
> All changed made,
All changes made, sorry my morning typing is not so good :)
> I also replaced:
> as per the packaging standard.
> New SPEC and srpm in:
Looks good now: Approved!
One small issue though (but not a blocker). Could you change
the description from:
"gtk-v4l is a Video4Linux Web camera control app"
"gtk-v4l is a Video4Linux device control app"
As this will work for example with tv cards too.
The same goes for the README (to be fixed
in a next release).
Makes sense thanks.
New Package CVS Request
Package Name: gtk-v4l
Short Description: gtk-v4l is a Video4Linux device control app
gtk-v4l-0.1-2.fc13 has been submitted as an update for Fedora 13.
This package already seems to be in the repository.
Am I missing something?
gtk-v4l-0.1-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
su -c 'yum --enablerepo=updates-testing update gtk-v4l'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F13/FEDORA-2010-3071
I'm just going to clear the fedora-cvs flag here. If someone really needs a
CVS operation, please reset it.
I think i did a cvs, but forgot to set the flags, setting them correctly now.
gtk-v4l-0.1-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.