Spec URL: http://dmalcolm.fedorapeople.org/python-packaging/python-squaremap.spec SRPM URL: http://dmalcolm.fedorapeople.org/python-packaging/python-squaremap-1.0.0-0.1.b24.fc12.src.rpm Description: A simple wxPython control to display hierarchic data as a recursive set of nested squares, each of which represents the relative size of a given child within its parent. (used by the RunSnakeRun python profile visualizer, which I'm about to file a review request for also)
Review: Good: - name ok - group ok - BR/R ok - macros everywhere - no *.la - no libs - noarch ok - license ok - builds in mock - source match upstream: cef66530225cc63caaf8b878020b333d Needswork: - $ rpmlint python-squaremap-1.0.0-0.1.b24.fc12.src.rpm noarch/python-squaremap-1.0.0-0.1.b24.fc12.noarch.rpm python-squaremap.src: W: spelling-error Summary(en_US) wxPython -> python, Python, diphthong python-squaremap.src: W: spelling-error %description -l en_US wxPython -> python, Python, diphthong python-squaremap.noarch: W: spelling-error Summary(en_US) wxPython -> python, Python, diphthong python-squaremap.noarch: W: spelling-error %description -l en_US wxPython -> python, Python, diphthong python-squaremap.noarch: W: no-documentation python-squaremap.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/squaremap/squaremap.py 0644 /usr/bin/env 2 packages and 0 specfiles checked; 1 errors, 5 warnings. Spelling error is ignoreable, but you need to remove the shebang, because this file is not intented to run. - no-documentation: There is no LICENSE file. Please query upstream to add one. - You should be more explicit in %files to be notified, when the egg is not build: e.g. %{python_sitelib}/squaremap %{python_sitelib}/Squaremap-*.egg-info __________________________________________________________ This are only minor issues, which I'm sure, you'll fix before importing. __________________________________________________________ APPROVED
One thing I like to add: Group: Development/Libraries would be better...
Thanks. squaremap.py is actually usable as a script, so I gave it executable permissions instead (it's a simple test when run as "main", you can use it to view space used by files in a directory). I've made the other changes you requested; I delete the egg-info during %prep, and updated %files to verify that it got regenerated: * Tue Mar 2 2010 David Malcolm <dmalcolm> - 1.0.0-0.2.b24%{?dist} - fix permissions for squaremap.py - change group to Development/Libraries - delete prebuilt egg-info, and explicitly list egginfo in %%files stanza to ensure it is regenerated during the build I'll email the maintainer about the license.
New Package CVS Request ======================= Package Name: python-squaremap Short Description: SquareMap for wxPython Owners: dmalcolm Branches: F-12 F-13 InitialCC:
CVS done (by process-cvs-requests.py).
Imported into CVS Built into dist-f14 as http://koji.fedoraproject.org/koji/taskinfo?taskID=2031452 Built into dist-f13 as http://koji.fedoraproject.org/koji/taskinfo?taskID=2031452 Build into dist-f12 as http://koji.fedoraproject.org/koji/taskinfo?taskID=2031452 Thanks!
Ooops, copy and paste snafu; three copies of link above are all of the dist-f14 build dist-f13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2031490 dist-f12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2031492 (Though these links are somewhat redundant)
python-squaremap-1.0.0-0.2.b24.fc13,RunSnakeRun-2.0.0-0.4.b4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/python-squaremap-1.0.0-0.2.b24.fc13,RunSnakeRun-2.0.0-0.4.b4.fc13
python-squaremap-1.0.0-0.2.b24.fc13, RunSnakeRun-2.0.0-0.4.b4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.