Bug 568386 - Merge(?) Review: system-config-date
Summary: Merge(?) Review: system-config-date
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nils Philippsen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-25 15:48 UTC by Nils Philippsen
Modified: 2010-02-25 16:44 UTC (History)
5 users (show)

Fixed In Version: system-config-date-1.9.54-1.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-25 16:44:19 UTC
nphilipp: fedora-review+


Attachments (Terms of Use)

Description Nils Philippsen 2010-02-25 15:48:07 UTC
Seems like this one didn't get a review:

Fedora Merge Review: system-config-date

http://cvs.fedora.redhat.com/viewcvs/devel/system-config-nfs/
Initial Owner: nphilipp@redhat.com

Comment 1 Nils Philippsen 2010-02-25 16:22:19 UTC
This was obviously missed in the round of merge reviews when they were done.

The URL is rather this one: http://cvs.fedoraproject.org/viewvc//devel/system-config-date/

Anyway:

- PASSED: rpmlint:

nils@gibraltar:~/devel/fedora-review/system-config-date> rpmlint  system-config-date-1.9.53-1.fc13.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
nils@gibraltar:~/devel/fedora-review/system-config-date> rpmlint  system-config-date-1.9.53-1.fc13.noarch.rpm 
system-config-date.noarch: E: explicit-lib-dependency libselinux-python
system-config-date.noarch: W: obsolete-not-provided timetool
system-config-date.noarch: W: obsolete-not-provided dateconfig
system-config-date.noarch: W: obsolete-not-provided timeconfig
system-config-date.noarch: W: obsolete-not-provided redhat-config-date
system-config-date.noarch: W: no-dependency-on usermode
1 packages and 0 specfiles checked; 1 errors, 5 warnings.

  - libselinux-python is really the python module of libselinux, this error is bogus
  - these obsoletes are really long in the tooth and should go
  - the tool should be converted to using dbus/PolicyKit instead of usermode

- GOOD: the package is named according to the Package Naming Guidelines
- GOOD: the spec file is named correctly
- GOOD: the package is licensed properly, meets Licensing Guidelines
- GOOD: License: field matches actual license
- GOOD: license text included in %doc
- GOOD: spec file written in American English
- GOOD: spec file is legible
- GOOD: sources used to build match upstream
- GOOD: package compiles successfully (numerous times in koji)
- GOOD: all build dependencies listed
- GOOD: spec file handles locales properly
- N/A: doesn't store shared library files
- GOOD: doesn't bundle system libraries
- N/A: package not relocatable
- GOOD: owns all directories it creates or depends on packages that do so
- BAD: A Fedora package must not list a file more than once in the spec file's %files listings:

%{_datadir}/system-config-date
[...]
%{_datadir}/system-config-date/pixmaps/system-config-date.png

- GOOD: file permissions set properly, %defattr present
- GOOD: package has %clean
- GOOD: uses macros consistently
- GOOD: package contains code
- GOOD: large online help is in (already reviewed) system-config-date-docs
- GOOD: %doc doesn't affect runtime
- N/A: no header files
- N/A: no static libs
- N/A: no pkgconfig files
- N/A: no library files
- N/A: no devel package
- GOOD: doesn't contain libtool archives
- GOOD: contains *.desktop file which is installed properly
- GOOD: package doesn't own files already owned by other packages
- GOOD: buildroot is cleaned in %install
- GOOD: all filenames are valid UTF-8

--> duplicate file listing needs to be fixed

Comment 2 Nils Philippsen 2010-02-25 16:33:04 UTC
1.9.54 is building right now with some changes:

(In reply to comment #1)
>   - libselinux-python is really the python module of libselinux, this error is
> bogus

this isn't directly required anymore, the code using it has been moved to slip.util.files

>   - these obsoletes are really long in the tooth and should go

gone

>   - the tool should be converted to using dbus/PolicyKit instead of usermode

I'll do this as time permits.

> - BAD: A Fedora package must not list a file more than once in the spec file's
> %files listings:
> 
> %{_datadir}/system-config-date
> [...]
> %{_datadir}/system-config-date/pixmaps/system-config-date.png

gone

Comment 3 Nils Philippsen 2010-02-25 16:44:19 UTC
system-config-date-1.9.54-1.fc14 is built in Rawhide, approved FWIW.


Note You need to log in before you can comment on or make changes to this bug.