Spec URL: http://fedorapeople.org/~sgallagh/ldb/libldb.spec SRPM URL: http://fedorapeople.org/~sgallagh/ldb/libldb-0.9.6-21.fc12.src.rpm Description: An extensible library that implements an LDAP like API to access remote LDAP servers, or use local tdb databases. Additional information: the LDB is currently available in Fedora, however it is built as a subpackage of the samba4 SRPM. This new package request extracts the sources necessary to build the LDB on its own, so we do not need to carry in the entirety of samba4. This package is a dependency for the SSSD, which will be packaged for EPEL5 soon.
Simo alerted me that there was a newer upstream version of libldb available. Better to work from that. Spec URL: http://fedorapeople.org/~sgallagh/ldb/libldb.spec SRPM URL: http://fedorapeople.org/~sgallagh/ldb/libldb-0.9.10-23.fc12.src.rpm It has been scratch-built in Koji successfully: http://koji.fedoraproject.org/koji/taskinfo?taskID=2014396
rpmlint output $ rpmlint libldb.spec libldb.spec: W: invalid-url Source0: libldb-0.9.10.tar.gz 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
Looks like the prepping of the %install step does not conform to guidelines: http://fedoraproject.org/wiki/Packaging/Guidelines Removal of the build root is absent (required for EPEL, not required for Fedora > 10 %{buildroot} should be preferred to $RPM_BUILD_ROOT so that variables are used consistently throughout the spec file. The rest looks good to me.
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability) the devel package seem to be failing this rule.
Buildroot, %install and pkgconfig concerns have been addressed. Spec URL: http://fedorapeople.org/~sgallagh/ldb/libldb.spec SRPM URL: http://fedorapeople.org/~sgallagh/ldb/libldb-0.9.10-24.fc12.src.rpm It has been scratch-built in Koji successfully: http://koji.fedoraproject.org/koji/taskinfo?taskID=2014517
(In reply to comment #4) > MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for > directory ownership and usability) > > the devel package seem to be failing this rule. To be fair, RPM's been inserting this automatically since F10.
(In reply to comment #6) > (In reply to comment #4) > > MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for > > directory ownership and usability) > > > > the devel package seem to be failing this rule. > > To be fair, RPM's been inserting this automatically since F10. Sorry, docs still say it is required so I simply applied the rule :)
forgot to set review flag, doing now
package looks good.
New Package CVS Request ======================= Package Name: libldb Short Description: A schema-less, ldap like, API and database Owners: sgallagh Branches: EL-5 InitialCC: Special requests: this package requires an EL-5 buildroot override to include libtalloc, libdtdb and libtevent (all of which are currently still in EL-5 updates-testing)
CVS done (by process-cvs-requests.py). Please remember to dead.package and follow the end of life procedure if you don't want to ever build this on devel. For the overrides, please file a rel-eng trac ticket with what you need in the override. Make sure to use the EPEL component.
Package Change Request ====================== Package Name: libldb New Branches: devel Owners: sgallagh, simo InitialCC: ssorce This package currently exists only as a backport for EL5, because it was previously carried as a subpackage of Samba. Upstream is now releasing this library independently, so we'd like to get it into rawhide. Rawhide was dead.packaged, retired and orphaned previously.
I think that needs to go through a fresh package review.