Bug 568587 - repo-font-audit reports some errors on WenQuanYi ZenHei font.
Summary: repo-font-audit reports some errors on WenQuanYi ZenHei font.
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Fedora
Classification: Fedora
Component: wqy-zenhei-fonts
Version: 13
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Peng Wu
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-26 04:45 UTC by Peng Wu
Modified: 2010-07-22 05:58 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-07-22 05:58:32 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Warning when the user run this script with non-root. (562 bytes, patch)
2010-03-01 07:21 UTC, Peng Wu
no flags Details | Diff

Description Peng Wu 2010-02-26 04:45:16 UTC
repo-font-audit is a tool to check whether a font package for Fedora complies with Packaging:FontsPolicy.(Url:http://fedoraproject.org/wiki/Packaging:FontsPolicy)

After doing this check, it reports the error that the zenheiset script has wrong permission set(744).
And it also reports that the zenheiset script should not be in wqy-zenhei-fonts. From the FontsPolicy, the script should be put in wqy-zenhei-fonts-common.

There are two candidates solution:
1. remove the zenheiset script from wqy-zenhei-fonts package.
2. keep the zenheiset script in wqy-zenhei-fonts-common, following the steps below:
   a. mv the zenheiset script and docs files to wqy-zenhei-fonts-common (README, COPYING etc.)
   b. correct the zenheiset script permission to 0755 or other possible permission.
Which solution do you prefer?

Maybe we can discuss it on irc.(#fedora-meeting, freenode.)
After discussing, I will modify the zenhei and microhei package to comply with the FontPolicy.

Comment 1 Peng Wu 2010-02-26 04:45:57 UTC
Here are the steps about how to use the repo-font-audit tool:
1. installing createrepo and fontpackages-tools:
# yum install createrepo fontpackages-tools
2. putting your packages and any font package they depends on in a
   test directory
3. indexing this directory with createrepo:
$ createrepo path-to-test-directory
4. running repo-font-audit:
$ repo-font-audit test absolute-path-to-test-directory

Comment 2 Peng Wu 2010-02-26 04:56:11 UTC
repo-font-audit tool will report 2 error and 2 warning:
1. Error: zenheiset script has unusual file permission.
2. Error: zenheiset should not in wqy-zenhei-fonts.noarch.rpm.
Above is the packager tasks, I will handle this after discussion.
3. Warning: can't pass fontlint check on wqy-zenhei.ttc.
4. Warning: fonts with partial script coverage.
Above is the upstream task, Warning 4 is ignorable I guess.
For warning 3, could be checked with fontlint in FontForge, and need to be reported to wenquanyi upstream.

Comment 3 Peng Wu 2010-02-26 05:12:30 UTC
>Maybe we can discuss it on irc.(#fedora-meeting, freenode.)
Sorry, forget to put my nickname: epico or epico_laptop.

Comment 4 Peng Wu 2010-03-01 07:21:08 UTC
Created attachment 396971 [details]
Warning when the user run this script with non-root.

Comment 5 Peng Wu 2010-03-01 08:11:25 UTC
Move the zenheiset script to docdir, and change permission to 0755 because of rpmlint.

And according the FontsPolicy, zenheiset is moved in a seperate wqy-zenhei-fonts-common packages with docs together.

Commit changes to devel and F-13, as F-13 Alpha is coming.

Comment 6 Qianqian Fang 2010-03-04 15:51:07 UTC
strange, I somehow did not get these emails. I am glad that you have fixed the script permission issues. thanks

for the fontlint warnings, it is a very minor issue. I will try to fix it in the next release (coming soon). I will let you know when it is ready.

Comment 7 Peng Wu 2010-03-05 02:05:37 UTC
welcome

Comment 8 Peng Wu 2010-07-22 05:58:32 UTC
Close bug, as this is a minor issue.


Note You need to log in before you can comment on or make changes to this bug.