Bug 568924 - don't run brp-strip-comment-note after find-debuginfo.sh
Summary: don't run brp-strip-comment-note after find-debuginfo.sh
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: redhat-rpm-config
Version: 13
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Panu Matilainen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-26 22:46 UTC by Roland McGrath
Modified: 2010-03-05 03:36 UTC (History)
3 users (show)

Fixed In Version: redhat-rpm-config-9.1.0-4.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-05 03:36:58 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
patch to redhat/macros (729 bytes, patch)
2010-02-26 22:46 UTC, Roland McGrath
no flags Details | Diff
patch to redhat/macros (728 bytes, patch)
2010-02-27 01:03 UTC, Roland McGrath
no flags Details | Diff

Description Roland McGrath 2010-02-26 22:46:32 UTC
Created attachment 396696 [details]
patch to redhat/macros

Description of problem:

Running brp-strip-comment-note is useless after running find-debuginfo.sh.  It already strips out what should be stripped.  In theory this is just superfluous.  But in fact, it is doing harm now due to bug 568921.

Version-Release number of selected component (if applicable):
redhat-rpm-config-9.1.0-3.fc13.noarch

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

The attached patch changes %__os_install_post not to use brp-strip-comment-note if building a debug package, just as we don't use brp-strip.  It is not strictly minimal because it reverses the order of brp-strip-comment-note vs brp-strip-static-archive so as to use a single conditional expression.  But those scripts operate on disjoint sets of files, so it should make no difference (and this order never mattered as far as we know anyway).

Comment 1 Roland McGrath 2010-02-27 01:03:29 UTC
Created attachment 396708 [details]
patch to redhat/macros

This time without the typo.

Comment 2 Fedora Update System 2010-03-01 09:17:53 UTC
redhat-rpm-config-9.1.0-4.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/redhat-rpm-config-9.1.0-4.fc13

Comment 3 Panu Matilainen 2010-03-01 09:19:31 UTC
Also applied + built for rawhide. Oh and thanks for the patch.

Comment 4 Fedora Update System 2010-03-02 00:51:09 UTC
redhat-rpm-config-9.1.0-4.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update redhat-rpm-config'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F13/FEDORA-2010-3189

Comment 5 Fedora Update System 2010-03-05 03:36:54 UTC
redhat-rpm-config-9.1.0-4.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.