Bug 569610 - GFS2 - fiemap - Kernel BUG at fs/gfs2/bmap.c:433 [rhel-5.5]
Summary: GFS2 - fiemap - Kernel BUG at fs/gfs2/bmap.c:433 [rhel-5.5]
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.5
Hardware: All
OS: Linux
urgent
high
Target Milestone: rc
: ---
Assignee: Abhijith Das
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On: 526947
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-03-01 20:31 UTC by Abhijith Das
Modified: 2010-04-01 04:36 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-30 06:49:15 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2010:0178 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.5 kernel security and bug fix update 2010-03-29 12:18:21 UTC

Comment 2 Steve Whitehouse 2010-03-02 14:23:44 UTC
The question is whether it is unreasonable for a fs to accept block map requests which are non-block-sized/aligned?

The fiemap interface is the only one which sends such requests to the block map function (via __generic_block_fiemap) so should we fix the problem in __generic_block_fiemap, or in the individual filesystem block map functions?

So basically I want to clarify the interface at block map level.

Comment 3 Ric Wheeler 2010-03-02 14:42:17 UTC
It should never be possible for an invalid request to cause a panic.

Comment 4 RHEL Program Management 2010-03-02 15:17:01 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 5 Eric Sandeen 2010-03-02 15:25:28 UTC
FWIW, I tested ext2/3/4 and xfs and they all are fine with this testcase (xfs doesn't go the generic route anyway, nor does ext4 for extent-based files).

Comment 7 Robert Peterson 2010-03-02 19:02:10 UTC
The patch from comment #6 looks good to me.

Comment 9 Abhijith Das 2010-03-03 16:04:58 UTC
Posted the above patch to rhkernel-list.

Comment 11 Jarod Wilson 2010-03-10 17:02:20 UTC
in kernel-2.6.18-192.el5
You can download this test kernel from http://people.redhat.com/jwilson/el5

Please update the appropriate value in the Verified field
(cf_verified) to indicate this fix has been successfully
verified. Include a comment with verification details.

Comment 15 errata-xmlrpc 2010-03-30 06:49:15 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0178.html


Note You need to log in before you can comment on or make changes to this bug.