Bug 570353 - Clash of short-cuts
Summary: Clash of short-cuts
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-users
Version: 14
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Nils Philippsen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-03-04 00:01 UTC by ray hammond
Modified: 2012-08-16 22:09 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-16 22:09:57 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Path for bug report. (1.06 KB, patch)
2010-03-04 00:06 UTC, ray hammond
no flags Details | Diff
Patch to re-map short-cut. (346 bytes, patch)
2010-03-22 21:48 UTC, ray hammond
no flags Details | Diff

Description ray hammond 2010-03-04 00:01:45 UTC
Description of problem:
The short-cut keys for the "Password" label and "Password Info" tab (Alt+P), and the "Confirm Password" and "OK" button clash (Alt+O).

Version-Release number of selected component (if applicable):
1.2.94-1.fc12

How reproducible:
Every-time

Steps to Reproduce:
1.Open system-config-users.
2.Select properties for any of the users.
3.Try Alt+P or Alt+O
  
Actual results:
The cursor move between the fields.

Expected results:
Alt+O for example should activate Cancel and close the form.  It the short-cut for cancel was unique it would activate the cancel routine, rather than just moving the focus.

Additional info:

Comment 1 ray hammond 2010-03-04 00:06:26 UTC
Created attachment 397687 [details]
Path for bug report.

Hopefully, this pacth will sort the problem.  First time I've submitted a patch, thus, I apologies if it doesn't work.

Comment 2 Nils Philippsen 2010-03-04 09:06:43 UTC
The patch is reversed ;-), you need to do "diff ... <old, broken file> <new, fixed file>" to get it right. If you're familiar with git, you can also just clone the repository, apply fixes in your private branches and let "git format-patch" do the work for you. Find the repository browser (with repository URLs etc) at http://git.fedorahosted.org/git/?p=system-config-users.git

Anyway, thanks for the report, I've committed other shortcuts than in your patch ("W" for "Password", "F" for "Confirm ..." -- I think they feel more "natural", as their respective second syllables begin with these) in git commit e87c332187273a66cc65f63dc76627a1f69d415d.

Comment 3 ray hammond 2010-03-22 21:48:11 UTC
Created attachment 401873 [details]
Patch to re-map short-cut.

Hi Nils,

I have re-issued a patch as I noticed that the short-cut you selected (F) now classes with the "Full Name" label.  And, we missed the same clash of short-cuts within the "New User" page.  I've assigned (M) to both.

Thanks for the advice on git; I managed to clone the repo, but, I could not work-out the patch command.  More reading required.

Rgs

Ray

Comment 4 Fedora Update System 2010-03-23 16:30:34 UTC
system-config-users-1.2.95-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/system-config-users-1.2.95-1.fc13

Comment 6 Fedora Update System 2010-04-21 02:24:15 UTC
system-config-users-1.2.96-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Bug Zapper 2010-07-30 10:58:10 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 14 development cycle.
Changing version to '14'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 8 Fedora End Of Life 2012-08-16 22:09:59 UTC
This message is a notice that Fedora 14 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 14. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained.  At this time, all open bugs with a Fedora 'version'
of '14' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this 
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen 
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we were unable to fix it before Fedora 14 reached end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" (top right of this page) and open it against that 
version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping


Note You need to log in before you can comment on or make changes to this bug.