Bug 570810 - Review Request: rubygem-net-dns - Pure Ruby DNS library
Summary: Review Request: rubygem-net-dns - Pure Ruby DNS library
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-03-05 13:50 UTC by Jakub Hrozek
Modified: 2010-05-12 15:34 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-05-12 15:34:07 UTC
Type: ---
Embargoed:
mtasaka: fedora-review?


Attachments (Terms of Use)

Description Jakub Hrozek 2010-03-05 13:50:32 UTC
Spec URL: http://fedorapeople.org/~jhrozek/rubygem-net-dns/rubygem-net-dns.spec

SRPM URL: http://fedorapeople.org/~jhrozek/rubygem-net-dns/rubygem-net-dns-0.6.1-1.fc12.src.rpm

Description:
Net::DNS is a pure Ruby DNS library, with a clean OO interface and an
extensible API

Comment 1 Mamoru TASAKA 2010-04-05 18:32:00 UTC
Some notes:

* Unused / defined macros
  - %ruby_sitelib seems to be used nowhere
  - As %geminstdir is defined, please use this macro in %files
    when applicable.

* %define -> %global
  - We now prefer to use %global instead of %define
    https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

* License
  - When the software says "This is distributed under the same license Ruby is",
    the license tag on Fedora should be "GPLv2 or Ruby"

* (Build)Requires
  - "Requires: rubygem(rcov)" is not needed.
---------------------------------------------------
BuildRequires:  rubygems
Requires: rubygems
Requires:       ruby(rubygems)
---------------------------------------------------
  - Please use one style for (Build)Requires: rubygems

* Duplicate %files entry
---------------------------------------------------
    57  Processing files: rubygem-net-dns-0.6.1-1.fc13.noarch
    58  warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/net-dns-0.6.1/AUTHORS.rdoc
    59  warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/net-dns-0.6.1/CHANGELOG.rdoc
    60  warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/net-dns-0.6.1/README.rdoc
    61  warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/net-dns-0.6.1/THANKS.rdoc
---------------------------------------------------
  - Please make it sure that every directory / file is listed only
    once.


* %check
  - As this gem contains test/ directory, please add %check section and
    execute some test programs there.

Comment 2 Mamoru TASAKA 2010-04-16 17:09:22 UTC
ping?

Comment 3 Mamoru TASAKA 2010-04-23 16:21:13 UTC
ping again?

Comment 4 Mamoru TASAKA 2010-05-03 17:24:07 UTC
I will close this bug as NOTABUG if you response from the reporter
is received within ONE WEEK.

Comment 5 Mamoru TASAKA 2010-05-12 15:34:07 UTC
Once closing.

If someone wants to import this package into Fedora, please
file a new bug report and mark this bug as a duplicate of the
new one, thank you.


Note You need to log in before you can comment on or make changes to this bug.