Bug 570880

Jing, let us know your game plan for RHEL 5.6...

*** Bug 561993 has been marked as a duplicate of this bug. ***

Created attachment 408760 [details]
update bfa driver to 2.1.2.2

bfa 2.1.2.2 is backported from the current upstream scsi-misc driver. It also includes the fix for powerpc compilation issue reported from linux-next. the patches has been submmitted to linux-scsi but hasn't been included in scsi-misc (it has been pulled into the -mm tree a few days ago).

*** Bug 603118 has been marked as a duplicate of this bug. ***

Jing/Rob, please make sure the following patch is included:

Fixed upstream in commit 7873ca4e4401f0ecd8868bf1543113467e6bae61:
commit 7873ca4e4401f0ecd8868bf1543113467e6bae61
Author: Krishna Gudipati <kgudipat>
Date:   Fri May 21 14:39:45 2010 -0700

    [SCSI] bfa: fix system crash when reading sysfs fc_host statistics

    The port data structure related to fc_host statistics collection is
    not initialized. This causes system crash when reading the fc_host
    statistics. The fix is to initialize port structure during driver
    attach.

    Signed-off-by: Krishna Gudipati <kgudipat>
    Signed-off-by: James Bottomley <James.Bottomley>

*** Bug 568827 has been marked as a duplicate of this bug. ***

Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.

New Contents:
bfa driver stays on Tech Preview list.

------- Comment From mknutson.com 2010-08-04 07:53 EDT-------
Andrius, Jing,  We previously understood that the BFA is not tech preview (it has been in the 5.x code for a while), but that the BNA portion of the CNA technology would be tech preview.  Is the BFA driver now being downgraded?   Thanks.  Monte

(In reply to comment #9)
> ------- Comment From mknutson.com 2010-08-04 07:53 EDT-------
> Andrius, Jing,  We previously understood that the BFA is not tech preview (it
> has been in the 5.x code for a while), but that the BNA portion of the CNA
> technology would be tech preview.  Is the BFA driver now being downgraded?  
> Thanks.  Monte    

bfa was Tech Preview in 5.5, and will remain Tech Preview in RHEL 5.x until upstream and RH concerns are addressed upstream by Brocade. I don't see how bfa can be "downgraded" when it was never fully supported.

Recall:
http://www.redhat.com/docs/en-US/Red_Hat_Enterprise_Linux/5.5/html/Technical_Notes/chap-Technical_Notes-_Technology_Previews_.html

As for bna - this isn't upstream yet, so this isn't under consideration for any RHEL release until this happens.

Created attachment 438865 [details]
Brocade BFA 2.2.2.1 update patch.

This is Brocade BFA driver 2.2.2.1 latest upstream back ported patch for Redhat 5.6 Inbox inclusion. The patch also updates the firmware image to version 2.2.

This patch doesn't compile and cannot be accepted as a result:

drivers/scsi/bfa/bfad.c:985: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'u64'
make[3]: *** [drivers/scsi/bfa/bfad.o] Error 1

Additional feedback:

This patch contains updates to bfa abstractions.  These abstractions need to be expunged from the driver in the pending upstream cleanup.

The upstream cleanup should minimally address:

- the bfa (and other aliases) abstractions that pervade the driver as mentioned 
  above
- the 100+ file include directory needs to be flattened and condensed with
  all the other header files in the top level bfa directory
- unused code needs to be purged
- duplication of protocol definition already provided by linux needs to be 
  removed.

Other feedback that results from the cleanup effort needs to be incorporated as well.

There is no description of what this patch contains and it is not really reviewable in terms of its content.

All the white space changes should be either in there own patch, or in separate patches since they make reviewing real content more difficult.

Going forward, please provide patches that are bisectable.  An acceptable form is a tar file containing a set of patches and a quilt series file.  Each patch should have prepended to it:

- an upstream commit id link
- a 'subject: one-line-description'
- a description that matches the upstream commit

Red Hat is open to other forms of bisectable patches as well but the form should be discussed before being provided.

There is no mention of what testing was done and against what rhel5 code base.  

Please incorporate such feedback in subsequent updates.

Leaving bz open for subsequent updates

Development Management has reviewed and declined this request.  You may appeal
this decision by reopening this request.

------- Comment From mknutson.com 2010-10-18 10:42 EDT-------
please reopen. escalate to include in 5.6

(In reply to comment #17)
> ------- Comment From mknutson.com 2010-10-18 10:42 EDT-------
> please reopen. escalate to include in 5.6

This patch contains updates to bfa abstractions.  These abstractions need to be
expunged from the driver in the pending upstream cleanup before being considered for RHEL.