Created attachment 398534 [details]
Proposed patch

Description of problem:
  strace incorrectly shows the arguments of fadvise() in
  32 bit compat programs

Version-Release number of selected component (if applicable):
  strace-4.5.19-1.fc12.x86_64

How reproducible: Always


Steps to Reproduce:
1. Find a program that calls posix_fadvise(2).  My sample program calls
   posix_fadvise(2) like this:

        posix_fadvise(fd, 0, 0, POSIX_FADV_RANDOM);
        posix_fadvise(fd, 5, 7, POSIX_FADV_SEQUENTIAL);
        posix_fadvise64(fd, 0, 0, POSIX_FADV_RANDOM);
        posix_fadvise64(fd, 5, 7, POSIX_FADV_SEQUENTIAL);

   (The second and third arguments are only to illustrate the problem, they
    don't actually have any useful meaning.)

2. Compile it as a 32 bit application
3. Run under strace.
  
Actual results:
  fadvise64(3, 0, 0, POSIX_FADV_NORMAL)   = 0
  fadvise64(3, 5, 0, 0x7 /* POSIX_FADV_??? */) = 0
  fadvise64_64(3, 0, 0, POSIX_FADV_NORMAL) = 0
  fadvise64_64(3, 5, 0, 0x7 /* POSIX_FADV_??? */) = 0

Expected results:
  fadvise64(3, 0, 0, POSIX_FADV_RANDOM)   = 0
  fadvise64(3, 5, 7, POSIX_FADV_SEQUENTIAL) = 0
  fadvise64_64(3, 0, 0, POSIX_FADV_RANDOM) = 0
  fadvise64_64(3, 5, 7, POSIX_FADV_SEQUENTIAL) = 0


Additional info:
  The attached patch fixes this problem, it is based on:

    commit b5600fc3df0453ba11f254a9b49add3ffbec9733
    Author: Andreas Schwab <schwab>
    Date:   Wed Nov 4 17:08:34 2009 +0100

  (The changes are merely needed to make it apply cleanly.)