Bug 571520 - TIFF problems: crash on fail; changed MaxStripSize
Summary: TIFF problems: crash on fail; changed MaxStripSize
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: ghostscript
Version: 12
Hardware: x86_64
OS: Linux
low
medium
Target Milestone: ---
Assignee: Tim Waugh
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:e77d5b4daa1f2d80f1327b19016...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-03-08 18:24 UTC by Jim Shipman
Modified: 2010-04-20 13:28 UTC (History)
2 users (show)

Fixed In Version: ghostscript-8.71-6.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-04-13 01:55:59 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (5.58 KB, text/plain)
2010-03-08 18:24 UTC, Jim Shipman
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Ghostscript 691171 0 None None None Never
Ghostscript 691174 0 None None None Never

Description Jim Shipman 2010-03-08 18:24:08 UTC
abrt 1.0.7 detected a crash.

architecture: x86_64
Attached file: backtrace
cmdline: gs -q -sDEVICE=tiffg3 -r204x196 -dNOPAUSE -dSAFER -sOutputFile=image-0001.pnm.%03d -sPAPERSIZE=letter image-0001.pnm
comment: I was sending a pdf file as a fax using efax-gtk.
component: ghostscript
executable: /usr/bin/gs
kernel: 2.6.32.9-67.fc12.x86_64
package: ghostscript-8.71-4.fc12
rating: 4
reason: Process /usr/bin/gs was killed by signal 11 (SIGSEGV)
release: Fedora release 12 (Constantine)

Comment 1 Jim Shipman 2010-03-08 18:24:09 UTC
Created attachment 398577 [details]
File: backtrace

Comment 2 Tim Waugh 2010-03-12 13:11:13 UTC
The tiffg3 ghostscript device is missing a NULL check before calling TIFFCleanup().  However, this means that something else went wrong first.

I've built a ghostscript package fixing this segfault.  Could you please try it and tell me if/how it fails now?  Thanks.

http://koji.fedoraproject.org/koji/buildinfo?buildID=161482

Comment 3 Arne Woerner 2010-03-12 23:12:35 UTC
hylafax still (i installed ghostscript.x86_64 8.71-4.1.fc12) doesn't work... -arne

Comment 4 Tim Waugh 2010-03-13 11:12:45 UTC
I expected it not to work, but could you please provide some information on exactly *how* it fails?  Do you get an error message, is the fax image incorrect, is a fax sent at all, are there error logs somewhere, can you get debugging information out of it, etc?

Comment 5 Arne Woerner 2010-03-13 11:28:04 UTC
hylafax acts as if it sent everything correctly, although there were just 5 frames per page (that is for the tag line, i guess)...

the kernel did not even log a segfault, also it seems to do it (at least when npviewer.bin segfault-s)...

-arne

Comment 6 Arne Woerner 2010-03-13 14:45:35 UTC
i am quite sure that ghostscript causes the problem, because:

when i do this:
gs -sPaperSize=A4 -dBATCH -dNOPAUSE -sOutputFile=bla.tif -sDEVICE=tiffg3 ~/deploy/docs/...
(without any problem or error)
and then this:
tiffcp -c g3:1d:fill -r 10000 bla.tif blah.tif
and then this:
sendfax -n -G -d "+49 30 ..." blah.tif
everything behaves like before... *wag tail*

-arne

Comment 7 Arne Woerner 2010-03-13 15:45:58 UTC
i hacked hylafax' bin/pdf2fax.gs script...

this is the command that hylafax uses:
/usr/bin/gs -q -sDEVICE=tiffg4 -dNOPAUSE -dSAFER=true -sPAPERSIZE=a4 -dFIXEDMEDIA -dBATCH -r209.10x196 -sOutputFile=docq/doc68.pdf;c1 docq/doc68.pdf.62

the resulting file looks good...

when i force the bin/pdf2fax.gs script to use tiffg3 as -sDEVICE, then everything works fine again...

so the tiffg4 device does something nasty/modern/unexpected possibly?

-arne

Comment 8 Jim Shipman 2010-03-13 18:38:25 UTC
These problems for me happened after I updated my Fedora 12 system.  efax-gtk broke causing the problems on my system.  I rebuilt efax-gtk adding "parms.push_back("-dMaxStripSize=0");" at line 304 in efax-gtk-3.0.20/src/efax_controller.cpp.  Everything now works fine on my system.
Jim Shipman

Comment 9 Arne Woerner 2010-03-13 19:49:06 UTC
*w00t*

that "-dMaxStripSize=0"-trick works for the bin/pdf2fax.gs script (in that call in the end of the script), too...

-arne

Comment 10 Tim Waugh 2010-03-15 17:32:58 UTC
The default MaxStripSize had changed from 0 in ghostscirpt-8.70 to 8192 in ghostscript-8.71.

I've set it back to 0 in ghostscript-8.71-5.fc12.  Could you give it a go please, without the pdf2fax.gs/efax-gtk changes?

http://koji.fedoraproject.org/koji/buildinfo?buildID=161952

Comment 11 Arne Woerner 2010-03-15 18:39:27 UTC
i just sent a fax with my unpatched hylafax and the amd64 package from
http://koji.fedoraproject.org/koji/buildinfo?buildID=161952
and
hylafax sent 46 frames for one page,
which is much more than just the tagline...

looks good to me...

-arne

Comment 12 Fedora Update System 2010-03-16 15:38:58 UTC
ghostscript-8.71-6.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/ghostscript-8.71-6.fc11

Comment 13 Fedora Update System 2010-03-16 15:40:07 UTC
ghostscript-8.71-6.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/ghostscript-8.71-6.fc12

Comment 14 Fedora Update System 2010-03-16 15:41:39 UTC
ghostscript-8.71-9.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/ghostscript-8.71-9.fc13

Comment 15 Tim Waugh 2010-03-16 15:44:34 UTC
The upstream fix was to change it to 1Mb so in ghostscript-8.71-6.fc12 I've switch to that.  Could you please re-test just to make sure?

Comment 16 Arne Woerner 2010-03-16 17:52:44 UTC
but what if, that size increases to more than 1Mb?

will there be again silent empty pages?

or is it impossible to make a tiff file of that size and that resolution?

-arne

Comment 17 Tim Waugh 2010-03-16 18:20:19 UTC
No single TIFF page can be more than that size, and there is one strip per page.

Comment 18 Fedora Update System 2010-03-18 03:18:29 UTC
ghostscript-8.71-6.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update ghostscript'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ghostscript-8.71-6.fc12

Comment 19 Fedora Update System 2010-03-18 03:31:20 UTC
ghostscript-8.71-6.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update ghostscript'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ghostscript-8.71-6.fc11

Comment 20 Fedora Update System 2010-03-24 23:39:52 UTC
ghostscript-8.71-9.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 21 Fedora Update System 2010-04-13 01:55:41 UTC
ghostscript-8.71-6.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 22 Fedora Update System 2010-04-20 13:28:28 UTC
ghostscript-8.71-6.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.