Bug 571658 - gnome-color-manager should explicitly require cups
Summary: gnome-color-manager should explicitly require cups
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-color-manager
Version: 13
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Richard Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: FedoraMini, Mobility
TreeView+ depends on / blocked
 
Reported: 2010-03-09 07:32 UTC by Peter Robinson
Modified: 2010-03-09 09:03 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2010-03-09 09:03:32 UTC


Attachments (Terms of Use)

Description Peter Robinson 2010-03-09 07:32:22 UTC
gnome-colour-manager requires cups which pulls in a lot of dependencies. This causes massive dep issues. Printing is only one place where color setup of devices would be useful and where printers would never be used such as media centres and Moblin devices where printing isn't supported.

Also the spec file is using Requires against the packaging guidelines "RPM has very good capabilities of automatically finding dependencies for libraries and eg. Perl modules. In short, don't reinvent the wheel, but just let rpm do its job. There is usually no need to explicitly list eg. Requires: libX11 when the dependency has already been picked up by rpm in the form of depending on libraries in the libX11 package. "

https://fedoraproject.org/wiki/Packaging/Guidelines#Requires

All of these dependencies should be calculated by the rpm build system automatic requires and shouldn't need to be listed explicitly. 

Requires:  gtk2 >= %{gtk2_version}
Requires:  unique >= %{unique_version}
Requires:  dbus-glib >= %{dbus_glib_version}
Requires:  dbus-x11
Requires:  udev
Requires:  vte
Requires:  lcms
Requires:  cups
Requires:  polkit
Requires:  PackageKit
Requires:  libcanberra >= %{libcanberra_version}

In the case of cups the dep of 'cups-libs' should be enough and is what most gnome printing related packages pull in.

Comment 1 Richard Hughes 2010-03-09 09:03:32 UTC
* Tue Mar 09 2010 Richard Hughes <richard@hughsie.com> 2.29.4-2
- Update to the latest version of the Fedora Packaging Guidelines
- Remove the custom BuildRoot
- Do not clean the buildroot before install
- Use the gconf_schema defines for the GConf schemas
- Remove some over-zealous Requires that are already picked up by rpm.
- Resolves #571658


Note You need to log in before you can comment on or make changes to this bug.