Created attachment 398855 [details] diff for a bunch of changes to langpacks Description of problem: This patch does: 1. Moves print's => yum logger uses. 2. Moves tsinfo ops. to real install/remove ops. This means deps. will be solved, among other things. 3. Handles erase properly. 4. Doesn't force upgrade langpacks on upgrades/downgrades/etc. 5. Doesn't try to install multiple versions of langpacks. 6. Move from d.has_key(v) to "v in d", as py3 removes the former. ...completely untested both before and after changes. Version-Release number of selected component (if applicable): % make verrel yum-langpacks-0.1.4-2.fc13
I applied this patch (applied cleanly), and when I ran "yum upgrade" after the dependencies was calculated, I got the following: Traceback (most recent call last): File "/usr/bin/yum", line 29, in <module> yummain.user_main(sys.argv[1:], exit_code=True) File "/usr/share/yum-cli/yummain.py", line 254, in user_main errcode = main(args) File "/usr/share/yum-cli/yummain.py", line 150, in main (result, resultmsgs) = base.buildTransaction() File "/usr/lib/python2.6/site-packages/yum/__init__.py", line 875, in buildTransaction self.plugins.run('postresolve', rescode=rescode, restring=restring) File "/usr/lib/python2.6/site-packages/yum/plugins.py", line 177, in run func(conduitcls(self, self.base, conf, **kwargs)) File "/usr/lib/yum-plugins/langpacks.py", line 98, in postresolve_hook add_deps_to_ts(conduit, po) File "/usr/lib/yum-plugins/langpacks.py", line 77, in add_deps_to_ts if yb.tsinfo.matchNaevr(name=pkg.name): AttributeError: 'YumBaseCli' object has no attribute 'tsinfo'
Funny, I was just about to post the same backtrace...
In that line: if yb.tsinfo.matchNaevr(name=pkg.name): change it to be if yb.tsInfo.matchNaevr(name=pkg.name): and try it again, please
(In reply to comment #3) > In that line: > > if yb.tsinfo.matchNaevr(name=pkg.name): > > change it to be > > if yb.tsInfo.matchNaevr(name=pkg.name): > > > and try it again, please Now it looks like this: Traceback (most recent call last): File "/usr/bin/yum", line 29, in <module> yummain.user_main(sys.argv[1:], exit_code=True) File "/usr/share/yum-cli/yummain.py", line 254, in user_main errcode = main(args) File "/usr/share/yum-cli/yummain.py", line 150, in main (result, resultmsgs) = base.buildTransaction() File "/usr/lib/python2.6/site-packages/yum/__init__.py", line 875, in buildTransaction self.plugins.run('postresolve', rescode=rescode, restring=restring) File "/usr/lib/python2.6/site-packages/yum/plugins.py", line 177, in run func(conduitcls(self, self.base, conf, **kwargs)) File "/usr/lib/yum-plugins/langpacks.py", line 100, in postresolve_hook remove_deps_from_ts(conduit, po) File "/usr/lib/yum-plugins/langpacks.py", line 90, in remove_deps_from_ts for pkg in yb.rpmdb.returnPackages(patterns=[pkgmatches]): File "/usr/lib/python2.6/site-packages/yum/rpmsack.py", line 432, in returnPackages pkgobjlist = parsePackages(pkgobjlist, patterns, not ignore_case) File "/usr/lib/python2.6/site-packages/yum/packages.py", line 115, in parsePackages if command in pkgdict: TypeError: unhashable type: 'list'
Bah, that (line 90) should be: for pkg in yb.rpmdb.returnPackages(patterns=pkgmatches):
(In reply to comment #5) > Bah, that (line 90) should be: > > for pkg in yb.rpmdb.returnPackages(patterns=pkgmatches): Now it passes the dependency checks. Currently waiting for yum to download all updates so I can check if it also installs.
Thanks, Guys Do we even need remove_deps_from_ts ? I guess normally langpacks would get removed anyway when their dependent packages are. When I do an upgrade in current Live, yum shows ================================================================================================= Package Arch Version Repository Size ================================================================================================= Updating: : openoffice.org-core i686 1:3.2.0-12.13.fc13 updates-testing 80 M openoffice.org-draw i686 1:3.2.0-12.13.fc13 updates-testing 144 k openoffice.org-draw-core i686 1:3.2.0-12.13.fc13 updates-testing 783 k openoffice.org-graphicfilter i686 1:3.2.0-12.13.fc13 updates-testing 312 k openoffice.org-impress i686 1:3.2.0-12.13.fc13 updates-testing 146 k openoffice.org-impress-core i686 1:3.2.0-12.13.fc13 updates-testing 1.1 M openoffice.org-langpack-en i686 1:3.2.0-12.13.fc13 updates-testing 130 k openoffice.org-math i686 1:3.2.0-12.13.fc13 updates-testing 138 k openoffice.org-math-core i686 1:3.2.0-12.13.fc13 updates-testing 1.1 M openoffice.org-opensymbol-fonts noarch 1:3.2.0-12.13.fc13 updates-testing 204 k openoffice.org-pdfimport i686 1:3.2.0-12.13.fc13 updates-testing 475 k openoffice.org-presenter-screen i686 1:3.2.0-12.13.fc13 updates-testing 495 k openoffice.org-ure i686 1:3.2.0-12.13.fc13 updates-testing 2.5 M openoffice.org-writer i686 1:3.2.0-12.13.fc13 updates-testing 147 k openoffice.org-writer-core i686 1:3.2.0-12.13.fc13 updates-testing 5.0 M openoffice.org-xsltfilter i686 1:3.2.0-12.13.fc13 updates-testing 338 k : Removing: openoffice.org-langpack-en i686 1:3.2.0-12.11.fc13 @released/$releasever which looks wrong.
My guess is it should still do it, but should skip anything that matches yb.tsInfo.MatchNaevr() or something.
Ok I will leave for now then with the current changes, which should fix the breakage - thanks.
yum-langpacks-0.1.5-1.fc13 http://koji.fedoraproject.org/koji/taskinfo?taskID=2099410
yum-langpacks-0.1.5-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/yum-langpacks-0.1.5-1.fc13
yum-langpacks-0.1.5-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update yum-langpacks'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/yum-langpacks-0.1.5-1.fc13
(In reply to comment #8) > My guess is it should still do it, but should skip anything that matches > yb.tsInfo.MatchNaevr() or something. Dunno if it is related but seems there are still problems: see https://bugzilla.redhat.com/show_bug.cgi?id=569352#c29 .
yum-langpacks-0.1.5-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.