Bug 571862

*** Bug 562308 has been marked as a duplicate of this bug. ***

Emulex's lpfc patch for RHEL5.6 will include a fix for for an AER related issue identified by HP BCS during their testing.  (reference RHE5.5 bugzilla 529244 for details.)

Laurie

Laurie - I'm assuming .66 or newer is planned for 5.6, correct?

Correct, we are up to 8.2.0.71 and will continue to turn for bug fixes up until you say no more.

Created attachment 405404 [details]
Emulex LPFC 8.2.0.73.1p driver source tarball

Created attachment 405406 [details]
LPFC 8.2.0.63.3p to 8.2.0.73.1p patch

Patch to update Emulex lpfc driver to 8.2.0.73.1p (applies on top of 8.2.0.63.3p)

These are the changes included in this patch:

* Changed version number to 8.2.0.73.1p
* Fix swapping target's FC ports caused I/O failure due to target
rejecting PLOGI (CR 100464)
* Fix lpfc_get_hba_info to return correct value for max vpi count
* Add OneSecure definitions and hooks
* OneSecure changes for the encryption IOCB special handling
* Correct comment to reflect lpfc_suppress_link_up instead of
lpfc_init_link
* Add lpfc_suppress_link_up parameter and support
* OneSecure changes for IOCB command define values
* Added OneSecure PCI ID
* Make sure driver sets the "FCP Initiator" flag for remote
initiator ports (CR 100554)
* Changed version number to 8.2.0.72
* Reset HBA when UNREG_VPI fail with busy status (CR 100218)
* Fix failure of unreg_vpi mailbox command (CR 100219)
* Fixed hang on link transitions (CR 99675)
* Change mailbox commands to use SLI4 mailbox size instead of
PAGE_SIZE
* Fix UE and other issues seen after HBA resets with I/O (CR 97910)
* Fix crash with els reject data being formed (CR 99991)
* Changed version number to 8.2.0.71
* Rework logical link speed (CR 99148 99149)
* Changed version number to 8.2.0.70
* Add ratov and edtov to the reg_vfi
* Enable NPIV by default
* Prevent log message 1801 during vport delete
* Implement the new logical link speed event (CR 99148 99149)
Changes from 20100301 to 20100316
* Changed version number to 8.2.0.69
* Separate logging New FCF Found and FCF Parameter Modified
messages
* Fix devloss timeout running Hazard with AER error injection every
30-60 seconds (CR 97468)
* Fixed sli4 params read
* Fixed Crash when cable pulled on initiator in same zone (CR 99675
99587)
* Fix driver issue where the driver was unable to discover the
paths of LUNs on physical port of an HBA after uplink failover
on VC-FC module (CR 99120)
* Changed version number to 8.2.0.68
* Fixed driver bug where the driver is unable to discover the paths of vport 
luns on legacy adapter after uplink failover (CR 99070)
* Remove unused variable from lpfc_nodev_tmo_show
* Add logging messages for critical errors (CR 98726)
* Add fixes for Big Endian sli4 support
* Made the FCF related informational log message only logged to
FCoE devices
* Removed fast FCF failover fabric name matching to allow failover
to any fit FCF
* Added fast FCF failover in response to FCF DEAD event on current
FCF record
* Added round robin FCF failover on initial or FCF rediscovery
FLOGI failure
* Fast FCF failover randomly choose from eligible FCF records with
equal probability
* Change sysfs parameter macros to be uint instead of int (CR 98283)
* Made driver SLI4 reporting ulpWord[4] status on aborted iocb same
as SLI3 (CR 98963)
* Fixed SGL leak when XB bit is set (CR 98736)
* Fixed not clearing LPFC_DRIVER_ABORTED bit in aborted FCP
cmdiocb->iocb_flag
* Changed version number to 8.2.0.67
* Fixed memory allocation failure in the read_sparam mailbox
handling (CR 98738)
* Fixed memory allocation issue in lpfc_config_port_post (CR 98739)
* Fixed vport discovery failure after CVL handling
* Fixed IO error code comparison
* Fixed NULL pointer dereference when kernel is out of memory (CR
98587)
* Use asynchronous mailbox command for requesting FCF recovery
* Remove check post request_features for dif support
* Changed version number to 8.2.0.66
* Add FCF failover support
* Added init_vpi mailbox command before re-registering VPI
* Changed version number to 8.2.0.65
* Submit abort WQE to same work queue as the command WQE
* Changed version number to 8.2.0.64
* Add QOS Link Speed info so user can see it (CR 96665)
* Fix sli4 released aborted els cmd's xri (SGL) before HBA's abort
XRI event (CR 97288)
* Support for Nport ID change after Clear Virtual Link (CR 97188)

*** Bug 569537 has been marked as a duplicate of this bug. ***

This bug is now blocking bug 591674, which is a request to update lpfc to 8.2.0.76.1p. Please add yourselves to this bug if you wish.

Please provide upstream commit ids for the following, which appear to be new features:

> * Add OneSecure definitions and hooks
> * OneSecure changes for the encryption IOCB special handling

> * Add lpfc_suppress_link_up parameter and support
> * OneSecure changes for IOCB command define values
> * Added OneSecure PCI ID

> * Add ratov and edtov to the reg_vfi
> * Enable NPIV by default

> * Implement the new logical link speed event (CR 99148 99149)

> * Add FCF failover support

Rob, here are the upstream submissions these changes were part of.

(In reply to comment #9)
> Please provide upstream commit ids for the following, which appear to be new
> features:
> 
> > * Add OneSecure definitions and hooks
Added in upstream patchset 8.3.2


> > * OneSecure changes for the encryption IOCB special handling
Added in upstream patchset 8.3.10


> > * Add lpfc_suppress_link_up parameter and support
> > * OneSecure changes for IOCB command define values
Added in upstream patchset 8.3.9


> > * Added OneSecure PCI ID
Added in upstream patchset 8.3.6

 
> > * Add ratov and edtov to the reg_vfi
> > * Enable NPIV by default
> 
> > * Implement the new logical link speed event (CR 99148 99149)
> 
> > * Add FCF failover support
Added in upstream patchset 8.3.12

8.3.13 commits:
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=47a997e2da2bad67c2a351b58907482ea7ba5b67
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=e1c6cf96ccef0aefd27f6100a5319b9223005ae9
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=056864ab7781eaecd5299f117c7017ce1bb362be
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=8279979e1024297e86ffdf405dd4746ced5f8f89
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=84a0e8865eec139a0a1b74c37bedad104e307e23
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=cd8c1011262617a3fe3dccc78239a3aaced19540

8.3.14 commits:
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=dcdfc7274a3b9e9f8fe1dfc8ff905586f43de322
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=55b06345267e04c4f1e2f6b72fd0d49540aca8b8
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=4012d45994229dc93b6faa619db63be1f3c3e6b2
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=b0c73b154198664810bf3e918b9a9860a25e6be0

Not a fan of the inclusion of the Tausworthe random number generator, and the comment about it being backported from 2.6.33rc7 is misleading. The code is already present in the rhel5 kernel tree at net/core/utils.c, and was moved from there to lib/random32.c upstream in 2.6.19. The better route here is to properly move the Tausworthe bits first, then create this patch atop that change.

@@ -3545,6 +4032,14 @@ lpfc_sli4_driver_resource_setup(struct l
 		return -ENODEV;
 
 	/*
+	 * The random32 apis are back ported from upstream 2.6.33rc7.
+	 * kernel. The apis are available to SLES11 or later, and
+	 * RHEL6 or later distributions.
+	 */ 
+	random32_init();
+	random32_reseed();
+
+

Vaios,

Looked like this is missing in scsi-misc?
Is this an oversight or did I miss something?

Rob

(In reply to comment #13)
> @@ -3545,6 +4032,14 @@ lpfc_sli4_driver_resource_setup(struct l
>    return -ENODEV;
> 
>   /*
> +  * The random32 apis are back ported from upstream 2.6.33rc7.
> +  * kernel. The apis are available to SLES11 or later, and
> +  * RHEL6 or later distributions.
> +  */ 
> + random32_init();
> + random32_reseed();
> +
> +
> 
> Vaios,
> 
> Looked like this is missing in scsi-misc?
> Is this an oversight or did I miss something?
> 
> Rob    

Nevermind, I understand this now.

in kernel-2.6.18-206.el5
You can download this test kernel from http://people.redhat.com/jwilson/el5

Detailed testing feedback is always welcomed.

This enhancement request was evaluated by the full Red Hat Enterprise Linux 
team for inclusion in a Red Hat Enterprise Linux minor release.   As a 
result of this evaluation, Red Hat has tentatively approved inclusion of 
this feature in the next Red Hat Enterprise Linux Update minor release.   
While it is a goal to include this enhancement in the next minor release 
of Red Hat Enterprise Linux, the enhancement is not yet committed for 
inclusion in the next minor release pending the next phase of actual 
code integration and successful Red Hat and partner testing.

*** Bug 564100 has been marked as a duplicate of this bug. ***

Reminder! There should be a fix present for this BZ in snapshot 3 -- unless otherwise noted in a previous comment.

Please test and update this BZ with test results as soon as possible.

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0017.html