Bug 572195 - add libmikmod as dependency
Summary: add libmikmod as dependency
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: SDL_mixer
Version: 13
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Thomas Janssen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 571177
TreeView+ depends on / blocked
 
Reported: 2010-03-10 14:28 UTC by Nils Philippsen
Modified: 2010-04-23 12:42 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 571177
Environment:
Last Closed: 2010-04-23 12:42:05 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Nils Philippsen 2010-03-10 14:28:36 UTC
+++ This bug was initially created as a clone of Bug #571177 +++

Description of problem:
Package should depend on libmikmod

How reproducible:
Install extremetuxracer without having libmikmod.
No Music at all. If opened via terminal error  messages
comes up about not having libmikmod.

--- Additional comment from nphilipp on 2010-03-08 07:00:50 EST ---

I don't find mention of "mikmod" anywhere in extremetuxracer. Please attach the error message you see. Thanks.

--- Additional comment from d137 on 2010-03-09 11:32:21 EST ---

Created an attachment (id=398840)
without libmikmod

--- Additional comment from d137 on 2010-03-09 11:33:31 EST ---

After "yum install libmikmod" it works fine. I am using rawhide.

--- Additional comment from nphilipp on 2010-03-10 09:25:50 EST ---

Hmm, etracer doesn't use libmikmod directly but via SDL_mixer. In older versions of it, libmikmod was linked in directly, but in Rawhide it will be dlopen()ed (if it's available).

I consider SDL_mixer using libmikmod an implementation detail so requiring it from etracer would only be a band-aid. IMO, SDL_mixer should give me a means to say "this packages needs SDL_mixer and it needs it for playing mods" and leave it to SDL_mixer to pull in the required libraries. For example, SDL_mixer could have an empty meta-subpackage "SDL_mixer-mod":

...
%package mod
Summary: SDL_mixer mod enablement
Provides: SDL_mixer(mod)%{?_isa} = %{?epoch:%{epoch}:}%{version}-%{release}
Requires: %{name} = %{?epoch:%{epoch}:}%{version}-%{release}
Requires: libmikmod%{?_isa}

%description mod
This package pulls in dependencies needed by SDL_mixer to play the following formats: blah, foo and bar tracker
...

Likewise for all other formats that aren't directly pulled in by the main package.

A package like extremetuxracer could then just require "SDL_mixer(mod)%{_isa}" and everything should work.

Comment 1 Fedora Admin XMLRPC Client 2010-04-21 16:19:11 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 2 Hans de Goede 2010-04-23 12:42:05 UTC
Hi Nils,

I understand where you're coming from but I'm not a big fan of empty meta packages, they just generate extra yum metadata and slow down transactions for no good reasons IMHO.

So I would rather see extremetuxracer directly depend on libmikmod. I do understand your pov here, I just come to a different conclusion after waying the various advantages / disadvantages. If you disagree, I think it would be best to discuss this on the fedora-devel or fedora-packaging mailinglist (I'll happily add the meta packages if the outcome is that that is deemed best).

Regards,

Hans


Note You need to log in before you can comment on or make changes to this bug.