Bug 572399 - broken package update
Summary: broken package update
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cyrus-sasl
Version: 12
Hardware: All
OS: Linux
low
high
Target Milestone: ---
Assignee: Jan F. Chadima
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 572183 573794 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-03-11 03:24 UTC by Ralf Corsepius
Modified: 2010-03-23 16:13 UTC (History)
6 users (show)

Fixed In Version: cyrus-sasl-2.1.23-8.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-23 02:14:05 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Ralf Corsepius 2010-03-11 03:24:24 UTC
Description of problem:

# yum update
...
groupdel: group 'saslauth' does not exist
Non-fatal POSTUN scriptlet failure in rpm package cyrus-sasl
warning: %postun(cyrus-sasl-2.1.23-4.fc12.x86_64) scriptlet failed, exit status 6

Version-Release number of selected component (if applicable):
cyrus-sasl-2.1.23-6.fc12.x86_64

Additional info:
Seems like broken scriptlets to me:

# rpm -q --scripts cyrus-sasl
preinstall scriptlet (using /bin/sh):
/usr/sbin/groupadd -r saslauth 2> /dev/null || :
/usr/sbin/useradd -c \""Saslauthd user"\" -g saslauth -s /sbin/nologin -r -d /var/empty/saslauth saslauth 2> /dev/null || :
postinstall scriptlet (using /bin/sh):
/sbin/chkconfig --add saslauthd
preuninstall scriptlet (using /bin/sh):
if [ $1 -eq 0 ] ; then
        /sbin/service saslauthd stop 2>&1 > /dev/null
        /sbin/chkconfig --del saslauthd
fi
postuninstall scriptlet (using /bin/sh):
if [ $1 -ne 0 ] ; then
        /sbin/service saslauthd condrestart 2>&1 > /dev/null
fi
/usr/sbin/userdel saslauth
/usr/sbin/groupdel saslauth

To, the userdel/groupdel in postuninstall seem wrong.

Likely they need to be enclosed by
if [ $1 -eq 0 ]; then
fi

Comment 1 Jan F. Chadima 2010-03-11 08:33:45 UTC
*** Bug 572183 has been marked as a duplicate of this bug. ***

Comment 2 Fedora Update System 2010-03-11 11:35:51 UTC
cyrus-sasl-2.1.23-7.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/cyrus-sasl-2.1.23-7.fc12

Comment 3 Quentin Armitage 2010-03-11 13:11:50 UTC
I have upgraded to cyrus-sasl-2.1.23-7.fc12, and it behaved as expected, still reporting the error, since the postun script was executed from the 2.1.23-4.fc12 package. I then downgraded to the 2.1.23-4.fc12 package, to test whether the postun script resolved the issue, and no longer get the error message and also the user/group does not get deleted.

However, I do now get a couple of new error messages as follows:
  Installing     : cyrus-sasl-lib-2.1.23-4.fc12.i686                       1/10 
  Installing     : cyrus-sasl-plain-2.1.23-4.fc12.i686                     2/10 
  Installing     : cyrus-sasl-md5-2.1.23-4.fc12.i686                       3/10 
  Installing     : cyrus-sasl-2.1.23-4.fc12.i686                           4/10 
  Installing     : cyrus-sasl-devel-2.1.23-4.fc12.i686                     5/10 
  Cleanup        : cyrus-sasl-plain-2.1.23-7.fc12.i686                     6/10 
  Cleanup        : cyrus-sasl-md5-2.1.23-7.fc12.i686                       7/10 
  Cleanup        : cyrus-sasl-devel-2.1.23-7.fc12.i686                     8/10 
  Cleanup        : cyrus-sasl-2.1.23-7.fc12.i686                           9/10 
/var/tmp/rpm-tmp.ioTElP: line 4: fg: no job control
/var/tmp/rpm-tmp.ioTElP: line 5: fg: no job control
  Cleanup        : cyrus-sasl-lib-2.1.23-7.fc12.i686                      10/10

Comment 4 Toshio Kuratomi 2010-03-11 15:00:55 UTC
Uh.... The package should not be running userdel or groupdel at all.

"""
We never remove users or groups created by packages. There's no sane way to check if files owned by those users/groups are left behind
"""
   https://fedoraproject.org/wiki/Packaging:UsersAndGroups

Comment 5 Jan F. Chadima 2010-03-11 15:34:37 UTC
The package was written according to:
http://fedoraproject.org/wiki/PackageUserCreation
IMHO: There are no files created under this account and the uid/gid are fized.

Comment 6 Toshio Kuratomi 2010-03-12 00:30:38 UTC
That page is not a packaging guideline.

Once again, you can't know what the user may have done on their system so you can't know if you should be removing that user and group or not.

The uid and gid are not fixed.  They are fixed per site which has setup fedora-usermgmt which is a different thing.  See https://www.redhat.com/archives/fedora-extras-list/2006-March/msg00688.html which explains that the uid and gid are ignored when fedora-usermgmt has not been configured.

Also note -- if the cyrus-sasl package is not putting down any files on disk under the saslauth user/group (let alone any that need to be shared), you should be using a dynamic uid/gid pair rather than a pseudo-static one.

Comment 7 Fedora Update System 2010-03-12 04:25:35 UTC
cyrus-sasl-2.1.23-7.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cyrus-sasl'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/cyrus-sasl-2.1.23-7.fc12

Comment 8 Fedora Update System 2010-03-13 18:23:18 UTC
cyrus-sasl-2.1.23-8.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/cyrus-sasl-2.1.23-8.fc12

Comment 9 Fedora Update System 2010-03-13 18:24:17 UTC
cyrus-sasl-2.1.23-10.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/cyrus-sasl-2.1.23-10.fc13

Comment 10 Fedora Update System 2010-03-14 13:43:48 UTC
cyrus-sasl-2.1.23-10.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cyrus-sasl'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/cyrus-sasl-2.1.23-10.fc13

Comment 11 Fedora Update System 2010-03-16 00:45:38 UTC
cyrus-sasl-2.1.23-8.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cyrus-sasl'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/cyrus-sasl-2.1.23-8.fc12

Comment 12 Jan F. Chadima 2010-03-16 08:29:17 UTC
*** Bug 573794 has been marked as a duplicate of this bug. ***

Comment 13 Fedora Update System 2010-03-23 02:14:00 UTC
cyrus-sasl-2.1.23-8.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.