Spec URL: http://jcollie.fedorapeople.org/desktopcouch.spec SRPM URL: http://jcollie.fedorapeople.org/desktopcouch-0.6.3-1.fc12.src.rpm Description: A CouchDB on every desktop, and the code to help it happen. rpmlint shows the following: desktopcouch.noarch: W: only-non-binary-in-usr-lib desktopcouch.src:93: E: hardcoded-library-path in %{_prefix}/lib/desktopcouch/desktopcouch-service desktopcouch.src:94: E: hardcoded-library-path in %{_prefix}/lib/desktopcouch/desktopcouch-stop desktopcouch.src:95: E: hardcoded-library-path in %{_prefix}/lib/desktopcouch/desktopcouch-get-port 5 packages and 0 specfiles checked; 3 errors, 1 warnings. I think that these may be false alarms though.
They're really not false alarms. I have no idea why those binaries end up in /usr/lib/desktopcouch. They need to be in %{_bindir}. My spec had this line at the end of %install: # Really? You put them there? In /usr/lib (note, not %{_libdir})? Fail. mv %{buildroot}/usr/lib/desktopcouch/desktopcouch-* %{buildroot}%{_bindir} A few other points: * The desktopcouch package should own %dir %{_sysconfdir}/xdg/desktop-couch/ * The descriptions need to be relevant and specific for the subpackages, even if they simply repeat their Summary. * You do not need to copy the licenses and docs for all of the packages where there is a forced dependency chain. This means that only desktopcouch needs them not the others. * Dependencies on subpackages should be on desktopcouch = %{version}-%{release}, not just %{version}. Nevertheless, a good start. Fix those issues and I'll finish out the review.
OK, I think I have covered all of the points: Spec URL: http://jcollie.fedorapeople.org/desktopcouch.spec SRPM URL: http://jcollie.fedorapeople.org/desktopcouch-0.6.3-2.fc12.src.rpm rpmlint now says: desktopcouch.src:76: E: hardcoded-library-path in %{buildroot}/usr/lib/desktopcouch/desktopcouch-* python-desktopcouch.noarch: W: no-documentation 5 packages and 0 specfiles checked; 1 errors, 1 warnings.
== REVIEW == Bad: - desktop-file-install/desktop-file-validate not used: https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files Good: - rpmlint checks return: desktopcouch.src:76: E: hardcoded-library-path in %{buildroot}/usr/lib/desktopcouch/desktopcouch-* python-desktopcouch.noarch: W: no-documentation Both are safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (LGPLv3) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (SHA256: a0704e6c1c381874582eaf82c8dc7498bb3d480aef3bf1ee1548f2ae9775a05f) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime ***** Fix that minor item with the desktop files and I'll approve this.
Spec URL: http://jcollie.fedorapeople.org/desktopcouch.spec SRPM URL: http://jcollie.fedorapeople.org/desktopcouch-0.6.3-3.fc12.src.rpm Desktop file is now validated.
Fantastic, great work. APPROVED. Please push this into at least F-13, as the new stable branch of gwibber will need it.
New Package CVS Request ======================= Package Name: desktopcouch Short Description: A CouchDB instance on every desktop Owners: jcollie Branches: devel F-13 F-12 InitialCC: jcollie
CVS done (by process-cvs-requests.py).
desktopcouch-0.6.3-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/desktopcouch-0.6.3-3.fc13
desktopcouch-0.6.3-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/desktopcouch-0.6.3-3.fc12
desktopcouch-0.6.3-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update desktopcouch'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/desktopcouch-0.6.3-3.fc13
desktopcouch-0.6.3-3.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update desktopcouch'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/desktopcouch-0.6.3-3.fc12
desktopcouch-0.6.3-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
desktopcouch-0.6.3-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.