Bug 573234 - [abrt] Leading whitespace in section name lines breaks parsing of smb.conf
Summary: [abrt] Leading whitespace in section name lines breaks parsing of smb.conf
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-samba
Version: 12
Hardware: i686
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nils Philippsen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:d53d87de
: 577441 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-03-13 15:38 UTC by adalsaady
Modified: 2010-11-30 01:29 UTC (History)
9 users (show)

Fixed In Version: python-slip-0.2.9-1.fc12
Clone Of:
Environment:
Last Closed: 2010-04-27 02:26:36 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (3.97 KB, text/plain)
2010-03-13 15:38 UTC, adalsaady
no flags Details
my configuration (11.09 KB, text/plain)
2010-03-15 18:07 UTC, adalsaady
no flags Details

Description adalsaady 2010-03-13 15:38:01 UTC
abrt 1.0.8 detected a crash.

architecture: i686
Attached file: backtrace
cmdline: /usr/bin/python /usr/bin/system-config-samba
comment: just run it and crash
component: system-config-samba
executable: /usr/bin/system-config-samba
kernel: 2.6.32.9-70.fc12.i686.PAE
package: system-config-samba-1.2.86-1.fc12
reason: polkit.py:143:_enable_proxy:DBusException: org.freedesktop.DBus.Python.Exception: Traceback (most recent call last):
release: Fedora release 12 (Constantine)

How to reproduce
-----
1. just run it and crash

Comment 1 adalsaady 2010-03-13 15:38:04 UTC
Created attachment 399861 [details]
File: backtrace

Comment 2 Nils Philippsen 2010-03-15 11:05:02 UTC
There seems to be a problem with your Samba configuration file. Would you please attach /etc/samba/smb.conf to this ticket? Thanks.

Comment 3 adalsaady 2010-03-15 18:07:43 UTC
Created attachment 400281 [details]
my configuration

Comment 4 Nils Philippsen 2010-03-16 14:12:48 UTC
It stumbles over the leading tab character in line 305:

    [public]

You can remove that as a workaround:

[public]

It seems I need to make the parser robust against section names with leading/trailing whitespace. I wonder why nobody reported this problem before ;-).

Comment 5 Nils Philippsen 2010-03-30 16:08:16 UTC
Fixed upstream in eebe51018d2349230f62fcb9c74e6fd696968952:

http://git.fedorahosted.org/git/system-config-samba.git?p=system-config-samba.git;a=commitdiff;h=eebe51018d2349230f62fcb9c74e6fd696968952

Comment 6 Nils Philippsen 2010-03-30 16:08:29 UTC
*** Bug 577441 has been marked as a duplicate of this bug. ***

Comment 7 Fedora Update System 2010-03-31 13:10:01 UTC
system-config-samba-1.2.88-1.fc12,python-slip-0.2.9-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/system-config-samba-1.2.88-1.fc12,python-slip-0.2.9-1.fc12

Comment 8 Fedora Update System 2010-03-31 13:14:41 UTC
python-slip-0.2.9-1.fc13,system-config-samba-1.2.88-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/python-slip-0.2.9-1.fc13,system-config-samba-1.2.88-1.fc13

Comment 9 Fedora Update System 2010-04-03 04:48:36 UTC
system-config-samba-1.2.88-1.fc12, python-slip-0.2.9-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-samba python-slip'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/system-config-samba-1.2.88-1.fc12,python-slip-0.2.9-1.fc12

Comment 10 Fedora Update System 2010-04-20 13:15:12 UTC
python-slip-0.2.9-1.fc12, system-config-samba-1.2.89-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-slip system-config-samba'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/system-config-samba-1.2.89-1.fc12,python-slip-0.2.9-1.fc12

Comment 11 Fedora Update System 2010-04-22 22:55:51 UTC
system-config-samba-1.2.89-1.fc13, python-slip-0.2.9-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Jon Hamelin 2010-04-24 04:46:24 UTC

How to reproduce
-----
1.opened System > Administration >Samba
2.
3.


Comment
-----
attempted to open Samba to configure

Comment 13 Alejandro_Perez 2010-04-26 00:13:54 UTC

How to reproduce
-----
1.just start it 
2.
3.

Comment 14 Nils Philippsen 2010-04-26 09:08:13 UTC
Jon, Alejandro, which versions of system-config-samba and python-slip do you have installed?

Comment 15 Jon Hamelin 2010-04-26 14:44:22 UTC
system-config-samba noarch 1.2.86-1.fc12
python-slip noarch 0.2.8-1.fc12
 
Info from abrt:

Package:    	system-config-samba-1.2.86-1.fc12
Latest Crash:	Mon 26 Apr 2010 07:37:03 AM 
Command:    	/usr/bin/python /usr/bin/system-config-samba
Reason:     	polkit.py:143:_enable_proxy:DBusException: org.freedesktop.DBus.Python.Exception: Traceback (most recent call last):
Comment:    	attempted to open Samba to configure
Bug Reports:	Status: ON_QA
		https://bugzilla.redhat.com/show_bug.cgi?id=573234;file:///var/log/abrt.log

Comment 16 Nils Philippsen 2010-04-26 15:01:45 UTC
(In reply to comment #15)
> system-config-samba noarch 1.2.86-1.fc12
> python-slip noarch 0.2.8-1.fc12

In that case, please check whether you can reproduce this problem with the updated version available from updates-testing. Thanks.

Comment 17 Fedora Update System 2010-04-27 02:26:27 UTC
python-slip-0.2.9-1.fc12, system-config-samba-1.2.89-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 18 Jon Hamelin 2010-04-27 15:05:18 UTC
system updated today 27 April 2010 with system-config-samba-1.2.89-1.fc12.noarch, python-slip-0.2.9-1.fc12.noarch and python-slip-dbus-0.2.9-1.fc12.noarch. Same problem. Nothing solved!

Comment 19 Nils Philippsen 2010-04-29 16:16:28 UTC
(In reply to comment #18)
> Same problem. Nothing solved!    

I guess you're suffering from the same symptom -- s-c-samba crashing/causing a traceback -- caused by a different problem. This bug is about white space in section name lines, are you sure your problem is caused by this as well?

Comment 20 Jon Hamelin 2010-04-30 13:46:33 UTC
Solved. Removed Samba and reinstalled. Works fine now.

Comment 21 Sylvain Arth 2010-05-29 12:16:58 UTC
Doh !
It's no my intention to be offensive but this pretty looks like a no analysis at all issue.
The question is what was (and is probably still)  wrong with the samba installation ?
Any bug report about the above ?


Note You need to log in before you can comment on or make changes to this bug.