Spec URL: http://fedorapeople.org/~cweyl/review/perl-CLASS.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-CLASS-1.00-1.fc12.src.rpm Description: This package provides CLASS and $CLASS; both synonyms for __PACKAGE__. They're easier to type, and $CLASS has the additional benefit of working in strings. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2051332 Additional Comment: This package is an additional dependency of the latest GA Git::CPAN::Patch. *rt-0.10_01
OK rpmlint on every package. OK name of package accords to the Naming Guidelines. OK spec file name match the base package %{name}. 834b888b9c8a936b12de2c168798b618 OK package meet the Packaging Guidelines. OK package has a good license. OK spec file is written in American English. OK spec file for the package must be legible. OK The sources used to build the package must match the upstream source. OK successful koji compilation. OK correct BuildRequires, Requires. OK proper use of %find_lang macro. OK shared library must call ldconfig in %post and %postun. OK relocatable package must state this fact. OK package must own their directories. OK permissions on files must be set properly. OK %clean section with rm -rf %{buildroot}. OK consistent use of macros. OK package contains code, or permissable content. OK large documentation go in a -doc subpackage. OK %doc must not affect the runtime of the application. OK header files must be in a -devel package. OK static libraries must be in a -static package. OK pkgconfig(.pc) files must 'Requires: pkgconfig'. OK library files with a suffix (.so) must go in -devel. OK usually devel packages must require the base package. OK Remove .la libtool archives. OK GUI applications must include a %{name}.desktop file. OK %install section starts with rm -rf %{buildroot}. ACCEPT
New Package CVS Request ======================= Package Name: perl-CLASS Short Description: Alias for __PACKAGE__ Owners: cweyl Branches: F-11 F-12 F-13 devel InitialCC: perl-sig
CVS done (by process-cvs-requests.py).
Thanks for the review! :-)