Bug 573326 (perl-CLASS) - Review Request: perl-CLASS - Alias for __PACKAGE__
Summary: Review Request: perl-CLASS - Alias for __PACKAGE__
Alias: perl-CLASS
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/CLASS
Depends On:
TreeView+ depends on / blocked
Reported: 2010-03-14 05:34 UTC by Chris Weyl
Modified: 2010-03-19 23:51 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2010-03-19 23:51:17 UTC
mmaslano: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Chris Weyl 2010-03-14 05:34:23 UTC
Spec URL: http://fedorapeople.org/~cweyl/review/perl-CLASS.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-CLASS-1.00-1.fc12.src.rpm

This package provides CLASS and $CLASS; both synonyms for __PACKAGE__.
They're easier to type, and $CLASS has the additional benefit of working
in strings.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2051332

Additional Comment:

This package is an additional dependency of the latest GA Git::CPAN::Patch.


Comment 1 Marcela Mašláňová 2010-03-19 14:43:16 UTC
OK rpmlint on every package.
OK name of package accords to the Naming Guidelines.
OK spec file name match the base package %{name}.
OK package meet the Packaging Guidelines.
OK package has a good license.
OK spec file is written in American English.
OK spec file for the package must be legible.
OK The sources used to build the package must match the upstream source.
OK successful koji compilation.
OK correct BuildRequires, Requires.
OK proper use of %find_lang macro.
OK shared library must call ldconfig in %post and %postun.
OK relocatable package must state this fact.
OK package must own their directories.
OK permissions on files must be set properly.
OK %clean section with rm -rf %{buildroot}.
OK consistent use of macros.
OK package contains code, or permissable content.
OK large documentation go in a -doc subpackage.
OK %doc must not affect the runtime of the application.
OK header files must be in a -devel package.
OK static libraries must be in a -static package.
OK pkgconfig(.pc) files must 'Requires: pkgconfig'.
OK library files with a suffix (.so) must go in -devel.
OK usually devel packages must require the base package.
OK Remove .la libtool archives.
OK GUI applications must include a %{name}.desktop file.
OK %install section starts with rm -rf %{buildroot}.

Comment 2 Chris Weyl 2010-03-19 15:47:14 UTC
New Package CVS Request
Package Name: perl-CLASS
Short Description: Alias for __PACKAGE__
Owners: cweyl
Branches: F-11 F-12 F-13 devel
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2010-03-19 19:58:16 UTC
CVS done (by process-cvs-requests.py).

Comment 4 Chris Weyl 2010-03-19 23:51:17 UTC
Thanks for the review! :-)

Note You need to log in before you can comment on or make changes to this bug.