Bug 574256 - [abrt] crash in control-center-1:2.29.92-1.fc13: Process /usr/bin/gnome-about-me was killed by signal 11 (SIGSEGV)
Summary: [abrt] crash in control-center-1:2.29.92-1.fc13: Process /usr/bin/gnome-about...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: control-center
Version: 14
Hardware: x86_64
OS: Linux
low
medium
Target Milestone: ---
Assignee: Control Center Maintainer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:1b5e9cbbbc25c80bbd06f2f0c65...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-03-16 23:17 UTC by Michal Schmidt
Modified: 2012-08-16 22:38 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-16 22:38:44 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (17.18 KB, text/plain)
2010-03-16 23:17 UTC, Michal Schmidt
no flags Details
make sure the correct "me" is reset after freeing the struct (537 bytes, patch)
2010-03-16 23:57 UTC, Michal Schmidt
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
GNOME Bugzilla 592348 0 None None None Never

Description Michal Schmidt 2010-03-16 23:17:09 UTC
abrt 1.0.8 detected a crash.

architecture: x86_64
Attached file: backtrace
cmdline: gnome-about-me
comment: Looks like a use after free().
component: control-center
executable: /usr/bin/gnome-about-me
kernel: 2.6.33-8.fc13.x86_64
package: control-center-1:2.29.92-1.fc13
rating: 4
reason: Process /usr/bin/gnome-about-me was killed by signal 11 (SIGSEGV)
release: Fedora release 13 (Rawhide)

How to reproduce
-----
1. Run:  MALLOC_PERTURB_=207 gnome-about-me
2. Switch to the "Address" tab.
3. Change focus to some other application
4. Change focus back to gnome-about-me
5. Close gnome-about-me using the close button in the window's decoration.

Comment 1 Michal Schmidt 2010-03-16 23:17:11 UTC
Created attachment 400596 [details]
File: backtrace

Comment 2 Michal Schmidt 2010-03-16 23:40:04 UTC
Changing focus is not necessary. So the steps to reproduce are simply:
1. Run:  MALLOC_PERTURB_=207 gnome-about-me
2. Switch to the "Address" tab.
3. Close gnome-about-me using the close button in the window's decoration.

Comment 3 Michal Schmidt 2010-03-16 23:55:07 UTC
From the backtrace it can be seen that about_me_focus_out() was called and me->addr2 points to freed memory. The memory is freed in about_me_destroy():

static void 
about_me_destroy (GnomeAboutMe *me)
{
        e_contact_address_free (me->addr1);
        e_contact_address_free (me->addr2);
        /* ... free more items ... */
        g_free (me);
        me = NULL;
}

It frees the whole data structure and it tries to do the right thing by setting "me = NULL" afterwards, but "me" in this case is not the global variable, but the local one which shadows it. So the global "me" remains non-NULL and when later about_me_focus_out() is called, it cannot know it should return early.

Comment 4 Michal Schmidt 2010-03-16 23:57:25 UTC
Created attachment 400603 [details]
make sure the correct "me" is reset after freeing the struct

This patch should fix it. Not tested.

Comment 5 Michal Schmidt 2010-03-17 12:00:01 UTC
I found an existing upstream bugreport: https://bugzilla.gnome.org/show_bug.cgi?id=592348
I'll attach a patch there.

Comment 6 Fedora Update System 2010-03-22 15:03:19 UTC
control-center-2.29.92-3.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/control-center-2.29.92-3.fc13

Comment 7 Fedora Update System 2010-03-23 23:22:48 UTC
control-center-2.29.92-3.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update control-center'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/control-center-2.29.92-3.fc13

Comment 8 Bug Zapper 2010-07-30 11:06:09 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 14 development cycle.
Changing version to '14'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 9 Fedora End Of Life 2012-08-16 22:38:46 UTC
This message is a notice that Fedora 14 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 14. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained.  At this time, all open bugs with a Fedora 'version'
of '14' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this 
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen 
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we were unable to fix it before Fedora 14 reached end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" (top right of this page) and open it against that 
version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping


Note You need to log in before you can comment on or make changes to this bug.