Spec URL: http://tremble.fedorapeople.org/packages/rubygem-xmpp4r-simple.spec SRPM URL: http://tremble.fedorapeople.org/packages/rubygem-xmpp4r-simple-0.8.8-1.fc12.src.rpm Description: Jabber::Simple takes the strong foundation laid by xmpp4r and hides the relatively high complexity of maintaining a simple instant messenger bot in Ruby.
Initial comments: * Requires/BuildRequires - ">= 0.3.2" for (Build)Requires: rubygem(xmpp4r) is redundant because the least version of rubygem-xmpp4r on Fedora is 0.5. - ">= 0" for (Build)Requires is redundant. * Macros - As %geminstdir is defined, please use this defined even in %files * Duplicate %files entry - From build.log: ------------------------------------------------------------- 56 Processing files: rubygem-xmpp4r-simple-0.8.8-1.fc13.noarch 57 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/xmpp4r-simple-0.8.8/COPYING 58 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/xmpp4r-simple-0.8.8/README ------------------------------------------------------------- And from $ rpm -qlp: ------------------------------------------------------------- $ rpm -qlp *rpm | sort | uniq -d /usr/lib/ruby/gems/1.8/gems/xmpp4r-simple-0.8.8/test /usr/lib/ruby/gems/1.8/gems/xmpp4r-simple-0.8.8/test/test_xmpp4r_simple.rb ------------------------------------------------------------- These files or directories are listed more than once. Please fix %files list so that all files/directories appear only once.
* Requires/BuildRequires - Changed * Macros - Now consistently used in %files * Duplicate %files entry - Caught out by forgetting to use %dir macro Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2095124 SRPM: http://tremble.fedorapeople.org/packages/rubygem-xmpp4r-simple-0.8.8-2.fc12.src.rpm SPEC: http://tremble.fedorapeople.org/packages/rubygem-xmpp4r-simple.spec Thank you for your time.
Okay. ----------------------------------------------------------------- This package (rubygem-xmpp4r-simple) is APPROVED by mtasaka -----------------------------------------------------------------
Forgot to mention that please fix %changelog entry when importing into Fedora CVS
re: %changelog - will do New Package CVS Request ======================= Package Name: rubygem-xmpp4r-simple Short Description: A simplified Jabber client library Owners: tremble Branches: F-12 F-13 EL-5
CVS done (by process-cvs-requests.py).
rubygem-xmpp4r-simple-0.8.8-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-xmpp4r-simple-0.8.8-2.fc12
Closing.
rubygem-xmpp4r-simple-0.8.8-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.