Spec URL: http://rebus.webz.cz/d/metagoofil.spec SRPM URL: http://rebus.webz.cz/d/metagoofil-1.4a-1.fc12.src.rpm2 License: GPLv2 Description: Metagoofil is an information gathering tool designed for extracting metadata of public documents (pdf,doc,xls,ppt,odp,ods) availables in the target/victim websites. Hello, please would be someone so kind and willing to do review of the metagoofil package for fedora? I do not have any package in Fedora sofar so I would humbly ask for sponsoring as well. Output from the rpmlint : $rpmlint /home/rebus/rpmbuild/SRPMS/metagoofil-1.4a-1.fc12.src.rpm /home/rebus/rpmbuild/RPMS/noarch/metagoofil-1.4a-1.fc12.noarch.rpm metagoofil.src: W: spelling-error %description -l en_US pdf -> pd, pf, pd f metagoofil.src: W: spelling-error %description -l en_US xls -> ls, xis, x ls metagoofil.src: W: spelling-error %description -l en_US ppt -> opt, pot, ppr metagoofil.src: W: spelling-error %description -l en_US odp -> op, pod, ode metagoofil.src: W: spelling-error %description -l en_US ods -> dos, ids, odd - list of supported document types in the description metagoofil.noarch: E: explicit-lib-dependency libextractor - explicit dependency is needed because it is executed from the perl script and is not detected automatically metagoofil.noarch: W: spelling-error %description -l en_US pdf -> pd, pf, pd f metagoofil.noarch: W: spelling-error %description -l en_US xls -> ls, xis, x ls metagoofil.noarch: W: spelling-error %description -l en_US ppt -> opt, pot, ppr metagoofil.noarch: W: spelling-error %description -l en_US odp -> op, pod, ode metagoofil.noarch: W: spelling-error %description -l en_US ods -> dos, ids, odd - list of supported document types in the description 2 packages and 0 specfiles checked; 1 errors, 10 warnings. Thank you. Michal Ambroz
(In reply to comment #0) Informal review > SRPM URL: http://rebus.webz.cz/d/metagoofil-1.4a-1.fc12.src.rpm2 - there's a typo in the url of the src.rpm (trailing "2") > [...] > > Output from the rpmlint : > $rpmlint /home/rebus/rpmbuild/SRPMS/metagoofil-1.4a-1.fc12.src.rpm > /home/rebus/rpmbuild/RPMS/noarch/metagoofil-1.4a-1.fc12.noarch.rpm > metagoofil.src: W: spelling-error %description -l en_US pdf -> pd, pf, pd f > [...] > metagoofil.src: W: spelling-error %description -l en_US ods -> dos, ids, odd > - list of supported document types in the description - use CAPITALS for file extensions (i.e.: use PDF instead of pdf) > metagoofil.noarch: E: explicit-lib-dependency libextractor > - explicit dependency is needed because it is executed from the perl script and is not detected automatically - In general rpmlint suggests that "You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags." Anyway in this case it is quite probable that rpm can't find the dependency, so should be ok. > metagoofil.noarch: W: spelling-error %description -l en_US pdf -> pd, pf, pd f > [...] > metagoofil.noarch: W: spelling-error %description -l en_US ods -> dos, ids, odd > - list of supported document types in the description - same of above (capitalize)
Hello Alex, thanks for the tips - with capitalizations rpmlint doesn't complain about the abreviations of format extensions Here is the rebuild package. SPEC URL: http://rebus.webz.cz/d/metagoofil.spec SRPM URL: http://rebus.webz.cz/d/metagoofil-1.4a-2.fc12.src.rpm > Anyway in this case it is quite probable that rpm can't find the > dependency, so should be ok. yes that is the point - rpm didn't find the dependency and was ready to install the package when libextractor is not present. Best regards Michal Ambroz
(In reply to comment #1) > > metagoofil.src: W: spelling-error %description -l en_US ods -> dos, ids, odd > > - list of supported document types in the description > > - use CAPITALS for file extensions (i.e.: use PDF instead of pdf) Not quite. This is a bug in rpmlint, which is safe to be ignored.
Hello Alex, Ralf, please are there some outstanding issues you would like me to fix? Thank you. Michal Ambroz
Output from rpmlint $rpmlint metagoofil-1.4a-2.fc12.src.rpm metagoofil-1.4a-2.fc12.noarch.rpm metagoofil.noarch: E: explicit-lib-dependency libextractor 2 packages and 0 specfiles checked; 1 errors, 0 warnings. Explicit dependency is needed because it is executed from the perl script and it is not detected automatically Koji build F12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2108436 Koji build F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2108500 Koji build rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=2108502
(In reply to comment #5) > Output from rpmlint > $rpmlint metagoofil-1.4a-2.fc12.src.rpm metagoofil-1.4a-2.fc12.noarch.rpm > metagoofil.noarch: E: explicit-lib-dependency libextractor > 2 packages and 0 specfiles checked; 1 errors, 0 warnings. > > Explicit dependency is needed because it is executed from the perl script and > it is not detected automatically > > [...] You are right. Dependency cannot be resolved automatically so explicit lib dependency is required, in this case. Anyway it is a python script (not perl): you should add "Requires: python..." in spec file See https://fedoraproject.org/wiki/Packaging:Python for details.
Added Requires: python(abi) = 2.6 SPEC URL: http://rebus.fedorapeople.org/fedora/12/SPECS/metagoofil.spec SRPM URL: http://rebus.fedorapeople.org/fedora/12/SRPMS/metagoofil-1.4a-3.fc12.src.rpm Best regards Michal Ambroz
(In reply to comment #0) > I do not have any package in Fedora sofar so I would > humbly ask for sponsoring as well. -> blocking FE-NEEDSPONSOR
Thomas - I have been sponsored already so I am removing this blocking again. You can check the status in FAS. Best regards Michal Ambroz
You could change the Requires: libextractor to Requires: /usr/bin/libextractor-extract, file dependencies on files in bin dirs are fine. rpmlint -v metagoofil-1.4a-3.fc12.noarch.rpm metagoofil.noarch: I: checking metagoofil.noarch: E: explicit-lib-dependency libextractor 1 packages and 0 specfiles checked; 1 errors, 0 warnings. You can fix the error by following the suggestion above. However it is not a real error as you use the requires for one of the libextractor files and not for the library itself. So it is up to you if you want to change the requires or not. rpmlint -v metagoofil-1.4a-3.fc12.src.rpm metagoofil.src: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. The package is really simple and I reviewed that it conforms to the guidelines. APPROVED
Thank you Tomasi for review. If it clears the rpmlint and is not against guidelines I will modify dependency to file rather than whole lib. Name of binary is still self-explaining which package is it comming from so no-harm to use it. Thanks for hint. Michal Ambroz
SPEC URL: http://rebus.fedorapeople.org/fedora/12/SPECS/metagoofil.spec SRPM URL: http://rebus.fedorapeople.org/fedora/12/SRPMS/metagoofil-1.4a-4.fc12.src.rpm
New Package CVS Request ======================= Package Name: metagoofil Short Description: Metadata analyzer, information gathering tool Owners: rebus Branches: F-12 F-13 EL-4 EL-5 devel InitialCC: Thank you Michal Ambroz
CVS done (by process-cvs-requests.py).
metagoofil-1.4a-4.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/metagoofil-1.4a-4.el4
metagoofil-1.4a-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/metagoofil-1.4a-4.fc12
metagoofil-1.4a-4.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/metagoofil-1.4a-4.el5
metagoofil-1.4a-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/metagoofil-1.4a-4.fc13
metagoofil-1.4a-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
metagoofil-1.4a-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
metagoofil-1.4a-5.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/metagoofil-1.4a-5.el4
metagoofil-1.4a-5.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/metagoofil-1.4a-5.fc13
metagoofil-1.4a-5.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/metagoofil-1.4a-5.fc12
metagoofil-1.4a-5.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/metagoofil-1.4a-5.el5
metagoofil-1.4a-5.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
metagoofil-1.4a-5.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
metagoofil-1.4a-5.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report.
metagoofil-1.4a-5.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
metagoofil-1.4b-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/metagoofil-1.4b-1.fc12
metagoofil-1.4b-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/metagoofil-1.4b-1.fc13
metagoofil-1.4b-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/metagoofil-1.4b-1.el5
metagoofil-1.4b-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
metagoofil-1.4b-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
metagoofil-1.4b-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.