Bug 575564 - should complain about missing included kickstart file instead of "kickstart.py:56:read_kickstart:ValueError: need more than 1 value to unpack"
Summary: should complain about missing included kickstart file instead of "kickstart.p...
Keywords:
Status: CLOSED DUPLICATE of bug 551932
Alias: None
Product: Fedora
Classification: Fedora
Component: livecd-tools
Version: 13
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Huff
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:d674adca
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-03-21 13:57 UTC by Ishan Girdhar
Modified: 2010-08-07 19:19 UTC (History)
8 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-08-07 19:19:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (660 bytes, text/plain)
2010-03-21 13:57 UTC, Ishan Girdhar
no flags Details
kickstart-repo.diff (759 bytes, patch)
2010-05-06 00:36 UTC, Jens Petersen
no flags Details | Diff

Description Ishan Girdhar 2010-03-21 13:57:19 UTC
abrt 1.0.8 detected a crash.

architecture: i686
cmdline: /usr/bin/python -tt /usr/bin/livecd-creator --config=ekant.ks --cache=cache --fslabel=lfy-remix
component: livecd-tools
executable: /usr/bin/livecd-creator
kernel: 2.6.32.9-70.fc12.i686.PAE
package: livecd-tools-031-1.fc12.1
reason: kickstart.py:56:read_kickstart:ValueError: need more than 1 value to unpack
release: Fedora release 12 (Constantine)

backtrace
-----
kickstart.py:56:read_kickstart:ValueError: need more than 1 value to unpack

Traceback (most recent call last):
  File "/usr/bin/livecd-creator", line 140, in <module>
    sys.exit(main())
  File "/usr/bin/livecd-creator", line 112, in main
    ks = imgcreate.read_kickstart(options.kscfg)
  File "/usr/lib/python2.6/site-packages/imgcreate/kickstart.py", line 56, in read_kickstart
    except IOError, (err, msg):
ValueError: need more than 1 value to unpack

Local variables in innermost frame:
ks: <pykickstart.parser.KickstartParser instance at 0xa24158c>
path: 'ekant.ks'
version: <f12.F12Handler object at 0xa1c336c>
ksfile: '/media/disk/remix/ekant.ks'

Comment 1 Ishan Girdhar 2010-03-21 13:57:22 UTC
Created attachment 401558 [details]
File: backtrace

Comment 2 Jens Petersen 2010-04-20 08:59:35 UTC
# rpm -q livecd-tools
livecd-tools-031-1.fc12.1.x86_64
# /usr/bin/livecd-creator -c fedora-livecd-desktop.ks -f F14-Live-x86_64-20100420T1849
Traceback (most recent call last):
  File "/usr/bin/livecd-creator", line 140, in <module>
    sys.exit(main())
  File "/usr/bin/livecd-creator", line 112, in main
    ks = imgcreate.read_kickstart(options.kscfg)
  File "/usr/lib/python2.6/site-packages/imgcreate/kickstart.py", line 56, in read_kickstart
    except IOError, (err, msg):
ValueError: need more than 1 value to unpack

Is this fixed in git or elsewhere?

Note composing F12 Live spins works but not F13 or later.

Comment 3 Jens Petersen 2010-05-05 09:35:41 UTC
Adding to blocker list in hope there may be a fix before release time.

How have the current F13 live images been made?

Comment 4 Paul W. Frields 2010-05-05 14:27:26 UTC
http://alt.fedoraproject.org/pub/alt/nightly-composes/desktop/logs/

The logs for the nightly desktop compose don't appear to show this failure.  The question is, are they being created on F13?  Looking for this answer now.

Comment 5 Paul W. Frields 2010-05-05 14:38:26 UTC
I can't reproduce this locally, using an F13 x86_64 host to do the live creation, fedora-livecd-desktop.ks from the 'master' branch of spin-kickstarts, and a local mirror providing the current F13 tree.

Jens, Ishan, are you composing on a F13 host?

Comment 6 Paul W. Frields 2010-05-05 14:47:08 UTC
Ishan was apparently composing on a F12 box.  Our release images are composed on the equivalent release branch (F13 composed on F13, for example).  This should probably be marked as a potential F12 bug, unless Jens has other information for us.  He might be composing from a F14 tree based on the label he gave above.

This may not be a release blocker, but I'd like you guys to confirm the environments in which you're building, and Ishan, if you could post your kickstart that would also be helpful.

Comment 7 Jens Petersen 2010-05-05 23:54:47 UTC
I can't compose on F12 or F13 (admittedly i686).

I will try a bit harder now that I know it is working for others. :)

Comment 8 Jens Petersen 2010-05-05 23:56:42 UTC
(In reply to comment #7)
> I can't compose on F12 or F13 (admittedly i686).

To clarify: I can't compose *F13* on F12 or F13 (admittedly i686).

Comment 9 Jens Petersen 2010-05-06 00:14:52 UTC
You're right it must be my local .ks files when I use vanilla
spin-kickstarts it works ok...

Comment 10 Jens Petersen 2010-05-06 00:26:01 UTC
Ok the problem seems to be that:

"repo ... --baseurl=..." fails as above, whereas
"repo ... --mirrorlist=..." works ok.

So it seems one can't override with a local repo apparently
which is still pretty bad IMHO.

Comment 11 Jens Petersen 2010-05-06 00:36:59 UTC
Created attachment 411769 [details]
kickstart-repo.diff

Here is the one line I change locally in the standard fedora-live-base.ks kickstart file.

Comment 12 Jens Petersen 2010-05-06 01:00:07 UTC
Doh I was missing "fedora-live-minimization.ks"!!
But the error message is hardly helpful.

Comment 13 Jens Petersen 2010-05-06 01:26:57 UTC
Spinning f13 now on F12 - so far so good. :)

Comment 14 Paul W. Frields 2010-05-06 14:23:59 UTC
OK, good to know -- I had the

Comment 15 Paul W. Frields 2010-05-06 14:35:40 UTC
Sorry about the truncated comment.  Trying again....

OK, good to know -- I had the repo changed manually to a --baseurl=http:// here and things worked fine.  Nice to see we've successfully removed one more bug from the blocker list. :-)

I agree this error message isn't helpful -- a missing ks file should be handled more gracefully.

Comment 16 Fedora Admin XMLRPC Client 2010-05-07 15:41:22 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 17 Jasper O'neal Hartline 2010-08-07 19:19:25 UTC
This is fixed in livecd-tools 033-1
http://koji.fedoraproject.org/koji/buildinfo?buildID=187263

*** This bug has been marked as a duplicate of bug 551932 ***


Note You need to log in before you can comment on or make changes to this bug.