Bug 575987 - make sure rhq-register is disabled for next JON release
Summary: make sure rhq-register is disabled for next JON release
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: Core Server
Version: 1.4
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
: ---
Assignee: John Sanda
QA Contact: Corey Welton
URL:
Whiteboard:
Depends On:
Blocks: jon-sprint9-bugs
TreeView+ depends on / blocked
 
Reported: 2010-03-22 21:59 UTC by Charles Crouch
Modified: 2015-02-01 23:25 UTC (History)
1 user (show)

Fixed In Version: 2.4
Clone Of:
Environment:
Last Closed: 2010-08-12 16:46:42 UTC
Embargoed:


Attachments (Terms of Use)

Description Charles Crouch 2010-03-22 21:59:51 UTC
If rhq-register functionality was merged into master it needs to be turned off prior to the next JON release.
Greg, may have more information about rhq-register was doing and what to look for to determine if its in Master

Comment 1 John Sanda 2010-04-22 18:22:59 UTC
Here is a summary of the relevant java files that I found,

modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/registration/RegistrationException.java

modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/registration/RegistrationManagerBean.java

modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/registration/RegistrationManagerLocal.java

modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/registration/RegistrationManagerRemote.java

modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/registration/ReleaseRepoMapping.java

modules/enterprise/server/jar/src/test/java/org/rhq/enterprise/server/registration/test/RegistrationBeanTest.java

-----------------------------------

modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/util/LookupUtil.java

modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/util/RemoteAPIValidator.java

modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/webservices/WebservicesManagerBean.java

modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/webservices/WebservicesRemote.java

modules/enterprise/server/jar/src/test/java/org/rhq/enterprise/server/resource/test/ResourceManagerBeanTest.java


The first set of classes is potentially dead code that we may want to consider altogether removing from the code base. The second set of classes has references to the first set and those references have to be removed. 

The only place I have found where the rhq-register functionality is exposed to the outside world is in the web services api. If we elect to keep the code in the source tree and do not want to expose it to the outside world, then I think we can effectively do so by removing it from the web services api.

Comment 2 John Sanda 2010-04-22 18:57:42 UTC
Removed rhq-register functionality from the web services api. Pushed commit to bugfixes branch.

hash: 36812ce7837b6db8a41c114bffcedc2e84b485c6

Comment 3 John Sanda 2010-04-22 21:27:22 UTC
Changes merged into master. Moving to ON_QA.

Comment 4 John Sanda 2010-04-26 16:54:48 UTC
Forgot to actually move this one to ON_QA.

Comment 5 Corey Welton 2010-04-27 19:43:32 UTC
QA Verified - or closing.

Comment 6 Corey Welton 2010-08-12 16:46:42 UTC
Mass-closure of verified bugs against JON.


Note You need to log in before you can comment on or make changes to this bug.