Bug 576028 - IMDB.com html changes have broken the functionality of python-imdb
Summary: IMDB.com html changes have broken the functionality of python-imdb
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-imdb
Version: 12
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 576633
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-03-23 02:53 UTC by Bob Rentschler
Modified: 2010-04-09 03:45 UTC (History)
2 users (show)

Fixed In Version: python-imdb-4.5.1-3.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-04-09 01:37:07 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch to let python-imdb use system setuptools (533 bytes, patch)
2010-03-24 17:37 UTC, Toshio Ernie Kuratomi
no flags Details | Diff

Description Bob Rentschler 2010-03-23 02:53:08 UTC
Description of problem:

jamu.py is a script included with MythTV to scrape metadata from imdb.com, it relies on IMDBpy (python-imdb) to do so. Recent changes at the imdb.com website have broken the scrape functionality in some, but not all cases.

Version-Release number of selected component (if applicable):

4.4-1

How reproducible:

Everytime.

Steps to Reproduce:
1. Use any script that relies on IMDBpy (I used jamu.py from the mythtv package)
2. Search for a movie that returns more then one result (example "The Box")
3. A script error results.
  
Actual results:

jamu.py continues to operate but skips the movie in question, but fails to enter any metadata into the db.

Expected results:

update of mythtv metadat, or any other output from various scripts on system.

Additional info:

Fixed by upgrading to IMDbPY-4.5.1

I rebuilt the SRPM using the imdbpy-4.5.1 sources and this seemed to correct all issues I had noted, however version 4.5.1 had a build time (but not runtime) dependency requiring setuptools-0.6c11, I was able to rebuild the SRPM for this without incident as well.  

I did not extensively test my RPM builds for errors, however they did pass rpmlint's simple checks at least. Seems to indicate a simple rebuild with the new upstream version will fix this.

Comment 1 Gwyn Ciesla 2010-03-23 15:29:52 UTC
I've build it for F-14 and F-13, but it dies on F-12 and F-11, even though it built on my F-12 machine:

http://koji.fedoraproject.org/koji/getfile?taskID=2070532&name=build.log

I think it's a koji issue, I'll try again soon.

Comment 2 Bob Rentschler 2010-03-23 17:43:42 UTC
I had build issues as well at first, but seeing the attempted download and build of python-setuptools I went ahead and upgraded it first, after that I had no further issues.

Looks like it failed to d/l the setuptools anyway in the koji log.

Comment 3 Gwyn Ciesla 2010-03-24 17:07:40 UTC
Ah, I read the message more closely this time.  It's not supposed to be able to download it's own version of setuptools, it needs to use the one it's given in mock.

I'll file a bug to update setuptools.

Comment 4 Toshio Ernie Kuratomi 2010-03-24 17:37:42 UTC
Created attachment 402377 [details]
Patch to let python-imdb use system setuptools

The problem is that setuptools' ez_setup is quite stupid.  Here's a patch to fix python-IMDB's setup.py to use the system setuptools and only fallback on ez_setup if it's not found.  This should be upstreamable.

Comment 5 Toshio Ernie Kuratomi 2010-03-24 17:38:28 UTC
Note I tested this and it does build beyond the setuptools problem but it looks like there's more work to be done in the spec file:  python-IMDB seems to build a C Extension now so it's no longer noarch.

Comment 6 Bob Rentschler 2010-03-24 17:57:22 UTC
The C modules may be disabled in the setup.py file inside the IMDBpy source distribution, I did this in my build as I did not need it, as far as I know no scripts installed from the Fedora repos do, however since it is there it could be included, that I am afraid is a packaging decision above my end user status.

I would be happy to test any packages if that is needed however.

Comment 7 Gwyn Ciesla 2010-03-24 17:58:24 UTC
Thanks for the patch!  I'll get this out.

Looking at the spec and the RPMS, it isn't currently noarch.

Comment 8 Gwyn Ciesla 2010-03-24 17:59:08 UTC
Bob, I'd just as soon leave them there so that developers may use them, since upstream includes them.

Comment 9 Fedora Update System 2010-03-24 18:27:51 UTC
python-imdb-4.5.1-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/python-imdb-4.5.1-3.fc12

Comment 10 Fedora Update System 2010-03-24 18:27:59 UTC
python-imdb-4.5.1-3.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/python-imdb-4.5.1-3.fc13

Comment 11 Fedora Update System 2010-03-24 18:28:07 UTC
python-imdb-4.5.1-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/python-imdb-4.5.1-3.fc11

Comment 12 Fedora Update System 2010-03-25 22:28:02 UTC
python-imdb-4.5.1-3.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-imdb'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/python-imdb-4.5.1-3.fc12

Comment 13 Fedora Update System 2010-03-25 22:37:14 UTC
python-imdb-4.5.1-3.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-imdb'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/python-imdb-4.5.1-3.fc13

Comment 14 Fedora Update System 2010-03-25 22:40:07 UTC
python-imdb-4.5.1-3.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-imdb'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/python-imdb-4.5.1-3.fc11

Comment 15 Bob Rentschler 2010-03-25 23:01:18 UTC
Successfully tested on Fedora 11 without error.

Test 1 - Series with multiple search results - pass
Test 2 - series with single search result    - pass
Test 3 - New Movie, single search result     - pass
Test 4 - New Movie, multiple search results  - pass
Test 5 - updating metadata (searches by imdb number in this case) - pass

Thanks!

Fedora 12 test in progress but I expect no problems there.

Comment 16 Fedora Update System 2010-04-09 01:36:59 UTC
python-imdb-4.5.1-3.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2010-04-09 01:38:51 UTC
python-imdb-4.5.1-3.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2010-04-09 03:45:36 UTC
python-imdb-4.5.1-3.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.