Bug 576032 - Review Request: php-channel-htmlpurifier - Adds htmlpurifier project channel to PEAR
Summary: Review Request: php-channel-htmlpurifier - Adds htmlpurifier project channel ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Pavel Alexeev
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 542045
TreeView+ depends on / blocked
 
Reported: 2010-03-23 02:57 UTC by David Nalley
Modified: 2010-09-25 05:34 UTC (History)
3 users (show)

Fixed In Version: php-channel-htmlpurifier-1.0-2.fc14
Clone Of:
Environment:
Last Closed: 2010-09-24 17:37:41 UTC
Type: ---
Embargoed:
pahan: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description David Nalley 2010-03-23 02:57:25 UTC
Spec URL: http://ke4qqq.fedorapeople.org/php-channel-htmlpurifier.spec
SRPM URL: http://ke4qqq.fedorapeople.org/php-channel-htmlpurifier-1.0-1.fc12.src.rpm
Description: This package adds the htmlpurifier channel which allows
PEAR packages from this channel to be installed.    


For the record - license determined here:
http://lists.fedoraproject.org/pipermail/legal/2010-February/001105.html

Comment 1 David Nalley 2010-03-25 02:17:26 UTC
Oddly - installing this in Fedora 12 returns the following message: 

[ke4qqq@nalleyx60 SPECS]$ sudo rpm -Uvh ../RPMS/noarch/php-channel-htmlpurifier-1.0-1.fc12.noarch.rpm 
Preparing...                ########################################### [100%]
   1:php-channel-htmlpurifie########################################### [100%]
PHP Warning:  date(): It is not safe to rely on the system's timezone settings. You are *required* to use the date.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected 'America/New_York' for 'EDT/-4.0/DST' instead in /usr/share/pear/PEAR/Registry.php on line 1012
PHP Stack trace:
PHP   1. {main}() /usr/share/pear/pearcmd.php:0
PHP   2. PEAR_Command_Common->run() /usr/share/pear/pearcmd.php:305
PHP   3. PEAR_Command_Channels->doUpdate() /usr/share/pear/PEAR/Command/Common.php:271
PHP   4. PEAR_Registry->updateChannel() /usr/share/pear/PEAR/Command/Channels.php:647
PHP   5. PEAR_Registry->addChannel() /usr/share/pear/PEAR/Registry.php:1805
PHP   6. PEAR_Registry->_addChannel() /usr/share/pear/PEAR/Registry.php:1849
PHP   7. date() /usr/share/pear/PEAR/Registry.php:1012


This appears to just be a warning and thus likely safe to ignore, and caused by E_STRICT being set in php5.3.x

I am not sure how to solve this as this appears to be a bug with pear itself.

Comment 2 Pavel Alexeev 2010-03-27 22:02:48 UTC
I unable reproduce this PHP error. I even try remove /etc/php.ini. What wersion off php and php-pear you are use?

If problem reproducable I think you shouldd report it. As minimum to php-pear in our bugzilla.

Comment 3 Pavel Alexeev 2010-03-31 20:57:36 UTC
I think there nothing to formal reviw. I had a look on it. It simple an fine.

Only one question:
BuildRequires:  php-pear >= 1:1.4.9-1.2
Where you get such version? Why exactly 1:1.4.9-1.2?
Where you got speec-template for channel? Was it one from the packages in fedora (similar to php-channel-phpunit)?

Affter resolve initial error on installation I ready approve it.
Please describe how I can reproduсe it and may be I can help.

Comment 4 David Nalley 2010-04-02 02:46:24 UTC
Pavel: 
I literally copied it from php-channel-symfony. 
I have no reason to believe that changing the BR to php-pear will not work for modern version of pear. 
I am working on the problem in comment 1 and should have a reply shortly. 

(In reply to comment #3)
> I think there nothing to formal reviw. I had a look on it. It simple an fine.
> 
> Only one question:
> BuildRequires:  php-pear >= 1:1.4.9-1.2
> Where you get such version? Why exactly 1:1.4.9-1.2?
> Where you got speec-template for channel? Was it one from the packages in
> fedora (similar to php-channel-phpunit)?
> 
> Affter resolve initial error on installation I ready approve it.
> Please describe how I can reproduсe it and may be I can help.

Comment 5 Pavel Alexeev 2010-08-24 10:23:19 UTC
ping?

Comment 6 David Nalley 2010-08-28 00:29:24 UTC
Pavel: 

My apologies for letting this fall off my radar. 

PHP warning were caused by E_ALL being set as the warning level for other debugging - I am not able to replicate the problem when set to a sane level. 

I updated the requires: 

SRPM: http://ke4qqq.fedorapeople.org/php-channel-htmlpurifier-1.0-2.fc13.src.rpm
SPEC: http://ke4qqq.fedorapeople.org/php-channel-htmlpurifier.spec


Thanks for your patience.

Comment 7 Pavel Alexeev 2010-08-30 06:59:00 UTC
Package APPROVED.

Good luck.

Comment 8 David Nalley 2010-09-05 04:34:18 UTC
Pavel: 

Thanks for the review!


New Package SCM Request
=======================
Package Name: php-channel-htmlpurifier
Short Description: Adds htmlpurifier project channel to PEAR
Owners: ke4qqq
Branches: f12, f13, f14, el5, el6

Comment 9 Kevin Fenzi 2010-09-05 17:41:36 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2010-09-05 19:38:45 UTC
php-channel-htmlpurifier-1.0-2.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/php-channel-htmlpurifier-1.0-2.fc12

Comment 11 Fedora Update System 2010-09-05 19:38:50 UTC
php-channel-htmlpurifier-1.0-2.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/php-channel-htmlpurifier-1.0-2.el5

Comment 12 Fedora Update System 2010-09-05 19:38:55 UTC
php-channel-htmlpurifier-1.0-2.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/php-channel-htmlpurifier-1.0-2.fc13

Comment 13 Fedora Update System 2010-09-05 19:39:00 UTC
php-channel-htmlpurifier-1.0-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/php-channel-htmlpurifier-1.0-2.fc14

Comment 14 Fedora Update System 2010-09-06 05:14:39 UTC
php-channel-htmlpurifier-1.0-2.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-channel-htmlpurifier'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/php-channel-htmlpurifier-1.0-2.fc14

Comment 15 Fedora Update System 2010-09-06 18:25:30 UTC
php-channel-htmlpurifier-1.0-2.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-channel-htmlpurifier'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/php-channel-htmlpurifier-1.0-2.el5

Comment 16 Fedora Update System 2010-09-24 17:37:37 UTC
php-channel-htmlpurifier-1.0-2.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2010-09-24 20:34:50 UTC
php-channel-htmlpurifier-1.0-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2010-09-24 20:44:49 UTC
php-channel-htmlpurifier-1.0-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Update System 2010-09-25 05:34:32 UTC
php-channel-htmlpurifier-1.0-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.