Bug 576076 - [abrt] *** buffer overflow detected *** in parse_file
Summary: [abrt] *** buffer overflow detected *** in parse_file
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cvsps
Version: 14
Hardware: x86_64
OS: Linux
low
medium
Target Milestone: ---
Assignee: Honza Horak
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:b1777336042f16440a1a587953c...
: 652849 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-03-23 07:26 UTC by Matt McCutchen
Modified: 2012-12-27 05:22 UTC (History)
5 users (show)

Fixed In Version: cvsps-2.2-0.8.b1.fc15
Clone Of:
Environment:
Last Closed: 2011-03-01 04:20:59 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (4.41 KB, text/plain)
2010-03-23 07:26 UTC, Matt McCutchen
no flags Details
Proposed patch (1.82 KB, patch)
2010-09-07 16:32 UTC, Jiri Moskovcak
no flags Details | Diff

Description Matt McCutchen 2010-03-23 07:26:30 UTC
abrt 1.0.8 detected a crash.

architecture: x86_64
Attached file: backtrace
cmdline: cvsps --norc -q --cvs-direct -u -A --root :pserver:anonymous.org:/cvsroot NSS
component: cvsps
executable: /usr/bin/cvsps
kernel: 2.6.32.9-70.fc12.x86_64
package: cvsps-2.2-0.5.b1.fc12
rating: 4
reason: Process /usr/bin/cvsps was killed by signal 6 (SIGABRT)
release: Fedora release 12 (Constantine)

How to reproduce
-----
rm -f ~/'.cvsps/:pserver:anonymous.org:#cvsroot#NSPR'
# The following command line is from "git cvsimport" but the crash is reproducible independently.
cvsps --norc -q --cvs-direct -u -A --root :pserver:anonymous.org:/cvsroot NSS

Comment 1 Matt McCutchen 2010-03-23 07:26:32 UTC
Created attachment 401950 [details]
File: backtrace

Comment 2 Matt McCutchen 2010-03-23 07:53:28 UTC
If I take away the -q option, I see output like this:

cvs_direct initialized to CVSROOT /cvsroot
cvs rlog: Logging mozilla/dbm
WARNING: file /cvsroot/mozilla/dbm/.cvsignore doesn't match strip_path /cvsroot/NSS/. ignoring
WARNING: file /cvsroot/mozilla/dbm/Attic/Makefile doesn't match strip_path /cvsroot/NSS/. ignoring
[...]
NOTICE: used alternate strip path /cvsroot/mozilla/security/nss/cmd/SSLsample/Attic/Makefile.NSS

It looks like cvsps doesn't really understand modules and is falsely triggered by the "NSS" at the end of the filename.  I'll need to use a different approach.  But at least cvsps shouldn't crash.

Comment 3 Ville Skyttä 2010-03-23 21:45:31 UTC
Thanks for the reproducer.  Reproduced and bug report forwarded upstream, waiting for comments.

Comment 4 Fedora Admin XMLRPC Client 2010-09-07 08:20:50 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 5 Jiri Moskovcak 2010-09-07 16:32:57 UTC
Created attachment 443877 [details]
Proposed patch

Comment 6 Bug Zapper 2010-11-03 18:50:36 UTC
This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 7 Matt McCutchen 2010-11-12 23:20:15 UTC
*** Bug 652849 has been marked as a duplicate of this bug. ***

Comment 8 Matt McCutchen 2010-11-12 23:21:52 UTC
cvsps-2.2-0.6.b1.fc14 still crashes.

Comment 9 Michel Lind 2010-11-13 14:34:23 UTC
Do we have this patch applied, and what's the link to the upstream bug report?

Comment 10 Jiri Moskovcak 2010-11-13 15:29:51 UTC
Can someone please try the build from:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2598985

I seems to work, but I'm not cvsps user, so I can't tell if the patch broke something.

Thank you.

Comment 11 Fedora Admin XMLRPC Client 2011-01-07 13:49:28 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 12 Honza Horak 2011-02-14 12:06:25 UTC
The patch works for me very well. I've found no other issues, but any another regression test is welcome.

A new build is now available:
http://koji.fedoraproject.org/koji/buildinfo?buildID=228611

Comment 13 Fedora Update System 2011-02-14 12:08:05 UTC
cvsps-2.2-0.8.b1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/cvsps-2.2-0.8.b1.fc15

Comment 14 Fedora Update System 2011-02-14 12:09:56 UTC
cvsps-2.2-0.8.b1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/cvsps-2.2-0.8.b1.fc14

Comment 15 Fedora Update System 2011-02-14 20:29:45 UTC
cvsps-2.2-0.8.b1.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cvsps'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/cvsps-2.2-0.8.b1.fc14

Comment 16 Michal Hlavinka 2011-02-15 16:11:18 UTC
thanks for fixing it

Comment 17 Fedora Update System 2011-02-15 16:47:56 UTC
cvsps-2.2-0.8.b1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/cvsps-2.2-0.8.b1.fc13

Comment 18 Fedora Update System 2011-03-01 04:20:53 UTC
cvsps-2.2-0.8.b1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Update System 2011-03-01 04:24:43 UTC
cvsps-2.2-0.8.b1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 20 Fedora Update System 2011-03-03 03:38:55 UTC
cvsps-2.2-0.8.b1.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 21 Eric Raymond 2012-12-27 05:22:03 UTC
I'm the new cvsps maintainer.  The fix patch for this bug has been merged upstream and is now in the cvsps public repo at git:cvsps/cvsps.git


Note You need to log in before you can comment on or make changes to this bug.