Bug 576550 - setfacl segfaults on malformed restore file
Summary: setfacl segfaults on malformed restore file
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: acl
Version: 11
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Steve Dickson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-03-24 12:46 UTC by Kamil Dudka
Modified: 2011-04-07 13:45 UTC (History)
4 users (show)

Fixed In Version: acl-2.2.49-5.fc13
Clone Of:
Environment:
Last Closed: 2010-04-20 13:04:03 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
fix, including a test-case (717 bytes, patch)
2010-03-24 14:26 UTC, Kamil Dudka
no flags Details | Diff

Description Kamil Dudka 2010-03-24 12:46:39 UTC
Bug originally reported by Ales Zelinka.

Description of problem:
setfacl segfaults when there is no filename on the first line of a restore file (even-though it detects and reports the problem at first): 

$cat dump
# owner: root
# group: root
user::rw-
group::r--
other::r--

$setfacl  --restore=dump ; echo $?
setfacl: dump: No filename found in line 0, aborting
Segmentation fault (core dumped)
139

(gdb) bt
#0  seq_free (seq=<value optimized out>) at sequence.c:62
#1  0x08049c5e in restore (file=<value optimized out>, filename=<value optimized out>) at setfacl.c:241
#2  0x0804a2cf in main (argc=<value optimized out>, argv=<value optimized out>) at setfacl.c:569


Version-Release number of selected component (if applicable):
acl-2.2.49 (from F-11 to rawhide)

Comment 1 Kamil Dudka 2010-03-24 14:26:09 UTC
Created attachment 402323 [details]
fix, including a test-case

Comment 2 Kamil Dudka 2010-03-24 14:40:46 UTC
proposed upstream:
http://lists.gnu.org/archive/html/acl-devel/2010-03/msg00001.html

Comment 4 Fedora Update System 2010-03-24 17:05:27 UTC
acl-2.2.49-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/acl-2.2.49-3.fc12

Comment 5 Fedora Update System 2010-03-24 17:05:32 UTC
acl-2.2.49-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/acl-2.2.49-3.fc11

Comment 6 Fedora Update System 2010-03-24 17:05:37 UTC
acl-2.2.49-5.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/acl-2.2.49-5.fc13

Comment 7 Fedora Update System 2010-03-25 22:24:32 UTC
acl-2.2.49-3.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update acl'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/acl-2.2.49-3.fc11

Comment 8 Fedora Update System 2010-03-25 22:26:06 UTC
acl-2.2.49-3.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update acl'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/acl-2.2.49-3.fc12

Comment 9 Fedora Update System 2010-03-25 22:37:38 UTC
acl-2.2.49-5.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update acl'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/acl-2.2.49-5.fc13

Comment 10 Fedora Update System 2010-04-20 13:03:58 UTC
acl-2.2.49-3.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2010-04-20 13:09:53 UTC
acl-2.2.49-3.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2010-04-21 22:02:31 UTC
acl-2.2.49-5.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.